IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Project: platform/frameworks/support
Branch: androidx-main

commit fb14567d675ea2f166937f5639430bb2aa0d3a71
Author: Clara Fok <clarafok@google.com>
Date:   Mon Jun 03 16:08:07 2024

    Handle empty CollectionNavType
   
    For collection types, in the past if no value was passed in, the arg would be ignored and omitted from argument bundle. Now, a missing collection type value will default to the NavArgument's defaultValue, or an emptyList if there isn't a defaultValue.
   
    What is considered "no value" is different between list of strings and list of non-strings. For clarity, this is how various routes are handled:
   
    Given a route pattern "www.test.com?list={myList}"
   
    List<String>
    1. "www.test.com?list=" considered as listOf("")
    2. "www.test.com?list={myList}" considered as listOf("{myList}")
    3. "www.test.com?" considered as no value
    4. "www.test.com" considered as no value
   
    non-String lists
    1. "www.test.com?list=" considered as no value (since it is invalid)
    2. "www.test.com?list={myList}" considered as no value
    3. "www.test.com?" considered as no value
    4. "www.test.com" considered as no value
   
    Test: ./gradlew navigation:navigation-common:cC
    Test: ./gradlew navigation:navigation-runtime:cC
    Bug: 341723133
    Relnote: "Fix how navigation handles missing arg values for CollectionNavTypes - instead of ignoring missing values, navigation will now default to its defaultValue, or an empty collection if there isn't a defaultValue. This fallback value will be added the NavBackStackEntry.argument bundle."
   
    Change-Id: Id630fb148782fbb34d3c236f5d8bb363fba7ef91

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/test/NavArgument.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M       navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3112742

Project: platform/frameworks/support
Branch: androidx-main

commit 1ae187912afa613f6c1dad408017ebc4b0c3cc41
Author: Clara Fok <clarafok@google.com>
Date:   Mon Jun 03 16:52:11 2024

    Add safe args tests for empty lists
   
    Test: ./gradlew navigation:navigation-common:cC
    Test ./gradlew navigation:navigation-runtime:cC
    Bug: 341723133
   
    Change-Id: I1c67ff34424a4559ed09ad2ef1f92c7baec2e23a

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M       navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3112743