Supplying an empty list for a startDestination's argument causes app to crash [341723133]

Fixed

Bug

Status Update

No update yet.

Description

do...@google.com

created issue #1

May 20, 2024 05:03PM

Component used: Navigation

Version used: 2.8.0-beta01

Devices/Android versions reproduced on: all

When specifying the startDestination for a NavHost, if the destination class is instantiated with an empty list for one of its properties, the app will crash.

Repro code:

@Composable
fun Content() {
   val navController = rememberNavController()
   NavHost(navController = navController, startDestination = Home(usernames = emptyList())) {
       composable<Home> { backStackEntry ->
           val home: Home = backStackEntry.toRoute()
           for (username in home.usernames) {
               Text(username)
           }
       }
   }
}

@Serializable
data class Home(
   val usernames: List<String>,
)

Expected outcome:

App runs and displays an empty screen

Actual outcome:

App crashes with the following error in logcat:

java.lang.IllegalArgumentException: navigation destination com.example.hellonavigation.Home is not a direct child of this NavGraph

Possibly related to: https://b.corp.google.com/issues/339481310

Comments

jb...@google.com <jb...@google.com> May 21, 2024 02:01PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2May 21, 2024 08:29PM

since these are in public API (:/) we need to do this in 1.2

ap...@google.com <ap...@google.com> #3Jun 5, 2024 12:36AM

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4Jun 5, 2024 02:11AM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Jun 6, 2024 06:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ap...@google.com <ap...@google.com> #6Jun 6, 2024 06:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1ae187912afa613f6c1dad408017ebc4b0c3cc41
Author: Clara Fok <clarafok@google.com>
Date: Mon Jun 03 16:52:11 2024

Add safe args tests for empty lists

Test: ./gradlew navigation:navigation-common:cC
Test ./gradlew navigation:navigation-runtime:cC
Bug: 341723133

Change-Id: I1c67ff34424a4559ed09ad2ef1f92c7baec2e23a

M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3112743

cl...@google.com <cl...@google.com> #7Jun 6, 2024 06:41PM

Marked as fixed.

Fixed internally and will be available in navigation 2.8.0-beta03.

pr...@google.com <pr...@google.com> #8Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta03
androidx.navigation:navigation-compose:2.8.0-beta03
androidx.navigation:navigation-runtime:2.8.0-beta03