Change to ViewModelProvider$Factory.create breaks backward compatibility in lifecycle-viewmodel 2.8 [341792251]

Fixed

Bug

Status Update

No update yet.

Description

py...@gmail.com

created issue #1

May 21, 2024 05:10AM

Component used: lifecycle-viewmodel

Version used: 2.8

Summary: the migration of ViewModelProvider to KMP seemingly reverted a 2 year old fix to an issue that had to do with desugaring for compileOnly dependencies in a library project.

Lifecycle 2.5.0 alpha accidentally broke backward compatibility, this was quickly fixed in Lifecycle 2.5.0-rc02, see this issue for context: https://issuetracker.google.com/issues/230454566

The fix was here: https://android-review.googlesource.com/c/platform/frameworks/support/+/2108693

The recent migration of ViewModelProvider.Factory to KMP seems to have reverted the fix: https://android-review.googlesource.com/c/platform/frameworks/support/+/2966765

As a result, the original runtime crash has surfaced again in lifecycle-viewmodel 2.8, as reported here: https://github.com/square/leakcanary/issues/2677

Someone created a repro at the time, you could probably reuse that to repro after updating the dependencies: https://github.com/dougnazar/leak_viewmodel

Comments

mg...@google.com <mg...@google.com> May 21, 2024 01:12PM

Assigned to mg...@google.com.

dr...@gmail.com <dr...@gmail.com> #2May 24, 2024 05:32PM

I realize this should be filed as a feature request

ap...@google.com <ap...@google.com> #3May 29, 2024 04:12PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit ed2450ec5d2cdf62f1ebf13a29fe04295ad65e44
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Dec 30 19:22:41 2021

Add material decoration box for TextField and OutlinedTextField

It allows additionally to what is customisable in text fields already to customise paddings (incl. for dense text field support), border or indicator line.

In the future we could add prefix/suffix, helper message slots.

Fixes: 203764564
Fixes: 191543915
Fixes: 189971673
Fixes: 183136600
Fixes: 179882597
Fixes: 168003617
Test: TextFieldTest and OutlinedTextFieldTest
Test: new tests TextFieldDecorationBoxTest
Relnote: "Added TextFieldDecorationBox and
OutlinedTextFieldDecorationBox. Using them together with BasicTextField
will help you build custom text field based on Material Design text
fields but with more options for customisation."
Relnote: "Provided a way to adjust horizontal and vertical paddings in text fields."

Change-Id: I8c9f168a687e337670c266e1eb3e985da6aebdc3

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/api/public_plus_experimental_current.txt
A compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1934969

mg...@google.com <mg...@google.com> #4Jun 3, 2024 02:45PM

Could be also great if the indicator lines can be a Brush not just a Color

Message last modified on Jun 3, 2024 03:17PM

pr...@google.com <pr...@google.com> #5Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel:2.8.2
androidx.lifecycle:lifecycle-viewmodel-android:2.8.2
androidx.lifecycle:lifecycle-viewmodel-desktop:2.8.2
androidx.lifecycle:lifecycle-viewmodel-iosarm64:2.8.2
androidx.lifecycle:lifecycle-viewmodel-iossimulatorarm64:2.8.2
androidx.lifecycle:lifecycle-viewmodel-iosx64:2.8.2
androidx.lifecycle:lifecycle-viewmodel-linuxx64:2.8.2
androidx.lifecycle:lifecycle-viewmodel-macosarm64:2.8.2
androidx.lifecycle:lifecycle-viewmodel-macosx64:2.8.2

pr...@google.com <pr...@google.com> #6Aug 13, 2024 06:59PM