Change to ViewModelProvider$Factory.create breaks backward compatibility in lifecycle-viewmodel 2.8 [341792251]

Fixed

Bug

Status Update

No update yet.

Description

py...@gmail.com

created issue #1

May 21, 2024 05:10AM

Component used: lifecycle-viewmodel

Version used: 2.8

Summary: the migration of ViewModelProvider to KMP seemingly reverted a 2 year old fix to an issue that had to do with desugaring for compileOnly dependencies in a library project.

Lifecycle 2.5.0 alpha accidentally broke backward compatibility, this was quickly fixed in Lifecycle 2.5.0-rc02, see this issue for context: https://issuetracker.google.com/issues/230454566

The fix was here: https://android-review.googlesource.com/c/platform/frameworks/support/+/2108693

The recent migration of ViewModelProvider.Factory to KMP seems to have reverted the fix: https://android-review.googlesource.com/c/platform/frameworks/support/+/2966765

As a result, the original runtime crash has surfaced again in lifecycle-viewmodel 2.8, as reported here: https://github.com/square/leakcanary/issues/2677

Someone created a repro at the time, you could probably reuse that to repro after updating the dependencies: https://github.com/dougnazar/leak_viewmodel

Comments

mg...@google.com <mg...@google.com> May 21, 2024 01:12PM

Assigned to mg...@google.com.

dr...@gmail.com <dr...@gmail.com> #2May 24, 2024 05:32PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ap...@google.com <ap...@google.com> #3May 29, 2024 04:12PM

Marked as fixed.

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

mg...@google.com <mg...@google.com> #4Jun 3, 2024 02:45PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Message last modified on Jun 3, 2024 03:17PM

pr...@google.com <pr...@google.com> #5Jun 12, 2024 10:45PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

pr...@google.com <pr...@google.com> #6Aug 13, 2024 06:59PM

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

Issue 341792251