Crash when reopening app after process death if using typed navigation and LazyRow [341801005]

Fixed

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

May 21, 2024 08:41AM

Component used: Navigation

Version used: 2.8.0-beta01

Devices/Android versions reproduced on: 24-33

Tested on emulators with android 24 and 33, and on a real device with android 24

To trigger system initiated process death, I set the background processes limit to 0

The following exception is thrown upon reopening the application: java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 161177858 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x8431a13) route=com.myk00l.test.B}

package com.myk00l.test

import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.material3.Text
import androidx.navigation.compose.NavHost
import androidx.navigation.compose.composable
import androidx.navigation.compose.rememberNavController
import kotlinx.serialization.Serializable

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            val navController = rememberNavController()
            NavHost(navController=navController, startDestination = B) {
                composable<B> {
                    LazyRow {
                        items(3) { i ->
                            Text(i.toString())
                        }
                    }
                }
            }
        }
    }
}

@Serializable
object B

FATAL EXCEPTION: main
Process: com.myk00l.test, PID: 19082
java.lang.IllegalStateException: Restoring the Navigation backstack failed: destination 161177858 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x8431a13) route=com.myk00l.test.B}
at androidx.navigation.NavController.onGraphCreated(NavController.kt:1365)
at androidx.navigation.NavController.setGraph(NavController.kt:1310)
at androidx.navigation.NavController.setGraph(NavController.kt:105)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:448)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:317)
at com.myk00l.test.ComposableSingletons$MainActivityKt$lambda-3$1.invoke(MainActivity.kt:18)
at com.myk00l.test.ComposableSingletons$MainActivityKt$lambda-3$1.invoke(MainActivity.kt:16)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.ui.platform.ComposeView.Content(ComposeView.android.kt:428)
at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:252)
at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:251)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:216)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:132)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:131)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:121)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:155)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:154)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:401)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:154)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:133)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.ActualJvm_jvmKt.invokeComposable(ActualJvm.jvm.kt:97)
at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3593)
at androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3520)
at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:743)
at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1114)
at androidx.compose.runtime.CompositionImpl.composeInitial(Composition.kt:649)
at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:635)
at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)

Comments

jb...@google.com <jb...@google.com> May 21, 2024 02:02PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2May 22, 2024 01:13AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

mi...@gmail.com <mi...@gmail.com> #3May 22, 2024 09:16AM

yea i'll take it.

test.zip

41 MB

Download

do...@noteing.com <do...@noteing.com> #4May 28, 2024 08:05AM

Comment has been deleted.

Message last modified on May 28, 2024 08:11AM

sa...@gmail.com <sa...@gmail.com> #5Jun 3, 2024 08:45PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

Message last modified on Jun 3, 2024 08:47PM

be...@gmail.com <be...@gmail.com> #6Jun 12, 2024 08:13PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Message last modified on Jun 12, 2024 08:15PM

be...@gmail.com <be...@gmail.com> #7Jun 14, 2024 09:23AM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

cl...@google.com <cl...@google.com> Jun 14, 2024 05:41PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #8Jun 14, 2024 06:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

cl...@google.com <cl...@google.com> #9Jun 14, 2024 06:31PM

Marked as fixed.

Fixed internally and will be available in navigation-2.8.0-rc01

jo...@hella.info <jo...@hella.info> #10Jun 26, 2024 12:09AM

I have a lot of code like this:
```
val entry by navController.currentBackStackEntryAsState()
when (entry?.destination?.id) {
ScreenA.serializer().hashCode() -> R.string.example
...
}
```
Just to describe the current screen in a top bar. I used to do this with the `route` instead of the `id, and i have searched for quite a while for an alternative with type safe navigation and found this possibility.
I think this commit will break my code, right? And if so, what would be the correct way to determine the current type safe navigation route i am on?

cl...@google.com <cl...@google.com> #11Jun 26, 2024 01:03AM

comment#10 you'll want to use the hasRoute api. If you have further questions, please file a separate bug.

pr...@google.com <pr...@google.com> #12Jun 26, 2024 05:43PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta04
androidx.navigation:navigation-runtime:2.8.0-beta04

ni...@gmail.com <ni...@gmail.com> #13Sep 10, 2024 01:40PM

I am using version 2.8.0 and still get this error when the app has been in the background for a few hours when I reopen it. There is a hint in the previous comment that there are more parts to address. Is there anything more planned regarding this issue?

jb...@google.com <jb...@google.com> #14Sep 10, 2024 02:17PM

Please file a separate bug with a minimal sample project that reproduces your issue.