Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
cl...@google.com <cl...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
mi...@gmail.com <mi...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
do...@noteing.com <do...@noteing.com> #4
Comment has been deleted.
sa...@gmail.com <sa...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
be...@gmail.com <be...@gmail.com> #6
Yes can also reproduce in my app! App in background, get process killed, reopen it and it crashes.
Lib version: 2.8.0-beta02
Os version: all
Language: all
Please fix it quickly as typed navigation is really something needed. Thanks guys you rock <3
Lib version: 2.8.0-beta02
Os version: all
Language: all
Please fix it quickly as typed navigation is really something needed. Thanks guys you rock <3
be...@gmail.com <be...@gmail.com> #7
Oh yeah <3
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 194e1790e466b8ac2bd8a87e9745e53d1503e1f5
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 13 16:13:42 2024
Fix crash when resume after process death
RestoreState crashes when resuming after process death because the destination ID which is based on serializer hashcode() is different after process death.
Update the hash algorithm that safe argsdestination.id is based on.
Test: manual test by killing process in emulator
Test: ./gradlew navigation:navigation-common:cC
Test: ./graldew navigation:navigation-runtime:cC
Bug: 341801005
Relnote: "Fixed crash from restore state when resuming the app after process death."
Change-Id: Ia8f38fc59b8e4dac1910c5a593e1ec0585e59456
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
A navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/TestUtil.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteSerializer.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/3132936
Branch: androidx-main
commit 194e1790e466b8ac2bd8a87e9745e53d1503e1f5
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 13 16:13:42 2024
Fix crash when resume after process death
RestoreState crashes when resuming after process death because the destination ID which is based on serializer hashcode() is different after process death.
Update the hash algorithm that safe args
Test: manual test by killing process in emulator
Test: ./gradlew navigation:navigation-common:cC
Test: ./graldew navigation:navigation-runtime:cC
Bug: 341801005
Relnote: "Fixed crash from restore state when resuming the app after process death."
Change-Id: Ia8f38fc59b8e4dac1910c5a593e1ec0585e59456
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
A navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/TestUtil.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteSerializer.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
cl...@google.com <cl...@google.com> #9
Fixed internally and will be available in navigation-2.8.0-rc01
jo...@hella.info <jo...@hella.info> #10
I have a lot of code like this:
```
val entry by navController.currentBackStackEntryAsState()
when (entry?.destination?.id) {
ScreenA.serializer().hashCode() -> R.string.example
...
}
```
Just to describe the current screen in a top bar. I used to do this with the `route` instead of the `id, and i have searched for quite a while for an alternative with type safe navigation and found this possibility.
I think this commit will break my code, right? And if so, what would be the correct way to determine the current type safe navigation route i am on?
```
val entry by navController.currentBackStackEntryAsState()
when (entry?.destination?.id) {
ScreenA.serializer().hashCode() -> R.string.example
...
}
```
Just to describe the current screen in a top bar. I used to do this with the `route` instead of the `id, and i have searched for quite a while for an alternative with type safe navigation and found this possibility.
I think this commit will break my code, right? And if so, what would be the correct way to determine the current type safe navigation route i am on?
cl...@google.com <cl...@google.com> #11
pr...@google.com <pr...@google.com> #12
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta04
androidx.navigation:navigation-runtime:2.8.0-beta04
ni...@gmail.com <ni...@gmail.com> #13
I am using version 2.8.0 and still get this error when the app has been in the background for a few hours when I reopen it. There is a hint in the previous comment that there are more parts to address. Is there anything more planned regarding this issue?
jb...@google.com <jb...@google.com> #14
Please file a separate bug with a minimal sample project that reproduces your issue.
Description
Component used: Navigation
Version used: 2.8.0-beta01
Devices/Android versions reproduced on: 24-33
Tested on emulators with android 24 and 33, and on a real device with android 24
To trigger system initiated process death, I set the background processes limit to 0
The following exception is thrown upon reopening the application:
java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 161177858 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x8431a13) route=com.myk00l.test.B}