Crash when reopening app after process death if using typed navigation and LazyRow [341801005]

Fixed

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

May 21, 2024 08:41AM

Component used: Navigation

Version used: 2.8.0-beta01

Devices/Android versions reproduced on: 24-33

Tested on emulators with android 24 and 33, and on a real device with android 24

To trigger system initiated process death, I set the background processes limit to 0

The following exception is thrown upon reopening the application: java.lang.IllegalStateException: Restoring the Navigation back stack failed: destination 161177858 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x8431a13) route=com.myk00l.test.B}

package com.myk00l.test

import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.lazy.LazyRow
import androidx.compose.material3.Text
import androidx.navigation.compose.NavHost
import androidx.navigation.compose.composable
import androidx.navigation.compose.rememberNavController
import kotlinx.serialization.Serializable

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            val navController = rememberNavController()
            NavHost(navController=navController, startDestination = B) {
                composable<B> {
                    LazyRow {
                        items(3) { i ->
                            Text(i.toString())
                        }
                    }
                }
            }
        }
    }
}

@Serializable
object B

FATAL EXCEPTION: main
Process: com.myk00l.test, PID: 19082
java.lang.IllegalStateException: Restoring the Navigation backstack failed: destination 161177858 cannot be found from the current destination ComposeNavGraph(0x0) startDestination={Destination(0x8431a13) route=com.myk00l.test.B}
at androidx.navigation.NavController.onGraphCreated(NavController.kt:1365)
at androidx.navigation.NavController.setGraph(NavController.kt:1310)
at androidx.navigation.NavController.setGraph(NavController.kt:105)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:448)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:317)
at com.myk00l.test.ComposableSingletons$MainActivityKt$lambda-3$1.invoke(MainActivity.kt:18)
at com.myk00l.test.ComposableSingletons$MainActivityKt$lambda-3$1.invoke(MainActivity.kt:16)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.ui.platform.ComposeView.Content(ComposeView.android.kt:428)
at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:252)
at androidx.compose.ui.platform.AbstractComposeView$ensureCompositionCreated$1.invoke(ComposeView.android.kt:251)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
at androidx.compose.ui.platform.CompositionLocalsKt.ProvideCommonCompositionLocals(CompositionLocals.kt:216)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:132)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt$ProvideAndroidCompositionLocals$3.invoke(AndroidCompositionLocals.android.kt:131)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
at androidx.compose.ui.platform.AndroidCompositionLocals_androidKt.ProvideAndroidCompositionLocals(AndroidCompositionLocals.android.kt:121)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:155)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1$3.invoke(Wrapper.android.kt:154)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:401)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:154)
at androidx.compose.ui.platform.WrappedComposition$setContent$1$1.invoke(Wrapper.android.kt:133)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.ActualJvm_jvmKt.invokeComposable(ActualJvm.jvm.kt:97)
at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3593)
at androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3520)
at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:743)
at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1114)
at androidx.compose.runtime.CompositionImpl.composeInitial(Composition.kt:649)
at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:635)
at androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)

Comments

jb...@google.com <jb...@google.com> May 21, 2024 02:02PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2May 22, 2024 01:13AM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

mi...@gmail.com <mi...@gmail.com> #3May 22, 2024 09:16AM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

test.zip

41 MB

Download

do...@noteing.com <do...@noteing.com> #4May 28, 2024 08:05AM

Comment has been deleted.

Message last modified on May 28, 2024 08:11AM

sa...@gmail.com <sa...@gmail.com> #5Jun 3, 2024 08:45PM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

Message last modified on Jun 3, 2024 08:47PM

be...@gmail.com <be...@gmail.com> #6Jun 12, 2024 08:13PM

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Message last modified on Jun 12, 2024 08:15PM

be...@gmail.com <be...@gmail.com> #7Jun 14, 2024 09:23AM

Added a patch for androidx-master-dev that demos a horizontal ViewPager2 inside a vertical RecyclerView.

Verified that it works correctly on a:
- Nexus 4 emulator with API 17
- Nexus 5X emulator with API 28
- Pixel 2 device with API 29

To reproduce:
- Check out the Android Jetpack source (at commit 256899f482ff85cddfb050f37550be7b5ec927ef) (see steps in [1])
- Apply the patch (`git apply 0001-Add-sample-where-a-horizontal-ViewPager2-is-nested-i.patch`)
- Build and install viewpager2's integration-tests app: `./gradlew viewpager2:integration-tests:testapp:installDebug`
- Run it

Closing the issue for now, but please reopen if you have a minimal reproduction app

[1]

https://android.googlesource.com/platform/frameworks/support/+/256899f482ff85cddfb050f37550be7b5ec927ef

cl...@google.com <cl...@google.com> Jun 14, 2024 05:41PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #8Jun 14, 2024 06:09PM

Re-opening as requested by a few users. Narrowed down the focus to nested scrolling elements with the same scroll direction.

cl...@google.com <cl...@google.com> #9Jun 14, 2024 06:31PM

Marked as fixed.

Any progress on this? (only talking about the "same scroll direction" issue)

I searched a lot for workarounds on Google and SO, but it seems no one really found a suitable solution yet.
The thing is that all other VerticalViewPagers out there have other problems that are similarly annoying. Most of them revolve around touch issues like "What's a click and what's a swipe" or "what's the fling threshold to snap to the next page".

So if someone knows of a working sample of VerticalViewPagers, I'd be happy to see a link :)

jo...@hella.info <jo...@hella.info> #10Jun 26, 2024 12:09AM

Hi, we're unlikely to address the "same scroll direction" issue before 1.0-Stable as it's likely going to require API changes (so v1.1+).

One possible option for VerticalViewPager with nested scrolling in the same scroll direction is using a RecyclerView implementing NestedScrollingParent + PagerSnapHelper to get snapping.
You'd then have to implement the NestedScrollingParent/Child contract between parent/child RecyclerView instances.

cl...@google.com <cl...@google.com> #11Jun 26, 2024 01:03AM

Cool, thanks for this quick answer - Both pieces of information are highly appreciated (rough estimate of tackling this as well as giving hint on how to do it).
I will try implementing what you suggested and in case it is readable code, I will post it here as sample project or somthing similar.

pr...@google.com <pr...@google.com> #12Jun 26, 2024 05:43PM

That'd be great, much appreciated!

ni...@gmail.com <ni...@gmail.com> #13Sep 10, 2024 01:40PM

So...I was too stupid to understand the back and forth and up and down of NestedScrollingParent and NestedScrollingChild/NestedScrollingChild2 and NestedScrollingParentHelper and NestedScrollingChildHelper
But I figured out another way to achieve the same goal. I attached a demo project with the following setup:

1. A parent RecyclerView with PagerSnapHelper:
This vertical RecyclerView has two items/pages.
The upper page is just a simple TextView.
The lower page contains the nested RecyclerView.
Both pages are Fragments if that is of any concern.

2. A PagingLinearLayoutManager:
This is a LinearLayoutManager with the capability to enable/disable scrolling.
It is used for the parent RecyclerView.

3. A OnItemTouchListener:
This is also used for the parent RecyclerView.
It saved the initial y coordinate on ACTION_DOWN
During ACTION_MOVE event, it decides whether the PagingLinearLayoutManager is allowed to scroll (i.e. to switch between pages)

The important parts of the code are commented. Hope this helps someone else!

jb...@google.com <jb...@google.com> #14Sep 10, 2024 02:17PM

Same promble