Fixed
Status Update
No update yet.
Comments
cc...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 00346a8a8189c7d5b7a9e0177a0ea9db84c047c2
Author: Chris Craik <ccraik@google.com>
Date: Tue May 21 13:32:20 2024
Change macro -> benchmark-common dependency to api
Fixes: 341851833
Test: None
Relnote: "Change macro->common dependency to be api(), so it's easier
to use e.g. PerfettoTrace and PerfettoConfig"
Benchmark macro exposes several common APIs directly, such as
PerfettoTrace and PerfettoConfig.
Note that these common APIs are experimental, and theoretically should
be moved to their own library at some point, but we can revisit this
api vs implementation decision at that point.
Change-Id: Icdae394628d71131e556c6a02840c6c894f82957
M benchmark/benchmark-macro/build.gradle
https://android-review.googlesource.com/3095932
Branch: androidx-main
commit 00346a8a8189c7d5b7a9e0177a0ea9db84c047c2
Author: Chris Craik <ccraik@google.com>
Date: Tue May 21 13:32:20 2024
Change macro -> benchmark-common dependency to api
Fixes: 341851833
Test: None
Relnote: "Change macro->common dependency to be api(), so it's easier
to use e.g. PerfettoTrace and PerfettoConfig"
Benchmark macro exposes several common APIs directly, such as
PerfettoTrace and PerfettoConfig.
Note that these common APIs are experimental, and theoretically should
be moved to their own library at some point, but we can revisit this
api vs implementation decision at that point.
Change-Id: Icdae394628d71131e556c6a02840c6c894f82957
M benchmark/benchmark-macro/build.gradle
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-beta01
Description
Component used: Macrobenchmark 1.3.0-alpha05
It's not possible to use the new
perfettoConfigparameter unless adding additionalbenchmark-commondependency.This is not intuitive as users don't really know where it's coming from unless digging into cs.android.com.
Is it possible to make it automatically available?
I don't know if it's reasonable to make the
benchmark-commondefined asapi? Or if it's possible to only expose thePerfettoConfigfrom that module?If none of this is feasible, can we at least update the
kDocto warng about the need to include this dependency?