Stack sampling triggers hard deadline in microbenchmark [342237318]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue on behalf of an...@google.com #1

May 22, 2024 09:10PM

androidx.compose.foundation.benchmark.lazy.LazyListScrollingBenchmark > scrollProgrammatically_newItemComposed[LazyColumn][wembley_2GB - 12] FAILED 
        java.lang.IllegalStateException: Benchmark loop overran hard time limit by 4.903629539 seconds
        at androidx.compose.testutils.benchmark.ComposeBenchmarkRule$measureRepeatedOnUiThread$$inlined$measureRepeatedOnMainThread$1.call(BenchmarkRule.kt:393)

Logcat: https://paste.googleplex.com/4815901388177408

Able to repro (though the crash itself is infrequent), added some tracing to see that it takes us 9 seconds to stop simpleperf, 5.4s of which is converting simpleperf to the stable output format that studio requires. See screenshot.

Have a fix that will defer this conversion off the main thread, which reduces ANR risk (and should avoid need for tweaking ANR avoidance hard deadline).

Wed May 22 2024 14:07:55 GMT-0700 (Pacific Daylight Time).png

31 KB

View

Download

Comments

ap...@google.com <ap...@google.com> #2Jul 8, 2024 10:02PM

Marked as fixed.

With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).

pr...@google.com <pr...@google.com> #3Aug 13, 2024 06:58PM

lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.

Issue 342237318

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jul 8, 2024 10:02PM

pr...@google.com <pr...@google.com> #3Aug 13, 2024 06:58PM

Add comment

Issue metadata