Preconditions.outOfBounds [342316801]

Fixed

Bug

Status Update

No update yet.

Description

ma...@majestyk.com

created issue #1

May 23, 2024 03:50PM

Component used: Fragment

Version used: 1.7.0

Devices/Android versions reproduced on: Android 14 only

Here's the complete stacktrace, unfortunately I don't have any other insights on how to reproduce the issue.

      Fatal Exception: java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 0
       at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
       at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
       at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
       at java.util.Objects.checkIndex(Objects.java:359)
       at java.util.ArrayList.get(ArrayList.java:434)
       at androidx.fragment.app.FragmentManager.prepareBackStackState(FragmentManager.java:2491)
       at androidx.fragment.app.FragmentManager$PrepareBackStackTransitionState.generateOps(FragmentManager.java:3739)
       at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2271)
       at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1938)
       at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:661)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at android.app.ActivityThread.main(ActivityThread.java:8893)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Comments

jo...@adidas.com <jo...@adidas.com> #2May 28, 2024 07:41AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

jb...@google.com <jb...@google.com> May 29, 2024 04:24PM

Assigned to jb...@google.com.

j....@gmail.com <j....@gmail.com> #3Jun 4, 2024 09:16AM

yea i'll take it.

sh...@gmail.com <sh...@gmail.com> #4Jun 4, 2024 09:28AM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

fl...@backmarket.com <fl...@backmarket.com> #5Jun 17, 2024 07:26AM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

jb...@google.com <jb...@google.com> #6Jul 24, 2024 06:32PM

Status: New

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

fl...@backmarket.com <fl...@backmarket.com> #7Aug 13, 2024 05:04PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

jb...@google.com <jb...@google.com> #8Aug 21, 2024 04:58PM

Marked as fixed, reassigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

pr...@google.com <pr...@google.com> #9Sep 5, 2024 08:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.8.3

ve...@google.com <ve...@google.com> #10Sep 19, 2024 04:40PM

ABC EngOps Partner-Reported Tickets Coordination: This ticket impacts an issue reported by Samsung and will be coordinated in b/368186609 - Coordination of [Samsung] Messages(com.google.android.apps.messaging,messages.android_20240813_00_RC02.phone_samsung_dynamic/243634900) / Application crashed [IssueTracker]

ve...@google.com <ve...@google.com> #11Sep 19, 2024 04:40PM

ABC EngOps Partner-Reported Tickets Coordination: This ticket impacts an issue reported by Coosea and will be coordinated in b/363209688 - Coordination of [Coosea] [Coosea][Google Messages][crash]java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 0

ve...@google.com <ve...@google.com> #12Sep 19, 2024 04:40PM

ABC EngOps Partner-Reported Tickets Coordination: This ticket impacts an issue reported by Samsung and will be coordinated in b/362392209 - Coordination of [Samsung] Messages Application crashed

ve...@google.com <ve...@google.com> #13Sep 19, 2024 04:41PM

ABC EngOps Partner-Reported Tickets Coordination: This ticket impacts an issue reported by other and will be coordinated in b/351715884 - Coordination of [INTERNAL SHADOW][Longcheer] 【Cancun_U】【PVT】【Stability】【Monkey】 com.google.android.apps.messaging in 11 crash (visible)

fl...@backmarket.com <fl...@backmarket.com> #14Sep 23, 2024 02:58PM

Updating the fragment library to 1.8.3 fixed my issue. Thanks!

sh...@gmail.com <sh...@gmail.com> #15Nov 28, 2024 03:50AM

I got this issue recently after targeting my app to ANDROID V15

Exception java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 1 at jdk.internal.util.Preconditions.outOfBounds (Preconditions.java:64) at jdk.internal.util.Preconditions.outOfBoundsCheckIndex (Preconditions.java:70) at jdk.internal.util.Preconditions.checkIndex (Preconditions.java:266) at java.util.Objects.checkIndex (Objects.java:359) at java.util.ArrayList.get (ArrayList.java:434) at androidx.navigation.compose.NavHostKt$NavHost$25$1.invokeSuspend (NavHost.kt:518) at androidx.navigation.compose.NavHostKt$NavHost$25$1.invoke (Unknown Source:8) at androidx.navigation.compose.NavHostKt$NavHost$25$1.invoke (Unknown Source:4) at androidx.activity.compose.OnBackInstance$job$1.invokeSuspend (PredictiveBackHandler.kt:160) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:108) at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch (AndroidUiDispatcher.android.kt:81) at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch (AndroidUiDispatcher.android.kt:41) at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run (AndroidUiDispatcher.android.kt:57) at android.os.Handler.handleCallback (Handler.java:942) at android.os.Handler.dispatchMessage (Handler.java:99) at android.os.Looper.loopOnce (Looper.java:201) at android.os.Looper.loop (Looper.java:288) at android.app.ActivityThread.main (ActivityThread.java:8061) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:703) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:911)

gy...@gmail.com <gy...@gmail.com> #16Dec 1, 2024 02:45AM

We started getting crashes as well but for Google Maps Flutter plugin in lite mode

      Fatal Exception: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
   at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
   at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
   at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
   at java.util.Objects.checkIndex(Objects.java:359)
   at java.util.ArrayList.get(ArrayList.java:434)
   at com.google.maps.api.android.lib6.lite.w.a(:com.google.android.gms.policy_maps_core_dynamite@244125205@244125202025.684868338.684868338:29)
   at com.google.maps.api.android.lib6.lite.y.e(:com.google.android.gms.policy_maps_core_dynamite@244125205@244125202025.684868338.684868338:41)
   at com.google.maps.api.android.lib6.lite.l.onDraw(:com.google.android.gms.policy_maps_core_dynamite@244125205@244125202025.684868338.684868338:190)
   at android.view.View.draw(View.java:23975)
   at android.view.View.buildDrawingCacheImpl(View.java:23239)
   at android.view.View.buildDrawingCache(View.java:23099)
   at android.view.View.updateDisplayListIfDirty(View.java:22819)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.View.draw(View.java:23706)
   at android.view.ViewGroup.drawChild(ViewGroup.java:4568)
   at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4329)
   at android.view.View.draw(View.java:23978)
   at io.flutter.plugin.platform.PlatformViewWrapper.draw(PlatformViewWrapper.java:44)
   at android.view.View.updateDisplayListIfDirty(View.java:22842)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4552)
   at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4525)
   at android.view.View.updateDisplayListIfDirty(View.java:22798)
   at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:694)
   at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:700)
   at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:798)
   at android.view.ViewRootImpl.draw(ViewRootImpl.java:5245)
   at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4947)
   at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4112)
   at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2690)
   at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9779)
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1343)
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1352)
   at android.view.Choreographer.doCallbacks(Choreographer.java:952)
   at android.view.Choreographer.doFrame(Choreographer.java:882)
   at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1326)
   at android.os.Handler.handleCallback(Handler.java:1000)
   at android.os.Handler.dispatchMessage(Handler.java:104)
   at android.os.Looper.loopOnce(Looper.java:242)
   at android.os.Looper.loop(Looper.java:362)
   at android.app.ActivityThread.main(ActivityThread.java:8407)
   at java.lang.reflect.Method.invoke(Method.java)
   at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:992)