Fragment 1.7.0 crashes when used with predictive back gesture and Navigation [342419080]

Fixed

Bug

Status Update

No update yet.

Description

fo...@gmail.com

created issue #1

May 24, 2024 10:41AM

Component used: Fragment, Navigation

Version used: Fragment 1.7.0, Navigation 2.7.7

Devices/Android versions reproduced on: Poco F5, Android 14

Screen recording demonstrating the issue and sample project are attached. Predictive back gesture is enabled.

Steps to reproduce: Navigate to another tab. Perform the back gesture and cancel it. Navigate to another tab.

Exception:

java.lang.IllegalArgumentException: saveBackStack("e50c3dd6-64e7-4d9f-bece-08694e6ecd62") must be self contained and not reference fragments from non-saved FragmentTransactions. Found reference to fragment HomeFragment{6ef3f53} (67314589-819b-4ead-955d-6fc8e1f8cb38 id=0x7f080132 tag=ee78b252-f193-4d4e-8e35-b6ad24766bf7) in BackStackEntry{4a78e9d #1 e50c3dd6-64e7-4d9f-bece-08694e6ecd62} that were previously added to the FragmentManager through a separate FragmentTransaction.
	at androidx.fragment.app.FragmentManager.saveBackStackState(FragmentManager.java:2389)
	at androidx.fragment.app.FragmentManager$SaveBackStackState.generateOps(FragmentManager.java:3715)
	at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2271)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1938)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:661)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:224)
	at android.os.Looper.loop(Looper.java:318)
	at android.app.ActivityThread.main(ActivityThread.java:8759)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)

Screenrecorder-2024-05-24-15-34-23-785.mp4

8.4 MB

Download

FragmentNavigation.zip

113 KB

Download

Comments

fo...@gmail.com <fo...@gmail.com> #2May 27, 2024 05:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit 016fab7f37837deb6e0924730ed70b81042c36db
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:16:26 2022

Converting `query interceptor` related files in `room-runtime` from Java to Kotlin.

Test: N/A
Bug: 206859668
Relnote: Converting `query` related files in `room-runtime` from Java to Kotlin.
Change-Id: I92b932b1a1037c68195140ffb038f8add17d8de4

M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorStatement.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorProgram.kt
M room/room-runtime/src/main/java/androidx/room/QueryInterceptorDatabase.kt

https://android-review.googlesource.com/1960726

jb...@google.com <jb...@google.com> Jul 8, 2024 03:19PM

Assigned to jb...@google.com.

th...@outlook.com <th...@outlook.com> #3Oct 4, 2024 07:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit 049d12d74b775c193e641a3fd11fb4b3c5c20dc6
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:37:31 2022

Converting `paging` related files in `room-runtime` from Java to Kotlin.

Test: LimitOffsetDataSourceTest.java
Bug: 206859668
Relnote: Converting `paging` related files in `room-runtime` from Java to Kotlin.
Change-Id: I82fc81469540315dbe4865ccde68396a4339dfd9

M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/paging/LimitOffsetDataSource.kt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/build.gradle

https://android-review.googlesource.com/1960734

pa...@gmail.com <pa...@gmail.com> #4Oct 7, 2024 07:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit 04773d8513b7ce6fbea263031c7618144c6e695d
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Jan 25 15:34:19 2022

Converting `util` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests in Java for util/. These will be migrated later as a safe migration measure.
Bug: 206859668
Relnote: Converting `util` related files in `room-runtime` from Java to Kotlin.
Change-Id: I697ee52d9234358fd83dc8d94c66d4f2b849fc1b

M room/room-runtime/src/test/java/androidx/room/util/UUIDUtilTest.kt
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-runtime/src/main/java/androidx/room/util/StringUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FileUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/FtsTableInfo.kt
M room/room-runtime/src/main/java/androidx/room/util/UUIDUtil.kt
M room/room-runtime/src/main/java/androidx/room/util/CursorUtil.kt
M room/room-runtime/src/test/java/androidx/room/util/CursorUtilTest.kt
M room/room-paging/src/main/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt
M room/room-runtime/src/main/java/androidx/room/util/TableInfo.kt
M room/room-compiler/build.gradle
M room/room-runtime/api/current.txt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/vo/StringToIntListConverters.kt
M room/room-runtime/src/main/java/androidx/room/util/ViewInfo.kt
M room/room-runtime/api/public_plus_experimental_current.txt
M room/room-runtime/api/restricted_current.ignore
M room/room-runtime/src/main/java/androidx/room/util/DBUtil.kt

https://android-review.googlesource.com/1960732

il...@google.com <il...@google.com> Oct 9, 2024 11:27PM

Reassigned to il...@google.com.

ap...@google.com <ap...@google.com> #5Oct 21, 2024 09:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9e87eb671143418ff2f2412dc43516582c1e775f
Author: Elif Bilgin <elifbilgin@google.com>
Date: Mon Feb 07 22:00:47 2022

Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin.

Test: BuilderTest.kt, InvalidationTrackerTest.kt, InvalidationLiveDataContainerTest.kt, ObservedTableTrackerTest.kt
Bug: 206859668
Relnote: Converting `invalidation tracker` related files in `room-runtime` from Java to Kotlin. This includes a source incompatible change for Kotlin users, which will require them to declare their `onInvalidate()` in their `Observer` to have a param of type `Set` and not `MutableSet`.
Change-Id: If2069426a29fffe312a58fcd3e116551090c0b4e

M room/room-paging/src/androidTest/kotlin/androidx/room/InvalidationTrackerExtRoomPaging.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/InvalidationTrackerTrojan.java
M room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M room/room-runtime/api/restricted_current.txt
M room/room-common/build.gradle
M room/room-ktx/src/androidTest/java/androidx/room/CoroutineRoomCancellationTest.kt
M room/room-runtime/api/current.txt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationService.kt
M room/benchmark/src/androidTest/java/androidx/room/benchmark/InvalidationTrackerBenchmark.kt
M room/room-ktx/src/main/java/androidx/room/CoroutinesRoom.kt
M room/room-runtime/api/public_plus_experimental_current.txt
A room/room-runtime/api/current.ignore
M room/room-runtime/api/restricted_current.ignore
M room/room-paging/src/main/java/androidx/room/paging/util/ThreadSafeInvalidationObserver.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/PagingSourceTest.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationTrackerTest.java
M room/room-runtime/src/test/java/androidx/room/BuilderTest.java
M room/room-runtime/src/main/java/androidx/room/InvalidationLiveDataContainer.kt
M room/room-runtime/src/main/java/androidx/room/MultiInstanceInvalidationClient.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/InvalidationTrackerExt.kt
M room/room-runtime/src/main/java/androidx/room/Room.kt
M room/room-runtime/src/test/java/androidx/room/InvalidationLiveDataContainerTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SyncTriggersConcurrencyTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomTrackingLiveData.kt
M sqlite/integration-tests/inspection-room-testapp/src/androidTest/java/androidx/sqlite/inspection/RoomInvalidationHookTest.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.java
M room/room-runtime/src/main/java/androidx/room/InvalidationTracker.kt
M room/room-runtime/src/test/java/androidx/room/BuilderTest_TestDatabase_Impl.java

https://android-review.googlesource.com/1976130

il...@google.com <il...@google.com> #6Oct 22, 2024 08:53PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3267211f72168a905ff880a4e34558185dc6c313
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Apr 27 14:28:44 2022

Converting `auto closer` related files in `room-runtime` from Java to Kotlin.

Test: Existing tests
Bug: 206859668
Relnote: Converting `auto closer` related files in `room-runtime` from Java to Kotlin.
Change-Id: I6ee76590c1d110a4bb46219c126ef79177e3c975

M room/room-runtime/src/androidTest/java/androidx/room/AutoClosingRoomOpenHelperFactoryTest.kt
M room/room-runtime/src/main/java/androidx/room/RoomDatabase.java
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelper.kt
M room/room-runtime/src/main/java/androidx/room/AutoClosingRoomOpenHelperFactory.kt
M room/room-runtime/src/main/java/androidx/room/AutoCloser.kt

https://android-review.googlesource.com/2043166