Fragment 1.7.0 crashes when used with predictive back gesture and Navigation [342419080]

Fixed

Bug

Status Update

No update yet.

Description

fo...@gmail.com

created issue #1

May 24, 2024 10:41AM

Component used: Fragment, Navigation

Version used: Fragment 1.7.0, Navigation 2.7.7

Devices/Android versions reproduced on: Poco F5, Android 14

Screen recording demonstrating the issue and sample project are attached. Predictive back gesture is enabled.

Steps to reproduce: Navigate to another tab. Perform the back gesture and cancel it. Navigate to another tab.

Exception:

java.lang.IllegalArgumentException: saveBackStack("e50c3dd6-64e7-4d9f-bece-08694e6ecd62") must be self contained and not reference fragments from non-saved FragmentTransactions. Found reference to fragment HomeFragment{6ef3f53} (67314589-819b-4ead-955d-6fc8e1f8cb38 id=0x7f080132 tag=ee78b252-f193-4d4e-8e35-b6ad24766bf7) in BackStackEntry{4a78e9d #1 e50c3dd6-64e7-4d9f-bece-08694e6ecd62} that were previously added to the FragmentManager through a separate FragmentTransaction.
	at androidx.fragment.app.FragmentManager.saveBackStackState(FragmentManager.java:2389)
	at androidx.fragment.app.FragmentManager$SaveBackStackState.generateOps(FragmentManager.java:3715)
	at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2271)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1938)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:661)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:224)
	at android.os.Looper.loop(Looper.java:318)
	at android.app.ActivityThread.main(ActivityThread.java:8759)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)

Screenrecorder-2024-05-24-15-34-23-785.mp4

8.4 MB

Download

FragmentNavigation.zip

113 KB

Download

Comments

fo...@gmail.com <fo...@gmail.com> #2May 27, 2024 05:28AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> Jul 8, 2024 03:19PM

Assigned to jb...@google.com.

th...@outlook.com <th...@outlook.com> #3Oct 4, 2024 07:56AM

This bug is also present in the 'Navigation drawer views activity' sample if enableOnBackInvokedCallback=true and Fragments 1.7.0 or higher, including 1.8.4, is used:

Open any tab
Perform but cancel the back gesture
Open any other tab: Crash

FATAL EXCEPTION: main
Process: REDACTED, PID: 9480
java.lang.IllegalArgumentException: saveBackStack("a40660ad-28c0-40bd-9eb0-19015e5a56b8") must be self contained and not reference fragments from non-saved FragmentTransactions. Found reference to fragment HomeFragment{299df85} (589af71e-3fc9-44b7-bdd6-51627911ab31 id=0x7f0a01ba tag=ae6e1d49-648c-4252-9901-80d65f8f7737) in BackStackEntry{266e63e #5 a40660ad-28c0-40bd-9eb0-19015e5a56b8} that were previously added to the FragmentManager through a separate FragmentTransaction.
	at androidx.fragment.app.FragmentManager.saveBackStackState(FragmentManager.java:2497)
	at androidx.fragment.app.FragmentManager$SaveBackStackState.generateOps(FragmentManager.java:3833)
	at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2379)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2046)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:703)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8705)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)

pa...@gmail.com <pa...@gmail.com> #4Oct 7, 2024 07:09AM

Hello, do we have any news on the status of this?

il...@google.com <il...@google.com> Oct 9, 2024 11:27PM

Reassigned to il...@google.com.

ap...@google.com <ap...@google.com> #5Oct 21, 2024 09:42PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Ian Lake <ilake@google.com>
Link: https://android-review.googlesource.com/3315453

Prevent double expansion of transaction operations

Expand for full commit details

Prevent double expansion of transaction operations

How predictive back with fragments works is that
we pop the FragmentTransaction from the
FragmentManager, but keep a copy of that
transaction around in case the back operation
is cancelled (either via gesture or interruption
by changes to the FragmentManager).

In the cancellation case, we then re-apply the
same FragmentTransaction again, putting the
FragmentManager back into the state it was in
before the predictive back happened.

However, when using operations that are
'expanded' like setPrimaryNavigationFragment(),
we need to explicitly call collapseOps() before
re-executing the operation so that we ensure
that these transactions never have a direct
reference to fragments from other transactions.

By ensuring we only don't double expandOps(),
we can avoid cases where FragmentManager does not
allow references to previous fragments such as when
using saveBackStack().

Relnote: "Fixed an `IllegalStateException` triggered
by `saveBackStack` only after a Predictive Back gesture
was cancelled or interrupted."
Test: new PredictiveBackTest test cases
BUG: 342419080

Change-Id: I3387d9d02495112f211448d7f3c9f862299da697

Files:

M fragment/fragment/src/androidTest/java/androidx/fragment/app/PredictiveBackTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

Hash: 922bb8acc3661be78480dd40f3c582af8b87f935
Date: Mon Oct 21 20:45:54 2024

il...@google.com <il...@google.com> #6Oct 22, 2024 08:53PM

Marked as fixed.

We've fixed this internally and will be available in Fragment 1.8.5.