IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support
Branch: androidx-main

commit 72855447f862883abeda1dd4332aad6054cb559b
Author: Clara Fok <clarafok@google.com>
Date:   Fri May 24 10:41:39 2024

    Refactor RouteDecoderTest
   
    The arg values are stored into the bundle by calling NavType.put (instead of just calling bundle.putX like before) for more accurate testing of real behavior.
   
    Test: ./gradlew navigation:navigation-common:cC
    Bug: 342672856
    Change-Id: If9ef21695120e23bd916c9f311a645d55d842126

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt

https://android-review.googlesource.com/3105057

Project: platform/frameworks/support
Branch: androidx-main

commit 77a625a661b40032bd74a573e54fb78c3dcc15fb
Author: Clara Fok <clarafok@google.com>
Date:   Fri May 24 16:43:08 2024

    Handle null values for built in CollectionNavType
   
    Previously, null string lists (i.e. NavType.StringListType) are treated as a listOf("null") when it should just be null. On the other hand, other primitiv
    e lists (i.e. NavType.IntListType) are treated as if there is a lack of value and the null value is not added to argument bundle.
   
    Now, both lists with null values are added to the bundle as bundleOf("argName", null). This means NavBackStackEntry.toRoute() will also be able to decode
    the deeplink back into a Route with a null arg value.
   
    However this comes with a matchDeepLink behavior change. In the past, a non-String List-type query arg of value "{argName}" is treated the same as null, whereby both are treated as if lack of value, and neither arg values are added to the bundle. So both these routes are essentially interchangable:
   
    "www.test.com?argName={argName}"
    "www.test.com?argName=null"
   
    But now with null considered as a legitimate value and added to the bundle, they are no longer interchangable.
   
    Test: ./gradlew navigation:navigation-runtime:cC
    Test: ./graldew navigation:navigation-common:cC
    Bug: 342672856
    Relnote: "Navigation can now handle navigating with a null value for the built-in nullable CollectionNavTypes"
   
    Change-Id: I59d308e76045f8734da4e2fc2913148b1910f194

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavTypeTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/test/NavArgument.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
M       navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3105059

Project: platform/frameworks/support
Branch: androidx-main

commit d08f0cccdceb9229e7856c6b36240a70e2430380
Author: Clara Fok <clarafok@google.com>
Date:   Wed Jun 05 18:59:29 2024

    Forward fix null lists
   
    We merged aosp/3105059 to fix null lists by adding null values to the bundles.
   
    In this forward fix, we handle null the same as a missing value for lists whereby we will default to the defaultValue if present, otherwise we default to an emptyList().
   
    Test: ./gradlew navigation:navigation-runtime:cC
    Test: ./graldew navigation:navigation-common:cC
    Bug: 342672856
    Relnote: "Navigation handles null value for built-in CollectionNavTypes by by defaulting to the NavType’s defaultValue, or an emptyList() if there is no defaultValue."
    Change-Id: I84158320503bc04052de8f80022f83d86e23cc15

M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/NavTypeTest.kt
M       navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteBuilder.kt
M       navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteEncoder.kt
M       navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3114126