Navigation with null lists leads to indeterminate behavior [342672856]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

May 24, 2024 09:31PM

Null lists of built-in CollectionNavType such as StringListType, IntListType leads to different behavior depending on whether its string route or safe args, but either behavior seems wrong.

Take NavType.StringListType as example.

For string routes

val route = "test.com?list=null"
bundle[list] returns listOf("null")

For safe args

val route = MyRoute(null)
bundle is empty

Comments

ap...@google.com <ap...@google.com> #2May 28, 2024 02:33PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3May 28, 2024 02:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4May 31, 2024 05:50PM

deleted

cl...@google.com <cl...@google.com> #5Jun 4, 2024 12:19AM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Jun 6, 2024 06:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit d08f0cccdceb9229e7856c6b36240a70e2430380
Author: Clara Fok <clarafok@google.com>
Date: Wed Jun 05 18:59:29 2024

Forward fix null lists

We merged aosp/3105059 to fix null lists by adding null values to the bundles.

In this forward fix, we handle null the same as a missing value for lists whereby we will default to the defaultValue if present, otherwise we default to an emptyList().

Test: ./gradlew navigation:navigation-runtime:cC
Test: ./graldew navigation:navigation-common:cC
Bug: 342672856
Relnote: "Navigation handles null value for built-in CollectionNavTypes by by defaulting to the NavType’s defaultValue, or an emptyList() if there is no defaultValue."
Change-Id: I84158320503bc04052de8f80022f83d86e23cc15

M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavTypeTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteBuilder.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteEncoder.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3114126

pr...@google.com <pr...@google.com> #7Jun 12, 2024 10:45PM