IndexOutOfBoundsException Inconsistency detected. Invalid view holder adapter when updating paging to 3.3.0 [343124454]

Fixed

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

May 28, 2024 10:28AM

I have tried to upgrade tom 3.2.1 to 3.3.0 and published my app, however I've gotten quite some crashes:

Fatal Exception: java.lang.IndexOutOfBoundsException
Inconsistency detected. Invalid view holder adapter positionm0{3d863cd position=6 id=-1, oldPos=-1, pLpos:-1 no parent} com.vanniktech.ui.RecyclerView{606c180 VFED.V... .F...... 0,0-1080,1731 #7f0a02d1 app:id/recyclerView}, adapter:ig.a0@12f77dd, layout:androidx.recyclerview.widget.LinearLayoutManager@14859d9, context:com.vanniktech.rssreader.RssReaderMainActivity@fb2312

Reverting the paging upgrade from 3.3.0 to 3.2.1 fixed all the problems for me and I no longer get this exception. This didn't happen for a lot of users but still it's something noticable.

I haven't changed anything regarding my implementation. What do you need from me?

Screenshot 2024-05-28 at 18.27.32.png

146 KB

View

Download

Comments

ni...@gmail.com <ni...@gmail.com> #2Jun 4, 2024 10:47AM

I am also seeing this issue suddenly after updating from 3.2.1 to 3.3.0.

Screenshot 2024-06-04 at 12.46.29.png

74 KB

View

Download

Screenshot 2024-06-04 at 12.46.34.png

68 KB

View

Download

cl...@google.com <cl...@google.com> #3Jun 7, 2024 05:35PM

Would you be able to provide a sample repro where I have access to the source code?

cl...@google.com <cl...@google.com> #4Jun 11, 2024 04:14PM

re comment#2 do you have a sample app to reproduce the error?

he...@gmail.com <he...@gmail.com> #5Jun 12, 2024 07:33PM

I'm unable to reproduce this issue myself, but we also have a sudden spike of these crashes after upgrading to v3.3.0.

nb...@indeed.com <nb...@indeed.com> #6Jun 13, 2024 11:33AM

Upgrading caused the same crashes for us. Reverting to 3.2.1 for now.

ni...@gmail.com <ni...@gmail.com> #7Jun 13, 2024 11:36AM

comment#4

I was unable to reproduce the error on my various devices; I have only seen it reported in Crashlytics.

al...@gmail.com <al...@gmail.com> #8Jun 13, 2024 04:10PM

I reproduced this crash by invalidating the data source while scrolling the list — it crashes soon after calling PagedListAdapter.submitData.

Other than this one, 3.3.0 also caused a very similar raw IndexOutOfBoundsException Index: 61, Size: 25, without the "inconsistency detected" message. I assume they are related.

ba...@gmail.com <ba...@gmail.com> #9Jun 18, 2024 06:49AM

The crash happens when you try to refresh the data. A crash happens after updating the dependency.

ba...@gmail.com <ba...@gmail.com> #10Jun 18, 2024 06:51AM

Our team did some investigation and figured out that crash happens only when using the custom paging source and refresh the data to update the changes

cl...@google.com <cl...@google.com> #11Jun 19, 2024 09:22PM

Is RemoteMediator used in the apps? I'll try to write my own sample app to repro this and need more info.

ni...@gmail.com <ni...@gmail.com> #12Jun 23, 2024 12:09PM

Hi, I have posted POC that reproduces the crash without RemoteMediator to to https://issuetracker.google.com/issues/347649763

ni...@gmail.com <ni...@gmail.com> #13Jun 23, 2024 12:09PM

Attaching here too

poc.zip

1.4 MB

Download

ma...@zentity.com <ma...@zentity.com> #14Jun 26, 2024 09:33AM

We use paging 3 for data source. Our app crash on the same after updating from 3.2.1 to 3.3.0.

Also we see another crash in crashlytics, probably caused by same issue:

Fatal Exception: java.lang.IllegalStateException: Detected inconsistent adapter updates. The local position of the view holder maps to 2 which is out of bounds for the adapter with size 2.Make sure to immediately call notify methods in your adapter when you change the backing dataviewHolder:l{1b0f866 position=3 id=-1, oldPos=-1, pLpos:-1}adapter:Cd.m@e72f7ad
       at androidx.recyclerview.widget.ConcatAdapterController.getLocalAdapterPosition(ConcatAdapterController.java:481)
       at androidx.recyclerview.widget.ConcatAdapter.findRelativeAdapterPositionIn(ConcatAdapter.java:303)
       at androidx.recyclerview.widget.RecyclerView$ViewHolder.getBindingAdapterPosition(RecyclerView.java:12043)
       at redacted.decorator.ViewTypeDividerItemDecorator.drawDividerAfter(ViewTypeDividerItemDecorator.kt:31)
       at redacted.decorator.DividerItemDecoration.drawVertical(DividerItemDecoration.kt:146)
       at redacted.decorator.DividerItemDecoration.onDraw(DividerItemDecoration.kt:116)
       at androidx.recyclerview.widget.RecyclerView.onDraw(RecyclerView.java:5009)
       at android.view.View.draw(View.java:24406)
       at androidx.recyclerview.widget.RecyclerView.draw(RecyclerView.java:4944)
       at android.view.View.updateDisplayListIfDirty(View.java:23267)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.View.draw(View.java:24136)
       at android.view.ViewGroup.drawChild(ViewGroup.java:4748)
       at androidx.fragment.app.FragmentContainerView.drawChild(FragmentContainerView.kt:232)
       at android.view.ViewGroup.dispatchDraw(ViewGroup.java:4505)
       at androidx.fragment.app.FragmentContainerView.dispatchDraw(FragmentContainerView.kt:222)
       at android.view.View.updateDisplayListIfDirty(View.java:23253)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4732)
       at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4704)
       at android.view.View.updateDisplayListIfDirty(View.java:23214)
       at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:777)
       at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:783)
       at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:881)
       at android.view.ViewRootImpl.draw(ViewRootImpl.java:5647)
       at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:5330)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4486)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:3116)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10885)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1301)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)
       at android.view.Choreographer.doCallbacks(Choreographer.java:923)
       at android.view.Choreographer.doFrame(Choreographer.java:852)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8762)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)

Message last modified on Jun 26, 2024 09:38AM

cl...@google.com <cl...@google.com> #15Jun 26, 2024 10:57PM

re comment#14 can you please file a separate bug and attach a sample app that reproduces the error?

cl...@google.com <cl...@google.com> #16Jun 26, 2024 11:02PM

Accepted by cl...@google.com.

Thanks comment#12 for the repro!

Bug happens due to PagingDataPresenter updating its internal PageStore to the new refreshed list prior to RV calculating diff.

When RV callback is triggered after calculating diff, it calls PagingDataAdapter.itemCount and expects to get the previous list size (prior to refresh). However, PagingDataAdapter.itemCount essentially delegates to PagingDataPresenter.size which has already been updated to the new PageStore size at this point, and so the holder pos > adapter.itemCount() condition is triggered, leading to the exception.

ni...@gmail.com <ni...@gmail.com> #17Jun 27, 2024 08:23AM

Thanks very much. I suppose there is no quick workaround, what sort of timeline we would expect for the bug fix release?

cl...@google.com <cl...@google.com> #18Jul 12, 2024 07:07PM

Marked as fixed.

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/3165661/4.

Will be available in paging 3.3.1 to be released on July 24th.

Message last modified on Jul 12, 2024 07:07PM

da...@gmail.com <da...@gmail.com> #19Jul 25, 2024 02:50PM

Comment has been deleted.

Message last modified on Jul 25, 2024 02:56PM

h9...@drdiary.co.kr <h9...@drdiary.co.kr> #20Aug 1, 2024 06:00AM

Is it normal for this error to occur even after updating the library to version 3.3.1? I’m asking because this error never occurred with version 3.2.1.

java.lang.IllegalStateException: Detected inconsistent adapter updates. The local position of the view holder maps to 9 which is out of bounds for the adapter with size 9.Make sure to immediately call notify methods in your adapter when you change the backing dataviewHolder

cl...@google.com <cl...@google.com> #21Aug 1, 2024 05:04PM

re comment#20 can you please file a separate bug and attach a sample project?

Issue 343124454

Description

Issue summary

Comments

ni...@gmail.com <ni...@gmail.com> #2Jun 4, 2024 10:47AM

cl...@google.com <cl...@google.com> #3Jun 7, 2024 05:35PM

cl...@google.com <cl...@google.com> #4Jun 11, 2024 04:14PM

he...@gmail.com <he...@gmail.com> #5Jun 12, 2024 07:33PM

nb...@indeed.com <nb...@indeed.com> #6Jun 13, 2024 11:33AM

ni...@gmail.com <ni...@gmail.com> #7Jun 13, 2024 11:36AM

al...@gmail.com <al...@gmail.com> #8Jun 13, 2024 04:10PM

ba...@gmail.com <ba...@gmail.com> #9Jun 18, 2024 06:49AM

ba...@gmail.com <ba...@gmail.com> #10Jun 18, 2024 06:51AM

cl...@google.com <cl...@google.com> #11Jun 19, 2024 09:22PM

ni...@gmail.com <ni...@gmail.com> #12Jun 23, 2024 12:09PM

ni...@gmail.com <ni...@gmail.com> #13Jun 23, 2024 12:09PM

ma...@zentity.com <ma...@zentity.com> #14Jun 26, 2024 09:33AM

cl...@google.com <cl...@google.com> #15Jun 26, 2024 10:57PM

cl...@google.com <cl...@google.com> #16Jun 26, 2024 11:02PM

ni...@gmail.com <ni...@gmail.com> #17Jun 27, 2024 08:23AM

cl...@google.com <cl...@google.com> #18Jul 12, 2024 07:07PM

da...@gmail.com <da...@gmail.com> #19Jul 25, 2024 02:50PM

h9...@drdiary.co.kr <h9...@drdiary.co.kr> #20Aug 1, 2024 06:00AM

cl...@google.com <cl...@google.com> #21Aug 1, 2024 05:04PM

Add comment

Issue metadata