Status Update
Comments
ap...@google.com <ap...@google.com> #2
Should we transform it from
fun <FileTypeT: FileSystemLocation> add(
type: MultipleArtifact<FileTypeT>,
artifact: FileTypeT
)
to
fun <FileTypeT: FileSystemLocation, Appendable> add(
type: MultipleArtifact<FileTypeT>,
artifactProvider: Provider<FileTypeT>
)
should we also share with Artifacts interface: ArtifactsImpl.appendTo ArtifactsImpl.appendAll. They are not in use right now. Maybe part of another ticket?
ap...@google.com <ap...@google.com> #3
I don't think we can just move it to use a Provider<> as the original bug called for adding a file.
plus this add() would become just like to OperationRequest::toAppendTo no ?
ap...@google.com <ap...@google.com> #4
So we somehow need to disallow calling this method if FileSystemLocation is produced by task?
Can we add some validation on build phase - meaning we can call those only during config but not when tasks execute?
plus this add() would become just like to OperationRequest::toAppendTo no ?
it looks like it
ap...@google.com <ap...@google.com> #5
Initial ticket that introduced Artifacts.add is
ap...@google.com <ap...@google.com> #6
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Jellyfish | 2023.3.1 Canary 7
- Android Gradle Plugin 8.4.0-alpha07
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@google.com <ap...@google.com> #7
Branch: 8.5
commit f4e9edf2de8d03a9c6fe2ccd89c49240b1c94374
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 10:52:26 2024
Version 8.5.17
Bug:
Change-Id: Idde4ae7c88f2ac9b23e9c04c35d728d74e3ce665
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #8
Branch: 8.5
commit eeb3e5b7fbd51e061bf0cc5651f7b36db15962aa
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 10:51:21 2024
Add Android 15 support and test
* Android SDK files for android-VanillaIceCream SDK revision 3
* Update API database base on android-VanillaIceCream SDK revision 3
* Add fresh build of host Art 15 from branch 24Q3-release
Bug:
Change-Id: I74d4f9fe5455243d560bf904d4ddfc4a0f32b5b3
M .gitignore
M d8_r8/commonBuildSrc/src/main/kotlin/DependenciesPlugin.kt
M scripts/add-android-jar.sh
M scripts/update-host-art.sh
M src/main/java/com/android/tools/r8/androidapi/CovariantReturnTypeMethods.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
M src/main/java/com/android/tools/r8/utils/DexVersion.java
M src/test/java/com/android/tools/r8/R8RunSmaliTestsTest.java
M src/test/java/com/android/tools/r8/androidapi/GenerateCovariantReturnTypeMethodsTest.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiHashingDatabaseBuilderGeneratorTest.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java
M src/test/java/com/android/tools/r8/cf/methodhandles/invokespecial/InvokeSpecialMethodHandleTest.java
M src/test/java/com/android/tools/r8/debuginfo/LocalVariableTableForParameterWithSignatureTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexRewriteInvokeInterfaceTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexRewriteInvokeSpecialTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexRewriteInvokeSuperTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexRewriteInvokeVirtualTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexShrinkingFieldsTest.java
M src/test/java/com/android/tools/r8/desugar/nestaccesscontrol/NestAttributesInDexShrinkingMethodsTest.java
M src/test/java/com/android/tools/r8/examples/floating_point_annotations/FloatingPointValuedAnnotationTestRunner.java
M src/test/java/com/android/tools/r8/graph/InvokeSuperTest.java
M src/test/java/com/android/tools/r8/shaking/InvalidTypesTest.java
M src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
M src/test/testbase/java/com/android/tools/r8/R8RunArtTestsTest.java
M src/test/testbase/java/com/android/tools/r8/TestCondition.java
M src/test/testbase/java/com/android/tools/r8/ToolHelper.java
A third_party/android_jar/lib-v35.tar.gz.sha1
M third_party/android_jar/libcore_latest.tar.gz.sha1
M third_party/api_database/api_database.tar.gz.sha1
M tools/linux/README.art-versions
A tools/linux/host/art-15.0.0-beta2.tar.gz.sha1
M tools/test.py
ap...@google.com <ap...@google.com> #9
Branch: 8.5
commit b8af527cec489eb1c171a254fdcc6e5dcf55cff7
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 10:51:37 2024
Update expectations for covariant return types methods count
Android 15 SDK added more methods with annotations @CovariantReturnType
and @CovariantReturnTypes.
Bug:
Change-Id: I23f9c372cbe8eea097ce6119236c4e04da57d6e6
M src/test/java/com/android/tools/r8/androidapi/GenerateCovariantReturnTypeMethodsTest.java
ap...@google.com <ap...@google.com> #10
Branch: 8.5
commit 256a8a198d3e2ea7edeacb4e51cb93b4b88f04aa
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 10:51:50 2024
Update update backports for Android 14 and Android 15
* int CharSequence.compare(CharSequence, CharSequence) was added in
Android 14
* Character.toString(int) was added in Android 15
Also update the global synthetics count for Android 15
Bug:
Change-Id: I5d657e5e0a73286b5a3d0eec3f796103d8f8024a
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
M src/test/java/com/android/tools/r8/desugar/backports/TestBackportedNotPresentInAndroidJar.java
M src/test/java/com/android/tools/r8/globalsynthetics/GlobalSyntheticsEnsureClassesOutputTest.java
ap...@google.com <ap...@google.com> #11
Branch: 8.5
commit 1096a36e1bc87c24af27eab5db96ab5bfdbb1354
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 10:52:04 2024
Fix error prone (unused argument)
Bug:
Change-Id: I64f9737f39d8c72e60c170a408fcdfa49e478f8e
M src/main/java/com/android/tools/r8/ir/desugar/BackportedMethodRewriter.java
ap...@google.com <ap...@google.com> #12
Branch: main
commit 7943224298f598f8b093c96f3de4a6b4b145424c
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri May 31 11:18:19 2024
Add Art 15 bot
Bug:
Change-Id: I5839a327acd9033dd50af71cd4a8da2f7b26a314
M infra/config/global/generated/cr-buildbucket.cfg
M infra/config/global/generated/luci-milo.cfg
M infra/config/global/generated/luci-notify.cfg
M infra/config/global/generated/luci-scheduler.cfg
M infra/config/global/generated/project.cfg
M infra/config/global/main.star
ap...@google.com <ap...@google.com> #13
Branch: main
commit bfd6dccb5d56a597ac0aa4bd518fb604f0a27599
Author: Søren Gjesse <sgjesse@google.com>
Date: Mon Jun 03 16:37:19 2024
Update status for tests on Art 15
Bug:
Change-Id: Iadc143f6c63cab993de1c5d40fde8e2265dfe238
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/R8RunExamplesAndroidOTest.java
M src/test/java/com/android/tools/r8/RunExamplesAndroidOTest.java
M src/test/java/com/android/tools/r8/desugaring/interfacemethods/InterfaceMethodDesugaringTests.java
ap...@google.com <ap...@google.com> #14
Branch: 8.5
commit 0b170de9c0446c40533ea25917f4f7c92093d20c
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Jun 13 12:33:56 2024
Version 8.5.22
Bug:
Change-Id: I292bad97af8a667a81ff5027a205eaed010672fc
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #15
Branch: 8.5
commit bb0e300853bafc78c2a0ca6a411555827a677155
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Jun 13 12:33:14 2024
Update status for tests on Art 15
Bug:
Change-Id: Iadc143f6c63cab993de1c5d40fde8e2265dfe238
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/R8RunExamplesAndroidOTest.java
M src/test/java/com/android/tools/r8/RunExamplesAndroidOTest.java
M src/test/java/com/android/tools/r8/desugaring/interfacemethods/InterfaceMethodDesugaringTests.java
ap...@google.com <ap...@google.com> #16
Branch: main
commit 37a51bc9a32253a4ad0906d072e851700893a43b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Jun 18 16:29:55 2024
Update API database base on android-VanillaIceCream SDK revision 4
Bug:
Change-Id: I506e4dd85b2ba5b63791611057cc4d945ade9307
M third_party/android_jar/lib-v35.tar.gz.sha1
M third_party/api_database/api_database.tar.gz.sha1
ap...@google.com <ap...@google.com> #17
Branch: main
commit 6fdc87c055dab69fdca58f6766c1884e63f37294
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Jun 19 12:43:22 2024
Reapply "Update API database base on android-VanillaIceCream SDK revision 4"
This reverts commit b9252047f712e7d6bd0ac4a0a0acabc19dc764b3.
Bug:
Change-Id: I48bf3133447728b7ef70514105f8e25fbb6510a3
M src/main/java/com/android/tools/r8/androidapi/AndroidApiLevelDatabaseHelper.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiHashingDatabaseBuilderGeneratorTest.java
M src/test/java/com/android/tools/r8/globalsynthetics/GlobalSyntheticsEnsureClassesOutputTest.java
M third_party/android_jar/lib-v35.tar.gz.sha1
M third_party/api_database/api_database.tar.gz.sha1
ap...@google.com <ap...@google.com> #18
Branch: main
commit 7a3664973f1008dc3c01d6f6ddd083fa869a24af
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Jun 26 09:38:58 2024
Update API database based on android-35 SDK revision 1
Fixes:
Change-Id: I3f27dc0a9fdf36ed22f383e77ec9b22ceb7b6930
M scripts/add-android-jar.sh
M src/main/java/com/android/tools/r8/androidapi/AndroidApiLevelDatabaseHelper.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiHashingDatabaseBuilderGenerator.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiHashingDatabaseBuilderGeneratorTest.java
M src/test/java/com/android/tools/r8/apimodel/AndroidApiVersionsXmlParser.java
M third_party/android_jar/lib-v35.tar.gz.sha1
M third_party/api_database/api_database.tar.gz.sha1
an...@google.com <an...@google.com> #19
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Koala Feature Drop | 2024.1.2 Beta 2
- Android Gradle Plugin 8.6.0-beta02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@gmail.com <ap...@gmail.com> #20
Android 15 install it
Description
Currently shipping Android 15 beta 2 and
android-VanillaIceCream
SDK revision 3.