Status Update
Comments
sg...@google.com <sg...@google.com> #2
Yigit, I haven't had time to try reproducing yet, but they have a github link which is nice. What's weird though is I don't think anything has changed recently at all, but maybe you're aware? Although, looking at the callstack, it may be an AGP issue? If it looks like that to you too, bounce it back to me.
OP: Was this a regression? And just to make sure, when you say "run ./gradlew help
", you're seeing this from the command line? Or from within Studio?
sg...@google.com <sg...@google.com> #3
I'm seeing this from command line.
Yes this seems to be a regression starting from 7.0.0-alpha10.
Note that the project I linked doesn't use databinding at all, enabling the build config flag is all that's needed to reproduce this.
ge...@paymentsense.com <ge...@paymentsense.com> #4
Thanks for the quick reply. I have a short open window right now so I'll try to repro and see if I can figure out which component this is best for.
sg...@google.com <sg...@google.com> #5
I can repro what OP is seeing. It may be tempting to move this to the data binding component but this seems more like an AGP change. I don't believe the data binding compiler has been changed recently, around the time AGP 7.0.0-alpha10 went out.
ge...@paymentsense.com <ge...@paymentsense.com> #6
Also, slightly more direct steps (although it amounts to the same thing as what's in
- Sync the github project somewhere (
git clone https://github.com/ReactiveCircus/streamlined.git
) - Double check everything's working as expected (
./gradlew help
should work) - Edit
app/build.gradle.kts
: Search forbuildFeatures
and adddataBinding = true
as the first entry, abovebuildConfig
- Now, things are expected to break (
./gradlew help
should throw an exception) - Edit
buildSrc/src/main/kotlin/io/github/reactivecircus/streamlined/Dependencies.kt
: change the AGP version to7.0.0-alpha09
- Now, things are expected to work again(
./gradle help
should work)
sg...@google.com <sg...@google.com> #7
yea this seems unrelated to data binding as we didn't change data binding itself
There were some resource related changes so cc'ing Iza in case they might be related but i don't think so. This seems like a lifecycle issue.
ge...@paymentsense.com <ge...@paymentsense.com> #8
I'll look more into this, thanks for the detailed description and repro case!
sg...@google.com <sg...@google.com> #9
This affects even 1.50-M1 kotlin, and the code resolving the attributes is here:
As a workaround to get data binding working, I'll add a new task that merges dependencies R.txt files into one, and then pass that single file to kapt/db. So while the incorrect resolving will still be there while jetbrains fixes this issue, it will allow the non-transitive R + data binding builds to succeed.
ge...@paymentsense.com <ge...@paymentsense.com> #10
nice find!
There is actually another issue about incremental compilation, do you think they might be related to the other issue you've mentioned?
sg...@google.com <sg...@google.com> #11
ge...@paymentsense.com <ge...@paymentsense.com> #12
ge...@paymentsense.com <ge...@paymentsense.com> #13
This affects even 1.50-M1 kotlin, and the code resolving the attributes is here:
https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/kapt/Kapt3KotlinGradleSubplugin.kt#L354
This is similar to/the same as
Regarding
sg...@google.com <sg...@google.com> #14
ge...@paymentsense.com <ge...@paymentsense.com> #15
Thanks! Do we know if this is going to be included in the next canary (or one after that)? It's been blocking us from updating AGP / Studio for 4 releases now so I'd really love to get back to the bleeding edge soon:)
ap...@google.com <ap...@google.com> #16
an...@paymentsense.com <an...@paymentsense.com> #17
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Chipmunk Canary 2 (2021.2.1.2)
- Android Gradle Plugin 7.2.0-alpha02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #18
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Bumblebee Beta 2 (2021.1.1.15)
- Android Gradle Plugin 7.1.0-beta02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
cl...@google.com <cl...@google.com> #19
The fixes for this issue are now also available in:
- Android Studio Koala Feature Drop | 2024.1.2 Canary 1
- Android Gradle Plugin 8.6.0-alpha01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
ap...@google.com <ap...@google.com> #20
Branch: 8.6
commit 041afb7d25f7d2bb53d88066bcd212b3a4ebcabf
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:03:42 2024
Fix SplitBranch with invalid phi
-Regress Tivi size by 0.007%
Bug:
Change-Id: Ie42724bf73b57ebbaa5145a054cce9e6bae06f56
M src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
M src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
ap...@google.com <ap...@google.com> #21
Branch: 8.6
commit 3ec73ce1dbb45b2b43148cb32753ef1e9fada74d
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:07:49 2024
Version 8.6.16
Bug:
Bug:
Bug:
Bug:
Change-Id: I9f2ad5022503a910fad4e649cf5df8dbbb616316
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #22
Branch: 8.5
commit d360da0f12e43c2e9798aaa1bdf3443cb7661e51
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:26:24 2024
Version 8.5.34
Bug:
Bug:
Bug:
Bug:
Change-Id: Ife8945c8f8ed416af360c78e5fc4267bba97b967
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #23
Branch: 8.5
commit 53afe8ea0c3600e3c5a6e50232759f65db70f3ce
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:23:19 2024
Fix SplitBranch with invalid phi
-Regress Tivi size by 0.007%
Bug:
Change-Id: Ie42724bf73b57ebbaa5145a054cce9e6bae06f56
M src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
M src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
ap...@google.com <ap...@google.com> #24
Branch: 8.5
commit eba4c3e1e92b583c5f352ed87d2e660c0b15dbbf
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:22:42 2024
Add reproduction of
Change-Id: I110623e94cfb747b1d3b014fa7f20be9c8003bf7
Bug:
A src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
cl...@google.com <cl...@google.com>
an...@google.com <an...@google.com> #25
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Koala Feature Drop | 2024.1.2 RC 1
- Android Gradle Plugin 8.6.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
an...@google.com <an...@google.com> #26
The fixes for this issue are now also available in:
- Android Studio Koala | 2024.1.1 Patch 2
- Android Gradle Plugin 8.5.2
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
cu...@gmail.com <cu...@gmail.com> #27
Hello, i encounter with similar issue in AGP 8.7.3 and R8 8.7.18:
goto :goto_5b
:cond_59
move-object/from16 v15, p24
:goto_5b
const/high16 v16, 0x4000000
and-int v0, v0, v16
if-eqz v0, :cond_64
const/16 v8, 0x0
goto :goto_67
:cond_64
move-object/16 v264, p25
...
move-object/from16 v2, v264
java.lang.VerifyError: Verifier rejected class:[0x430] copy1 v2<-v264 type=Undefined cat=3
ch...@google.com <ch...@google.com> #28
Re:
In order to diagnose this issue, we would likely need a reproduction. If it would be possible for you to share a compiler dump, which contains the inputs to the D8 compilation, that should allow us to reproduce the issue. You can share this privately with
You can generate such a dump by running ./gradlew assembleRelease --no-daemon -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/dumps
.
Description
Hello,
The issue continues to happen for us even with AGP 8.4.1. I am attaching the smali output here.
java.lang.VerifyError: Verifier rejected class com.pax.log.LogUtils: java.lang.StackTraceElement com.pax.log.LogUtils.getCaller(com.pax.log.b, java.lang.StackTraceElement[], int) failed to verify: java.lang.StackTraceElement com.pax.log.LogUtils.getCaller(com.pax.log.b, java.lang.StackTraceElement[], int): [0x21] type Undefined unexpected as arg to if-eqz/if-nez (declaration of 'com.pax.log.LogUtils' appears in /data/app/******-1/base.apk:classes8.dex)
at com.pax.log.LogUtils.isAndroid(LogUtils.java:125)
at com.pax.log.PaxLogWrapper.<init>(PaxLogWrapper.java:63)
at com.pax.log.PaxLogWrapper.<init>(PaxLogWrapper.java:52)
at com.pax.log.LogWrapperBinding.<clinit>(LogWrapperBinding.java:1)
at com.pax.log.LogWrapperBinding.registerLog(LogWrapperBinding.java:1)
at com.pax.poscomm.utils.CommLog.<clinit>(CommLog.java:1)
at com.pax.poscomm.utils.CommLog.v(CommLog.java:1)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getDalObjFromNeptuneLite(NeptuneBase.java:5)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getDalObjectFromNeptuneLib(NeptuneBase.java:6)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getClassLoader(NeptuneBase.java:2)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.loadDex(NeptuneBase.java:4)
at com.pax.poslink.POSLinkAndroid.a(POSLinkAndroid.java:2)
at com.pax.poslink.POSLinkAndroid.init(POSLinkAndroid.java:21)