Status Update
Comments
sg...@google.com <sg...@google.com> #2
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
sg...@google.com <sg...@google.com> #3
ge...@paymentsense.com <ge...@paymentsense.com> #4
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
sg...@google.com <sg...@google.com> #5
ge...@paymentsense.com <ge...@paymentsense.com> #6
sg...@google.com <sg...@google.com> #7
ge...@paymentsense.com <ge...@paymentsense.com> #8
sg...@google.com <sg...@google.com> #9
ge...@paymentsense.com <ge...@paymentsense.com> #10
```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1
(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```
sg...@google.com <sg...@google.com> #11
ge...@paymentsense.com <ge...@paymentsense.com> #12
ge...@paymentsense.com <ge...@paymentsense.com> #13
sg...@google.com <sg...@google.com> #14
ge...@paymentsense.com <ge...@paymentsense.com> #15
ap...@google.com <ap...@google.com> #16
Has anyone re-tried it?
We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt
in our Dockerfile back in March of 2021.
an...@paymentsense.com <an...@paymentsense.com> #17
For what it's worth, I did a quick test with the latest CLI: 11076708 (
./sdkmanager --sdk_root="../sdk" --package_file=deps.txt
Deps.txt:
platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3
So perhaps this is now resolved? I haven't tried it with more packages
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #18
Branch: main
commit c0f3646d88824dd0b1a376858d435b417c147f3f
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 10:57:37 2024
Fix SplitBranch with invalid phi
-Regress Tivi size by 0.007%
Bug:
Change-Id: Ie42724bf73b57ebbaa5145a054cce9e6bae06f56
M src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
M src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
cl...@google.com <cl...@google.com> #19
Fixed, I need now to backport a bit.
ap...@google.com <ap...@google.com> #20
Branch: 8.6
commit 041afb7d25f7d2bb53d88066bcd212b3a4ebcabf
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:03:42 2024
Fix SplitBranch with invalid phi
-Regress Tivi size by 0.007%
Bug:
Change-Id: Ie42724bf73b57ebbaa5145a054cce9e6bae06f56
M src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
M src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
ap...@google.com <ap...@google.com> #21
Branch: 8.6
commit 3ec73ce1dbb45b2b43148cb32753ef1e9fada74d
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:07:49 2024
Version 8.6.16
Bug:
Bug:
Bug:
Bug:
Change-Id: I9f2ad5022503a910fad4e649cf5df8dbbb616316
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #22
Branch: 8.5
commit d360da0f12e43c2e9798aaa1bdf3443cb7661e51
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:26:24 2024
Version 8.5.34
Bug:
Bug:
Bug:
Bug:
Change-Id: Ife8945c8f8ed416af360c78e5fc4267bba97b967
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #23
Branch: 8.5
commit 53afe8ea0c3600e3c5a6e50232759f65db70f3ce
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:23:19 2024
Fix SplitBranch with invalid phi
-Regress Tivi size by 0.007%
Bug:
Change-Id: Ie42724bf73b57ebbaa5145a054cce9e6bae06f56
M src/main/java/com/android/tools/r8/ir/conversion/passes/SplitBranch.java
M src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
ap...@google.com <ap...@google.com> #24
Branch: 8.5
commit eba4c3e1e92b583c5f352ed87d2e660c0b15dbbf
Author: Clément Béra <clementbera@google.com>
Date: Tue Jul 30 13:22:42 2024
Add reproduction of
Change-Id: I110623e94cfb747b1d3b014fa7f20be9c8003bf7
Bug:
A src/test/java/com/android/tools/r8/ir/optimize/ifs/Regress343136777Test.java
cl...@google.com <cl...@google.com>
an...@google.com <an...@google.com> #25
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Koala Feature Drop | 2024.1.2 RC 1
- Android Gradle Plugin 8.6.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
an...@google.com <an...@google.com> #26
The fixes for this issue are now also available in:
- Android Studio Koala | 2024.1.1 Patch 2
- Android Gradle Plugin 8.5.2
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
cu...@gmail.com <cu...@gmail.com> #27
Hello, i encounter with similar issue in AGP 8.7.3 and R8 8.7.18:
goto :goto_5b
:cond_59
move-object/from16 v15, p24
:goto_5b
const/high16 v16, 0x4000000
and-int v0, v0, v16
if-eqz v0, :cond_64
const/16 v8, 0x0
goto :goto_67
:cond_64
move-object/16 v264, p25
...
move-object/from16 v2, v264
java.lang.VerifyError: Verifier rejected class:[0x430] copy1 v2<-v264 type=Undefined cat=3
ch...@google.com <ch...@google.com> #28
Re:
In order to diagnose this issue, we would likely need a reproduction. If it would be possible for you to share a compiler dump, which contains the inputs to the D8 compilation, that should allow us to reproduce the issue. You can share this privately with
You can generate such a dump by running ./gradlew assembleRelease --no-daemon -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/dumps
.
Description
Hello,
The issue continues to happen for us even with AGP 8.4.1. I am attaching the smali output here.
java.lang.VerifyError: Verifier rejected class com.pax.log.LogUtils: java.lang.StackTraceElement com.pax.log.LogUtils.getCaller(com.pax.log.b, java.lang.StackTraceElement[], int) failed to verify: java.lang.StackTraceElement com.pax.log.LogUtils.getCaller(com.pax.log.b, java.lang.StackTraceElement[], int): [0x21] type Undefined unexpected as arg to if-eqz/if-nez (declaration of 'com.pax.log.LogUtils' appears in /data/app/******-1/base.apk:classes8.dex)
at com.pax.log.LogUtils.isAndroid(LogUtils.java:125)
at com.pax.log.PaxLogWrapper.<init>(PaxLogWrapper.java:63)
at com.pax.log.PaxLogWrapper.<init>(PaxLogWrapper.java:52)
at com.pax.log.LogWrapperBinding.<clinit>(LogWrapperBinding.java:1)
at com.pax.log.LogWrapperBinding.registerLog(LogWrapperBinding.java:1)
at com.pax.poscomm.utils.CommLog.<clinit>(CommLog.java:1)
at com.pax.poscomm.utils.CommLog.v(CommLog.java:1)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getDalObjFromNeptuneLite(NeptuneBase.java:5)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getDalObjectFromNeptuneLib(NeptuneBase.java:6)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.getClassLoader(NeptuneBase.java:2)
at com.pax.poscomm.posapi.peripheries.NeptuneBase.loadDex(NeptuneBase.java:4)
at com.pax.poslink.POSLinkAndroid.a(POSLinkAndroid.java:2)
at com.pax.poslink.POSLinkAndroid.init(POSLinkAndroid.java:21)