Support inline classes with KSP 2 [344347969]

Assigned

Bug

Status Update

No update yet.

Description

st...@ns.nl

created issue #1

Jun 3, 2024 12:26PM

Component used: Room Compiler Versions used:

Room 2.7.0-alpha03
Kotlin 2.0.0
KSP 2.0.0-1.0.21 with ksp.useKSP2=true
Gradle 8.7.0

Room compiler fails to generate classes for entities with inline classes when using KSP 2.

Example entity:

@JvmInline
value class Identifier(val value: String)

@Entity
data class MyEntity(val id: Identifier)

This code works fine with KSP 1 but when KSP 2 is enabled we get the following error when running ./gradlew kspDebugKotlin.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:kspDebugKotlin'.
> A failure occurred while executing com.google.devtools.ksp.gradle.KspAAWorkerAction
   > Identifier? is not a sub type of the class/interface that contains `<init>` (Identifier)

See the full stacktrace in the attachment.

room-stacktrace.txt

25 KB

View

Download

Comments

da...@google.com <da...@google.com> Jun 3, 2024 12:34PM

Reassigned to ku...@google.com.

ku...@google.com <ku...@google.com> #2Jun 21, 2024 04:20PM

there are some image for help

sc...@gmail.com <sc...@gmail.com> #3Jun 25, 2024 04:44PM

hello?

ku...@google.com <ku...@google.com> #4Jun 25, 2024 05:57PM

scottolcott@gmail.com I moved the value class and the entity class to a different module that only depends on androidx.room:room-runtime and it still works. Are you seeing the same error message? And is it possible to provide a reproducible project?

sc...@gmail.com <sc...@gmail.com> #5Jun 26, 2024 08:46PM

I'm still seeing the error. I'll see if I can create up with a repro project.

sc...@gmail.com <sc...@gmail.com> #6Jul 1, 2024 11:21PM

The issue only occurs when the value class is nullable

For example the following fails with the error above, but if I comment out val myId: MyId? it compiles.

@JvmInline
value class MyId(val id: Long)


@Entity
data class MyEntity(
    @PrimaryKey
    val id: MyId,
    val myId: MyId?
)


@Database(
    version = 1,
    entities = [MyEntity::class]
)
abstract class AppDatabase : RoomDatabase() {
}

I attached a project that reproduces this issue.

K2RoomIssue.zip

396 KB

Download

ku...@google.com <ku...@google.com> #7Jul 5, 2024 07:50PM

Thanks for the repro. This is due to an issue in KSP2 filed here: https://github.com/google/ksp/issues/1989

sc...@gmail.com <sc...@gmail.com> #8Aug 12, 2024 04:54PM

It's been more than a month since the KSP issue was created. It seems like there hasn't been any progress made. Is there anyway to increase the priority of this issue on the KSP side?