Status Update
No update yet.
Comments
il...@google.com
When initialize the AppBarConfiguration, it will call the final method of NavGraph (findNode) and we cannot mock it.
sk...@gmail.com
il...@google.com
sk...@gmail.com
So current situation:
- Navigation library is already released with stable API.
- API is created without test-ability in mind. Huge classes with large amount of public methods, no interfaces. Using such tools as Mockito is not a solution, but workaround for situations when API is not testable.
After 10 years of creating un-testable Android SDKs there was possibility to have clean slate opportunity. And here we go again. API released and needs to be maintained now. Please recognize this problem now and bump priority from lowest (P3) to something higher. Because until we won't have possibility to test our app navigation flows we can't use this library.
il...@google.com
cl...@google.com
We'll be releasing a dedicated navigation-testing artifact in Navigation 2.3.0-alpha01 that provides additional testing specific APIs
This work includes:
https://android-review.googlesource.com/1180272 https://android-review.googlesource.com/1182957 https://android-review.googlesource.com/1187078
Among other changes.
ap...@google.com
Branch: androidx-main
commit 752e82e468e577c2fc891faae7b815501d6d3504
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 06 11:03:34 2024
Add comment on serializeAsValue/Values
Test: TH
Bug: 344943214
Relnote: "Add comment on NavType.serializeAsValue and serializeAsValues to highlight that the final outputs should be Uri encoded."
Change-Id: Ida6bd848fb1e3d8e26277eff0f214e1d40907063
M navigation/navigation-common/src/main/java/androidx/navigation/CollectionNavType.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
cl...@google.com
The added comments will be available in navigation 2.8.0-beta03.
jb...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta03
ig...@forzafootball.com
I believe the real issue has not been addressed.
The very idea of implementing type-safe navigation is to abstract details away (like dealing with uri creation and parsing), thus decreasing runtime issues by making developers work with types, which is great, BUT for some reason type abstraction still leaks with uri-based backend details, and still obligates devs to write boilerplate. For example there could be
enum class Category {
@SerialName("started") Started,
@SerialName("ended_unexpectedly") EndedUnexpectedly
}
which could be used as a primitive within app, come from network of whatever and one would expect to safely use it as a property in route data class bc there is first-party support for enum serialization.
Despite all this assumptions app would fail, when EndedUnexpectedly is used, but won't fail if Started is used bc of _, which is quite weird and moreover crash won't tell anything related to this specifically, only generic "can't find destination".
Forcing developers taking care of this is clearly the same issue we had before type-safe nav and which it was supposed to fix.
Description
Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: emulator API 34
Basically,
RouteBuilder.Filled<T>does not do any URL escaping. This causes runtime crashes during navigation with a non-escaped value the navigation library cannot find a target destination (as there is no argument match).This is unexpected as I'm using the abstraction for objects, with no URLs involved.