serializeAsValue does not mention that strings need to be Uri encoded [344943214]

Fixed

Bug

Status Update

No update yet.

Description

sk...@gmail.com

created issue #1

Jun 4, 2024 09:50PM

Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: emulator API 34

Basically, RouteBuilder.Filled<T> does not do any URL escaping. This causes runtime crashes during navigation with a non-escaped value the navigation library cannot find a target destination (as there is no argument match).

@Serializable
data class Dialog(
  val title: String,
)

navController.navigate(Dialog("You position is 1/3.")).

This is unexpected as I'm using the abstraction for objects, with no URLs involved.

Comments

il...@google.com <il...@google.com> #2Jun 4, 2024 10:16PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

sk...@gmail.com <sk...@gmail.com> #3Jun 4, 2024 10:19PM

yea i'll take it.

il...@google.com <il...@google.com> #4Jun 4, 2024 10:34PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

sk...@gmail.com <sk...@gmail.com> #5Jun 4, 2024 10:39PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

il...@google.com <il...@google.com> Jun 4, 2024 11:16PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #6Jun 6, 2024 06:07PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

ap...@google.com <ap...@google.com> #7Jun 6, 2024 06:41PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

cl...@google.com <cl...@google.com> #8Jun 6, 2024 06:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

jb...@google.com <jb...@google.com> Jun 12, 2024 04:35PM

Marked as fixed.

pr...@google.com <pr...@google.com> #9Jun 12, 2024 10:45PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta03

ig...@forzafootball.com <ig...@forzafootball.com> #10Sep 5, 2024 04:35PM

I believe the real issue has not been addressed.

The very idea of implementing type-safe navigation is to abstract details away (like dealing with uri creation and parsing), thus decreasing runtime issues by making developers work with types, which is great, BUT for some reason type abstraction still leaks with uri-based backend details, and still obligates devs to write boilerplate. For example there could be

enum class Category {
    @SerialName("started") Started,
    @SerialName("ended_unexpectedly") EndedUnexpectedly
}

which could be used as a primitive within app, come from network of whatever and one would expect to safely use it as a property in route data class bc there is first-party support for enum serialization.

Despite all this assumptions app would fail, when EndedUnexpectedly is used, but won't fail if Started is used bc of _, which is quite weird and moreover crash won't tell anything related to this specifically, only generic "can't find destination".

Forcing developers taking care of this is clearly the same issue we had before type-safe nav and which it was supposed to fix.

Message last modified on Sep 5, 2024 04:45PM