Status Update
No update yet.
Comments
il...@google.com
sk...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
il...@google.com
sk...@gmail.com
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
il...@google.com
cl...@google.com
As first step, adding comment to highlight the fact that outputs should be encoded. The lint can be added as a follow up, as part of other safe arg lints to be added.
ap...@google.com
Branch: androidx-main
commit 752e82e468e577c2fc891faae7b815501d6d3504
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 06 11:03:34 2024
Add comment on serializeAsValue/Values
Test: TH
Bug: 344943214
Relnote: "Add comment on NavType.serializeAsValue and serializeAsValues to highlight that the final outputs should be Uri encoded."
Change-Id: Ida6bd848fb1e3d8e26277eff0f214e1d40907063
M navigation/navigation-common/src/main/java/androidx/navigation/CollectionNavType.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
cl...@google.com
The added comments will be available in navigation 2.8.0-beta03.
jb...@google.com
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta03
ig...@forzafootball.com
I believe the real issue has not been addressed.
The very idea of implementing type-safe navigation is to abstract details away (like dealing with uri creation and parsing), thus decreasing runtime issues by making developers work with types, which is great, BUT for some reason type abstraction still leaks with uri-based backend details, and still obligates devs to write boilerplate. For example there could be
enum class Category {
@SerialName("started") Started,
@SerialName("ended_unexpectedly") EndedUnexpectedly
}
which could be used as a primitive within app, come from network of whatever and one would expect to safely use it as a property in route data class bc there is first-party support for enum serialization.
Despite all this assumptions app would fail, when EndedUnexpectedly is used, but won't fail if Started is used bc of _, which is quite weird and moreover crash won't tell anything related to this specifically, only generic "can't find destination".
Forcing developers taking care of this is clearly the same issue we had before type-safe nav and which it was supposed to fix.
Description
Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: emulator API 34
Basically,
RouteBuilder.Filled<T>does not do any URL escaping. This causes runtime crashes during navigation with a non-escaped value the navigation library cannot find a target destination (as there is no argument match).This is unexpected as I'm using the abstraction for objects, with no URLs involved.