UnknownNullness lint error when using type-use annotations [345452195]

Fixed

Bug

Status Update

No update yet.

Description

ju...@google.com

created issue #1

Jun 6, 2024 02:44PM

The UnknownNullness lint check only looks at nullness annotations on the item being inspected, which means that the following definitions using a type-use @Nullable trigger the check:

public int @Nullable [] foo() { return null; }

public java.lang.@Nullable String foo() { return null; }

Since the annotations here are applied directly to the type of the item, they have effectively the same meaning as annotating the item itself with a non-type-use @Nullable.

The check should also look at the annotations present on the PsiType and not report a lint violation if there is a nullness annotation.

I see that the issue is being reported here. I can contribute a fix if someone from the lint team will review it.

Comments

tn...@google.com <tn...@google.com> #2Jun 6, 2024 02:55PM

Yes, please contribute a fix -- lint doesn't support type use annotations at all (which is why we also haven't added TYPE_USE to the androidx annotations despite some requests for it -- adding to annotations is easy but updating lint checks is a lot of work.)

ju...@google.com <ju...@google.com> #3Jun 7, 2024 04:30PM

Reassigned to ju...@google.com.

Fix is up for review in ag/27719920.

I'm working on adding TYPE_USE to the AndroidX nullness annotations (doc). I've finished adding metalava support and I think this check is the one blocker on the lint side.

Message last modified on Jun 7, 2024 04:31PM

tn...@google.com <tn...@google.com> #4Jun 7, 2024 06:32PM

Thanks! Maybe audit KotlinNullnessAnnotationDetector too to make sure nothing is needed there.

ju...@google.com <ju...@google.com> #5Jun 10, 2024 03:27PM

Marked as fixed.

Created b/346327570 as a followup for KotlinNullnessAnnotationDetector.

an...@google.com <an...@google.com> #6Jun 17, 2024 07:32PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 Canary 6
Android Gradle Plugin 8.6.0-alpha06

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Issue 345452195