Remove @DoNotInline usage, disable lint check [345472586]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 6, 2024 04:37PM

R8 may double-outline platform NewApi calls when automatic outlining is enabled, so we should consider no-op'ing the @DoNotInline annotation when we're using an R8 version that does outlining.

Looping in from email,

The design for targeted rules is in go/targeted-shrinking-rules.

You can actually target R8 rules based on R8 version, so that's probably even better. I don't know where it's documented, but you can do: META-INF/com.android.tools/r8-upto-$VERSION/rules.pro

Comments

al...@google.com <al...@google.com> #2Jun 6, 2024 07:32PM

Tested the issue on chrome version #127.0.6533.120 using Mac 14.6.1 as per

comment#1

Steps to reproduce:
---------------------------
1.Launched chrome browser
2.Opened given link:

http://44.216.23.255 and seen "open" and onopen event got fired
3.Turn off the wifi and observed "offline" event fired

Attaching screencast for reference

Reporter@ Could you please review the attached screencast and let us know if anything being missed here also please confirm if point:3 is the issue you are pointing to? please provide screencast of actual and expected behaviour for better understanding and further triaging the issue.

Note: Requesting you to copy the entire content of "chrome://version/?show-variations-cmd" details and please copy paste the info in .txt file format.

Thanks..!!

sg...@google.com <sg...@google.com> #3Jun 7, 2024 06:54AM

Your screencast confirms the incorrect behavior.

I have attached a screencast that shows the expected behavior.

Of course, chrome doesn't behave in the expected way anymore, so my screencast uses Safari to show the correct behavior. When working correctly, the browser emits "close" and "error" events when the websocket is no longer connected (such as when wifi is disconnected). You'll notice chrome does not do this in your screencast, but Safari does do it in my screencast. Chrome used to emit the "close" and "error" events but it doesn't anymore. I would like Chrome to be fixed so it behaves correctly. Chrome should follow the websocket spec and emit the "close" and "error" events when a websocket is closed.

al...@google.com <al...@google.com> #4Jun 10, 2024 02:51PM

Thank you for providing more feedback. Adding the requester to the CC list.

ag...@google.com <ag...@google.com> #5Jun 10, 2024 03:08PM

Tested the issue on chrome version #127.0.6533.120 using Mac 14.6.1, Win 11, Linux debian as per steps in

comment#1

,3

Reproducible on
=============
130.0.6682.2 - Canary
130.0.6669.2 - Dev
129.0.6668.12 - Beta
128.0.6613.85 - Stable

The same issue seems to be reproducible from M-117 older versions, hence considering it as Non-Regression and marking it as untriaged

Thanks..!!

al...@google.com <al...@google.com> #6Jun 10, 2024 04:07PM

Thank you for testing this. This issue has been around since early 2023 so if you go back to Chrome #102 (roughly) you'll find the correct behavior and see that this a regression.

al...@google.com <al...@google.com> Jun 10, 2024 08:57PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #7Jun 11, 2024 04:30PM

Status: New

Hi Adam, could you take a look at this? Thank you!

al...@google.com <al...@google.com> Jul 2, 2024 02:50PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Jul 2, 2024 05:35PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #8Jul 8, 2024 05:41PM

Additionally switching Network to "throttled" or "offline" has no effect to the Websocket. I would expect the events to be fired here as well to debug offline behavior.

ap...@google.com <ap...@google.com> #9Jul 8, 2024 07:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 722ebe758557abaf7409c052bb2f326782369c84
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:05:38 2024

Remove usage of @DoNotInline for manual NewApi outlines (R thru W)

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: Ia60e0ab9f0fd613883a772c8aa34e27cc986cae8

M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/GridLayoutManager.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/MainActivity.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/systemrouting/source/AudioManagerSystemRoutesSource.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/player/Player.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/providers/SampleMediaRouteProvider.java
M security/security-crypto/src/main/java/androidx/security/crypto/MasterKey.java
M security/security-identity-credential/src/main/java/androidx/security/identity/HardwareIdentityCredential.java
M slice/slice-core/src/main/java/androidx/slice/Slice.java
M slice/slice-core/src/main/java/androidx/slice/compat/SliceProviderCompat.java
M sqlite/sqlite-framework/src/androidMain/kotlin/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.android.kt
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/AccessibilityNodeInfoDumper.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/ByMatcher.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiDevice.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiObject2.java
M testutils/testutils-runtime/src/main/java/androidx/testutils/AndroidFontScaleHelper.kt
M text/text/src/main/java/androidx/compose/ui/text/android/BoringLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/PaintExtensions.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/StaticLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextAndroidCanvas.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/selection/SegmentFinder.android.kt
M tracing/tracing/src/main/java/androidx/tracing/TraceApi29Impl.java
M transition/transition/src/main/java/androidx/transition/CanvasUtils.java
M transition/transition/src/main/java/androidx/transition/GhostViewHolder.java
M transition/transition/src/main/java/androidx/transition/ImageViewUtils.java
M transition/transition/src/main/java/androidx/transition/ObjectAnimatorUtils.java
M transition/transition/src/main/java/androidx/transition/PropertyValuesHolderUtils.java
M transition/transition/src/main/java/androidx/transition/Transition.java
M transition/transition/src/main/java/androidx/transition/TransitionUtils.java
M transition/transition/src/main/java/androidx/transition/ViewGroupUtils.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi19.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi21.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi22.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi23.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimatedVectorDrawableCompat.java
M versionedparcelable/versionedparcelable/src/main/java/androidx/versionedparcelable/VersionedParcel.java
M wear/protolayout/protolayout-expression-pipeline/src/main/java/androidx/wear/protolayout/expression/pipeline/NumberFormatter.java
M wear/tiles/tiles/src/main/java/androidx/wear/tiles/TileService.java
M wear/watchface/watchface-complications-data/src/main/java/androidx/wear/watchface/utility/TraceEvent.kt
M wear/wear-remote-interactions/src/main/java/androidx/wear/remote/interactions/RemoteInteractionsUtil.kt
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForM.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForN.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForO.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForOMR1.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForP.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForQ.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForTiramisu.java
M window/window/src/main/java/androidx/window/embedding/ExtensionEmbeddingBackend.kt
M window/window/src/main/java/androidx/window/embedding/SplitRule.kt
M window/window/src/main/java/androidx/window/layout/util/ContextCompatHelper.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableRuntimeExtras.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/DurationApi26.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi21.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi23.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi24.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkRequestCompat.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/ProcessUtils.kt

https://android-review.googlesource.com/3156141

ap...@google.com <ap...@google.com> #10Jul 9, 2024 03:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit a3c2cdfa79630ce1b6ccfae79068b331bd86889f
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:07:44 2024

Remove fully-qualified usages of @DoNotInline for manual NewApi outlines

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: I5921633fee80fcbc2c6ee05cb94f5fab0b9a6daf

M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidGraphicsContext.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPaint.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidRenderEffect.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV23.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV29.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsViewLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerManager.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerSnapshot.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.android.kt
M graphics/graphics-core/src/main/java/androidx/graphics/CanvasBufferedRendererV29.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/BufferTransformHintResolver.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/FrontBufferUtils.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/LowLatencyCanvasView.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlCompat.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlV33.kt
M graphics/graphics-core/src/main/java/androidx/hardware/SyncFenceCompat.kt
M leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionsStylist.java

https://android-review.googlesource.com/3156142

al...@google.com <al...@google.com> #11Jul 9, 2024 04:37PM

Remaining work:

Get the last few @DoNotInline CLs merged
Inline existing NewApi classes
- Or don't? Users running R8 won't see a difference, users not running R8/D8 will get VFY errors
- Write a lint auto-fix to automate this?

ap...@google.com <ap...@google.com> #12Jul 9, 2024 05:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 72d83666a81c444dfc045e292cf52e3ec9c69d8b
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:03:53 2024

Remove usage of @DoNotInline for manual NewApi outlines (Cr thru P)

Excludes some privacysandbox libraries because I'm not certain how the
annotation is being used there.

Suppresses flaky PrimitiveInCollection lint failure in Glance.

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: If6b4ccfca0a943b45971a422b58949b13a10bada

M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/controllers/CreatePublicKeyCredential/PublicKeyCredentialControllerUtility.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginCreateCredentialRequest.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginCreateCredentialResponse.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginGetCredentialRequest.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginGetCredentialResponse.kt
M datastore/datastore/src/androidMain/kotlin/androidx/datastore/migrations/SharedPreferencesMigration.android.kt
M draganddrop/draganddrop/src/main/java/androidx/draganddrop/DropAffordanceHighlighter.java
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/ConcurrencyHelpers.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/EmojiExclusions.java
M exifinterface/exifinterface/src/main/java/androidx/exifinterface/media/ExifInterfaceUtils.java
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
M glance/glance-appwidget/lint-baseline.xml
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/AppWidgetUtils.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/ApplyModifiers.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceAppWidgetManager.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceRemoteViewsService.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/LayoutSelection.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/RemoteViewsTranslator.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/WidgetLayout.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/action/ActionTrampoline.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/action/ApplyAction.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/CompoundButtonApi31Impl.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/ImageTranslator.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/TextTranslator.kt
M glance/glance/src/main/java/androidx/glance/session/IdleEventBroadcastReceiver.kt
M glance/glance/src/main/java/androidx/glance/unit/ColorProvider.kt
M health/connect/connect-client/src/main/java/androidx/health/connect/client/HealthConnectClient.kt
M health/connect/connect-client/src/main/java/androidx/health/platform/client/impl/data/SharedMemory27Impl.kt
M input/input-motionprediction/src/main/java/androidx/input/motionprediction/common/PredictionEstimator.java
M leanback/leanback/src/main/java/androidx/leanback/app/FragmentUtil.java
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/java/android/support/v4/media/MediaDescriptionCompat.java
M media/media/src/main/java/android/support/v4/media/session/MediaSessionCompat.java
M media/media/src/main/java/android/support/v4/media/session/PlaybackStateCompat.java
M media/media/src/main/java/androidx/media/AudioFocusRequestCompat.java
M media/media/src/main/java/androidx/media/AudioManagerCompat.java
M media/media/src/main/java/androidx/media/VolumeProviderCompat.java
M media/media/src/main/java/androidx/media/app/NotificationCompat.java
M media/media/src/main/java/androidx/media/session/MediaButtonReceiver.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/app/SystemOutputSwitcherDialogController.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRoute2Provider.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRouter2Utils.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRouterUtils.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/PlatformMediaRouter1RouteProvider.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/RemotePlaybackClient.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/RouteListingPreference.java
M preference/preference/src/main/java/androidx/preference/PreferenceCategory.java
M preference/preference/src/main/java/androidx/preference/PreferenceDialogFragment.java
M preference/preference/src/main/java/androidx/preference/PreferenceDialogFragmentCompat.java
M print/print/src/main/java/androidx/print/PrintHelper.java
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/InMemorySdkClassLoaderFactory.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/impl/MigrationUtils.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/impl/SandboxedSdkContextCompat.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/storage/LocalSdkFolderProvider.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/LoadSdkCompatException.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/SandboxedSdkCompat.kt
M privacysandbox/ui/ui-client/src/main/java/androidx/privacysandbox/ui/client/view/SandboxedSdkView.kt
M privacysandbox/ui/ui-provider/src/main/java/androidx/privacysandbox/ui/provider/BinderAdapterDelegate.kt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileInstallerInitializer.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileVerifier.java

https://android-review.googlesource.com/3156140

ap...@google.com <ap...@google.com> #13Jul 9, 2024 05:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit 10ffa70a46c505e0af76fc71d93af285f7527bdf
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 09 11:02:59 2024

Remove usage of @DoNotInline for manual NewApi outlines (Com thru Cor)

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: Ieb9aecd2af5587c5b82833146fee6e912693ab7b

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/EdgeEffectCompat.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/InputMethodManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyCursorAnchorInfoBuilder.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/RecordingInputConnection.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/StatelessInputConnection.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldLayoutStateCache.android.kt
M compose/material/material-ripple/src/androidMain/kotlin/androidx/compose/material/ripple/RippleHostView.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/DynamicTonalPalette.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/AccessibilityServiceStateProvider.android.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.android.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/ViewCapture.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidColorFilter.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidColorSpace.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidImageBitmap.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidTileMode.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/CanvasUtils.android.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/android/WindowCapture.android.kt
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/HandlerHelper.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontUtils.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidPreloadedFont.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableString.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidFontListTypeface.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/LocaleExtensions.android.kt
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/LayoutlibFontResourceLoader.android.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/viewinterop/ViewInterop.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AndroidSemanticAutofill.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AutofillCallback.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AutofillUtils.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/contentcapture/AndroidContentCaptureManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/MotionEventAdapter.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidAccessibilityManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidClipboardManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidFontResourceLoader.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidTextToolbar.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidViewConfiguration.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/ColorResources.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/scrollcapture/ScrollCapture.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/CursorAnchorInfoBuilder.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ContentCaptureSessionCompat.java
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ViewCompatShims.java
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ViewStructureCompat.java
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionLayout.kt
M core/core-animation/src/main/java/androidx/core/animation/PathUtils.java
M core/core-i18n/src/main/java/androidx/core/i18n/DateTimeFormatter.kt
M core/core-ktx/src/main/java/androidx/core/content/res/TypedArray.kt
M core/core-ktx/src/main/java/androidx/core/os/Bundle.kt
M core/core-ktx/src/main/java/androidx/core/os/PersistableBundle.kt
M core/core-location-altitude/src/main/java/androidx/core/location/altitude/AltitudeConverterCompat.java
M core/core-remoteviews/src/main/java/androidx/core/widget/AppWidgetManagerCompat.kt
M core/core-remoteviews/src/main/java/androidx/core/widget/RemoteViewsCompat.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/ThemeUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/extensions/CallExtensions.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/CallSessionLegacy.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/CallAttributesUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/EndpointUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/Utils.kt
M core/core/src/androidTest/java/androidx/core/location/LocationRequestCompatTestApi19.java
M core/core/src/main/java/androidx/core/app/ActivityCompat.java
M core/core/src/main/java/androidx/core/app/ActivityOptionsCompat.java
M core/core/src/main/java/androidx/core/app/AlarmManagerCompat.java
M core/core/src/main/java/androidx/core/app/AppOpsManagerCompat.java
M core/core/src/main/java/androidx/core/app/DialogCompat.java
M core/core/src/main/java/androidx/core/app/GrammaticalInflectionManagerCompat.java
M core/core/src/main/java/androidx/core/app/LocaleManagerCompat.java
M core/core/src/main/java/androidx/core/app/NotificationChannelCompat.java
M core/core/src/main/java/androidx/core/app/NotificationChannelGroupCompat.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
M core/core/src/main/java/androidx/core/app/NotificationCompatBuilder.java
M core/core/src/main/java/androidx/core/app/NotificationManagerCompat.java
M core/core/src/main/java/androidx/core/app/PendingIntentCompat.java
M core/core/src/main/java/androidx/core/app/Person.java
M core/core/src/main/java/androidx/core/app/RemoteActionCompat.java
M core/core/src/main/java/androidx/core/app/RemoteInput.java
M core/core/src/main/java/androidx/core/app/ServiceCompat.java
M core/core/src/main/java/androidx/core/content/ContextCompat.java
M core/core/src/main/java/androidx/core/content/FileProvider.java
M core/core/src/main/java/androidx/core/content/IntentCompat.java
M core/core/src/main/java/androidx/core/content/IntentSanitizer.java
M core/core/src/main/java/androidx/core/content/pm/PackageInfoCompat.java
M core/core/src/main/java/androidx/core/content/pm/PermissionInfoCompat.java
M core/core/src/main/java/androidx/core/content/res/FontResourcesParserCompat.java
M core/core/src/main/java/androidx/core/content/res/ResourcesCompat.java
M core/core/src/main/java/androidx/core/database/CursorWindowCompat.java
M core/core/src/main/java/androidx/core/database/sqlite/SQLiteCursorCompat.java
M core/core/src/main/java/androidx/core/graphics/BitmapCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeColorFilterCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeUtils.java
M core/core/src/main/java/androidx/core/graphics/ColorUtils.java
M core/core/src/main/java/androidx/core/graphics/Insets.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
M core/core/src/main/java/androidx/core/graphics/PathUtils.java
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M core/core/src/main/java/androidx/core/graphics/drawable/IconCompat.java
M core/core/src/main/java/androidx/core/hardware/fingerprint/FingerprintManagerCompat.java
M core/core/src/main/java/androidx/core/location/GnssStatusWrapper.java
M core/core/src/main/java/androidx/core/location/LocationCompat.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
M core/core/src/main/java/androidx/core/location/LocationRequestCompat.java
M core/core/src/main/java/androidx/core/net/ConnectivityManagerCompat.java
M core/core/src/main/java/androidx/core/net/TrafficStatsCompat.java
M core/core/src/main/java/androidx/core/os/BuildCompat.kt
M core/core/src/main/java/androidx/core/os/BundleCompat.java
M core/core/src/main/java/androidx/core/os/ConfigurationCompat.java
M core/core/src/main/java/androidx/core/os/EnvironmentCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompatWrapper.java
M core/core/src/main/java/androidx/core/os/MessageCompat.java
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
M core/core/src/main/java/androidx/core/os/TraceCompat.java
M core/core/src/main/java/androidx/core/os/UserManagerCompat.java
M core/core/src/main/java/androidx/core/provider/DocumentsContractCompat.java
M core/core/src/main/java/androidx/core/service/quicksettings/TileServiceCompat.java
M core/core/src/main/java/androidx/core/telephony/SubscriptionManagerCompat.java
M core/core/src/main/java/androidx/core/telephony/TelephonyManagerCompat.java
M core/core/src/main/java/androidx/core/text/HtmlCompat.java
M core/core/src/main/java/androidx/core/text/ICUCompat.java
M core/core/src/main/java/androidx/core/text/PrecomputedTextCompat.java
M core/core/src/main/java/androidx/core/text/util/LinkifyCompat.java
M core/core/src/main/java/androidx/core/text/util/LocalePreferences.java
M core/core/src/main/java/androidx/core/util/SizeFCompat.java
M core/core/src/main/java/androidx/core/util/TypedValueCompat.java
M core/core/src/main/java/androidx/core/view/ContentInfoCompat.java
M core/core/src/main/java/androidx/core/view/DisplayCompat.java
M core/core/src/main/java/androidx/core/view/DisplayCutoutCompat.java
M core/core/src/main/java/androidx/core/view/DragAndDropPermissionsCompat.java
M core/core/src/main/java/androidx/core/view/MenuCompat.java
M core/core/src/main/java/androidx/core/view/MenuItemCompat.java
M core/core/src/main/java/androidx/core/view/PointerIconCompat.java
M core/core/src/main/java/androidx/core/view/VelocityTrackerCompat.java
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/ViewConfigurationCompat.java
M core/core/src/main/java/androidx/core/view/ViewGroupCompat.java
M core/core/src/main/java/androidx/core/view/ViewParentCompat.java
M core/core/src/main/java/androidx/core/view/ViewPropertyAnimatorCompat.java
M core/core/src/main/java/androidx/core/view/ViewStructureCompat.java
M core/core/src/main/java/androidx/core/view/WindowCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityEventCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityManagerCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityWindowInfoCompat.java
M core/core/src/main/java/androidx/core/view/animation/PathInterpolatorCompat.java
M core/core/src/main/java/androidx/core/view/contentcapture/ContentCaptureSessionCompat.java
M core/core/src/main/java/androidx/core/view/inputmethod/InputConnectionCompat.java
M core/core/src/main/java/androidx/core/widget/CompoundButtonCompat.java
M core/core/src/main/java/androidx/core/widget/EdgeEffectCompat.java
M core/core/src/main/java/androidx/core/widget/ImageViewCompat.java
M core/core/src/main/java/androidx/core/widget/NestedScrollView.java
M core/core/src/main/java/androidx/core/widget/PopupWindowCompat.java
M core/core/src/main/java/androidx/core/widget/TextViewCompat.java
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/HapticAttributesConverter.kt
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/HapticSignalConverter.kt
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/VibratorWrapperImpl.kt

https://android-review.googlesource.com/3156139

ap...@google.com <ap...@google.com> #14Jul 10, 2024 04:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 12ea61e42c7f29a0f539a069f06507a0f133910d
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 13:55:26 2024

Remove usage of @DoNotInline for manual NewApi outlines (A thru Ca)

Does not include AppSearch because they have downstream changes.

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: I9496cfaeb50a5c484fbee6521b74a0605fb013dc

M activity/activity/src/main/java/androidx/activity/BackEventCompat.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/resources/Compatibility.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppLocalesMetadataHolderService.java
M appcompat/appcompat/src/main/java/androidx/appcompat/view/WindowCallbackWrapper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatReceiveContentHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatSpinner.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextClassifierHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextViewAutoSizeHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ListPopupWindow.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/MenuPopupWindow.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/SearchView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/TintTypedArray.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/Toolbar.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/TooltipCompat.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewUtils.java
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/integration-tests/macrobenchmark-target/src/main/java/androidx/benchmark/integration/macrobenchmark/target/SingleColorActivity.kt
M biometric/integration-tests/testapp/src/main/java/androidx/biometric/integration/testapp/CryptoUtils.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/AdvertiseParams.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/ScanFilter.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/ScanResult.kt
M browser/browser/src/main/java/androidx/browser/customtabs/Api33Impl.java
M browser/browser/src/main/java/androidx/browser/customtabs/CustomTabsIntent.java
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/EncoderProfilesProviderAdapter.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/ApiCompat.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/impl/CameraInteropStateCallbackRepository.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/internal/DynamicRangeConversions.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/internal/DynamicRangeResolver.kt
M camera/camera-camera2-pipe/src/main/java/androidx/camera/camera2/pipe/compat/ApiCompat.kt
M camera/camera-camera2-pipe/src/main/java/androidx/camera/camera2/pipe/compat/CaptureSessionWrapper.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CaptureRequestBuilder.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2EncoderProfilesProvider.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/DynamicRangeResolver.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SynchronizedCaptureSessionBaseImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/ApiCompat.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/StreamConfigurationMapCompatBaseImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/params/DynamicRangeConversions.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/Bitmap2JpegBytes.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraValidator.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ContextUtil.java
M camera/camera-effects/src/main/java/androidx/camera/effects/internal/Utils.java
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/util/Api21Impl.kt
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/ExtensionsUtils.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/compat/workaround/CaptureOutputSurfaceForCaptureProcessor.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/CameraUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/TestImageUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/WakelockEmptyActivityRule.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/compat/LooperCompat.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api23Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api24Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api26Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api28Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api29Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api31Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/encoder/EncoderImpl.java
M camera/camera-view/src/main/java/androidx/camera/view/SurfaceViewImplementation.java
M camera/camera-viewfinder/src/main/java/androidx/camera/viewfinder/SurfaceViewImplementation.java
M camera/integration-tests/avsynctestapp/src/main/java/androidx/camera/integration/avsync/MainActivity.kt
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/SimpleCamera.kt
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXService.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/OpenGLActivity.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/SurfaceViewRenderSurface.java
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/Camera2ExtensionsActivity.kt
M car/app/app-automotive/src/main/java/androidx/car/app/activity/BaseCarAppActivity.java
M car/app/app-automotive/src/main/java/androidx/car/app/activity/renderer/surface/TemplateSurfaceView.java
M car/app/app-automotive/src/main/java/androidx/car/app/hardware/info/AutomotiveCarInfo.java
M car/app/app/src/main/java/androidx/car/app/CarAppMetadataHolderService.java
M car/app/app/src/main/java/androidx/car/app/CarContext.java
M car/app/app/src/main/java/androidx/car/app/SessionInfoIntentEncoder.java
M car/app/app/src/main/java/androidx/car/app/connection/CarConnectionTypeLiveData.java
M car/app/app/src/main/java/androidx/car/app/model/DateTimeWithZone.java
M car/app/app/src/main/java/androidx/car/app/model/DurationSpan.java
M car/app/app/src/main/java/androidx/car/app/navigation/model/TravelEstimate.java
M car/app/app/src/main/java/androidx/car/app/notification/CarNotificationManager.java
M car/app/app/src/main/java/androidx/car/app/validation/HostValidator.java

https://android-review.googlesource.com/3156138

al...@google.com <al...@google.com> #15Jul 10, 2024 05:48PM

Assigned to bu...@google.com.

We still have some @DoNotInline usages lingering because of conflicts with androidx-platform-dev. Once the upstreaming is completed and those are removed, I think we should call it done. Manually inlining the ApiXXImpl classes isn't urgent or really necessary.

bu...@google.com <bu...@google.com> #16Jul 10, 2024 05:53PM

Accepted by bu...@google.com.

Hi. I've received your bug, you didn't specify what to wait for so I will wait for

b/346290560

to be resolved and then assign the bug to alanv@google.com.

Bugjuggler:

b/346290560

-> assigned to alanv@google.com

ap...@google.com <ap...@google.com> #17Jul 18, 2024 03:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit c520a87c6e27a14472cfcf8b03c0d4ea8c1a37c7
Author: Ian Baker <ibaker@google.com>
Date: Thu Jul 18 08:32:31 2024

Remove `@DoNotInline` recommendations from go/androidx-api-guidelines

The associated lint check has been disabled, see

b/345472586

for more details.

PiperOrigin-RevId: 653629895
Change-Id: I186c052a059e5ad30386cd45beb47f24bdafe657

M docs/api_guidelines/compat.md
M docs/api_guidelines/platform_compat.md

https://android-review.googlesource.com/3177449

bu...@google.com <bu...@google.com> Jul 23, 2024 02:34PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> #18Jul 29, 2024 02:25PM

Marked as fixed.

We'll take removing manual outlining on a case-by-case basis. Removing it all at once would be a lot of work for not much gain.