Remove @DoNotInline usage, disable lint check [345472586]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 6, 2024 04:37PM

R8 may double-outline platform NewApi calls when automatic outlining is enabled, so we should consider no-op'ing the @DoNotInline annotation when we're using an R8 version that does outlining.

Looping in from email,

The design for targeted rules is in go/targeted-shrinking-rules.

You can actually target R8 rules based on R8 version, so that's probably even better. I don't know where it's documented, but you can do: META-INF/com.android.tools/r8-upto-$VERSION/rules.pro

Comments

al...@google.com <al...@google.com> #2Jun 6, 2024 07:32PM

Could you look into it @christofferqa?

The issue is with this class:

class MySpi : Spi {
    @Volatile
    private var myApi: Api? = null

    // Incorrectly rewritten to return null;
    override fun createApi(): Api {
        return myApi ?: synchronized(this) {
            myApi ?: MyApi().also { myApi = it }
        }
    }
}

The error seems to be that the ArgumentPropagator believes that the fieldState of myApi is ExactDynamicType(@NotNull MyApi) while it should be ExactDynamicType(@Nullable MyApi)

It then removes the first branch (assuming myApi is not null):

return myApi ?: synchronized(this) {
            myApi ?: MyApi().also { myApi = it }
        }

is rewritten into:

return myApi

And then it eventually concludes that myApi is always null, replacing the code by

return null

The ArgumentPropagatorCodeScanner analyzes the assignment myApi = it and correctly set join the state to ExactDynamicType(@NotNull MyApi)

However the ArgumentPropagator fails to understand that myApi can be read before being written in the method, relying on the default null value, so it fails to join null to the dynamic type.

sg...@google.com <sg...@google.com> #3Jun 7, 2024 06:54AM

Yes I can take a look. Would it be possible for you to add a regression test of this issue?

al...@google.com <al...@google.com> #4Jun 10, 2024 02:51PM

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101407

Reproduce field propagation issue with ServiceLoader

Expand for full commit details

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b

Files:

A src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 6ba9af34b15f2a0d3fe356f6e7a5a4071128aed9
Date: Wed Feb 12 09:31:01 2025

ag...@google.com <ag...@google.com> #5Jun 10, 2024 03:08PM

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101408

Account for ServiceLoaders in field value propagation

Expand for full commit details

Account for ServiceLoaders in field value propagation 
 
Fixes: b/389737060 
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5

Files:

M src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java
M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 692fff07b70f6ee5ac520b179aed5e125a0d4848
Date: Wed Feb 12 09:34:04 2025

al...@google.com <al...@google.com> #6Jun 10, 2024 04:07PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101512

Account for ServiceLoaders in field value propagation

Expand for full commit details

Account for ServiceLoaders in field value propagation 
 
Fixes: b/389737060 
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5

Files:

M src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java
M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 76cad195cf43c16aa9e7b0203e51662036587e71
Date: Thu Feb 13 10:33:29 2025

al...@google.com <al...@google.com> Jun 10, 2024 08:57PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #7Jun 11, 2024 04:30PM

Status: New

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101522

Version 8.9.28

Expand for full commit details

Version 8.9.28 
 
Bug: b/389737060 
Change-Id: I42c8d3194dc053e3a16eef8ea1c4b3aced6752d6

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 668c1778e857c1bc8e3f9308a65ddc01a6c14898
Date: Thu Feb 13 10:33:34 2025

al...@google.com <al...@google.com> Jul 2, 2024 02:50PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Jul 2, 2024 05:35PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #8Jul 8, 2024 05:41PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101511

Reproduce field propagation issue with ServiceLoader

Expand for full commit details

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b

Files:

A src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: a76d3e8637b5280dcc972ed9fabc74bb503cc30c
Date: Thu Feb 13 10:33:24 2025

ap...@google.com <ap...@google.com> #9Jul 8, 2024 07:31PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101513

Reproduce field propagation issue with ServiceLoader

Expand for full commit details

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b

Files:

A src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: a63678f7ebb3321af74c9846be9c851e4da78e4f
Date: Thu Feb 13 10:33:55 2025

ap...@google.com <ap...@google.com> #10Jul 9, 2024 03:56PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101514

Version 8.8.35

Expand for full commit details

Version 8.8.35 
 
Bug: b/389737060 
Change-Id: I2361f77b42b529f2cbdfbf60fbe4a95e405ba716

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: d280891c805561bc120f5f96841b50353e74edfe
Date: Thu Feb 13 10:34:06 2025

al...@google.com <al...@google.com> #11Jul 9, 2024 04:37PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101523

Account for ServiceLoaders in field value propagation

Expand for full commit details

Account for ServiceLoaders in field value propagation 
 
Fixes: b/389737060 
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5

Files:

M src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java
M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 05dd13d906b60efdf03caea7067dedf67b7c6a2e
Date: Thu Feb 13 10:34:00 2025

ap...@google.com <ap...@google.com> #12Jul 9, 2024 05:08PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101540

Account for ServiceLoaders in field value propagation

Expand for full commit details

Account for ServiceLoaders in field value propagation 
 
Fixes: b/389737060 
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5

Files:

M src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java
M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: d7dcc9001453052f772056337d3c120dba34fc46
Date: Thu Feb 13 10:34:31 2025

ap...@google.com <ap...@google.com> #13Jul 9, 2024 05:38PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101541

Version 8.7.35

Expand for full commit details

Version 8.7.35 
 
Bug: b/389737060 
Change-Id: Icfb60f565b329600b5f167a496a39a61ebff9ea6

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 1be71bdf4455bbc565502b4c3bbbae64608c57a6
Date: Thu Feb 13 10:34:38 2025

ap...@google.com <ap...@google.com> #14Jul 10, 2024 04:05PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101515

Reproduce field propagation issue with ServiceLoader

Expand for full commit details

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b

Files:

A src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 7272540b4f7850ef22543defc221660359704ea2
Date: Thu Feb 13 10:34:26 2025

al...@google.com <al...@google.com> #15Jul 10, 2024 05:48PM

Assigned to bu...@google.com.

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101512

Account for ServiceLoaders in field value propagation

Expand for full commit details

Account for ServiceLoaders in field value propagation 
 
Fixes: b/389737060 
Change-Id: Ide438a8e1b0541f3ce2385087f06f8b9909ab3c5

Files:

M src/main/java/com/android/tools/r8/optimize/argumentpropagation/propagation/DefaultFieldValueJoiner.java
M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 76cad195cf43c16aa9e7b0203e51662036587e71
Date: Thu Feb 13 10:33:29 2025

bu...@google.com <bu...@google.com> #16Jul 10, 2024 05:53PM

Accepted by bu...@google.com.

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101511

Reproduce field propagation issue with ServiceLoader

Expand for full commit details

Reproduce field propagation issue with ServiceLoader 
 
Bug: b/389737060 
Change-Id: Id850448f68b999194bc0380dfca625f4f68bc31b

Files:

A src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: a76d3e8637b5280dcc972ed9fabc74bb503cc30c
Date: Thu Feb 13 10:33:24 2025

ap...@google.com <ap...@google.com> #17Jul 18, 2024 03:34PM

This should now be fixed in R8 8.7.36, 8.8.36 and 8.9.28.

bu...@google.com <bu...@google.com> Jul 23, 2024 02:34PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> #18Jul 29, 2024 02:25PM

Marked as fixed.

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101518

Version 8.8.36

Expand for full commit details

Version 8.8.36 
 
Bug: b/389737060 
Change-Id: I9ac9a6eda36030b2569bf6839f9b55257f0d2888

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: d228eeda266e288da18698a2fa464fc97b0303c3
Date: Thu Feb 13 12:31:37 2025

pr...@google.com <pr...@google.com> #19Aug 13, 2024 06:58PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101547

Fix call to addDataResources in test

Expand for full commit details

Fix call to addDataResources in test 
 
This was added in 8.9. 
 
Bug: b/389737060 
Change-Id: I604550f0c0034256f71c03874eeb4798f7079f18

Files:

M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 58502e8fa34f0abe33a254671faf1b74e0668c86
Date: Thu Feb 13 12:30:57 2025

na...@google.com <na...@google.com> #20Aug 21, 2024 07:55PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101546

Version 8.7.36

Expand for full commit details

Version 8.7.36 
 
Bug: b/389737060 
Change-Id: Ib57157e3ca8863dcb097a3aa0a1e840c546a4392

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: de384a5950a14b2244dc74819fffd0306cae7065
Date: Thu Feb 13 12:28:52 2025

pr...@google.com <pr...@google.com> #21Sep 5, 2024 08:09PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101545

Fix call to addDataResources in test

Expand for full commit details

Fix call to addDataResources in test 
 
This was added in 8.9. 
 
Bug: b/389737060 
Change-Id: I04d342dc297474d141362290f9ccf22c48332446

Files:

M src/test/java/com/android/tools/r8/ir/optimize/membervaluepropagation/DefaultFieldValueJoinerWithServiceLoaderTest.java

Hash: 981af34dd96a316d0c11972d80ce31ab301ec6c1
Date: Thu Feb 13 12:28:09 2025

na...@google.com <na...@google.com> #22Sep 18, 2024 05:37PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat Feature Drop | 2024.3.2 Beta 1
Android Gradle Plugin 8.10.0-beta01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

pr...@google.com <pr...@google.com> #23Oct 2, 2024 05:37PM

The fixes for this issue are now also available in:

Android Studio Meerkat | 2024.3.1 Patch 1
Android Gradle Plugin 8.9.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

na...@google.com <na...@google.com> #24Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-location-altitude:1.0.0-alpha03

na...@google.com <na...@google.com> #25Nov 13, 2024 06:19PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

pr...@google.com <pr...@google.com> #26Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-telecom:1.0.0-beta01
androidx.mediarouter:mediarouter:1.8.0-alpha01
androidx.transition:transition:1.6.0-alpha01

na...@google.com <na...@google.com> #27Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.browser:browser:1.9.0-alpha01
androidx.versionedparcelable:versionedparcelable:1.2.1

pr...@google.com <pr...@google.com> #28Feb 12, 2025 06:40PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tracing:tracing:1.3.0-beta01

na...@google.com <na...@google.com> #29Mar 12, 2025 06:13PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-i18n:1.0.0-beta01
androidx.leanback:leanback:1.2.0-beta01

Issue 345472586

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 6, 2024 07:32PM

sg...@google.com <sg...@google.com> #3Jun 7, 2024 06:54AM

al...@google.com <al...@google.com> #4Jun 10, 2024 02:51PM

ag...@google.com <ag...@google.com> #5Jun 10, 2024 03:08PM

al...@google.com <al...@google.com> #6Jun 10, 2024 04:07PM

al...@google.com <al...@google.com> Jun 10, 2024 08:57PM

al...@google.com <al...@google.com> #7Jun 11, 2024 04:30PM

al...@google.com <al...@google.com> Jul 2, 2024 02:50PM

al...@google.com <al...@google.com> Jul 2, 2024 05:35PM

ap...@google.com <ap...@google.com> #8Jul 8, 2024 05:41PM

ap...@google.com <ap...@google.com> #9Jul 8, 2024 07:31PM

ap...@google.com <ap...@google.com> #10Jul 9, 2024 03:56PM

al...@google.com <al...@google.com> #11Jul 9, 2024 04:37PM

ap...@google.com <ap...@google.com> #12Jul 9, 2024 05:08PM

ap...@google.com <ap...@google.com> #13Jul 9, 2024 05:38PM

ap...@google.com <ap...@google.com> #14Jul 10, 2024 04:05PM

al...@google.com <al...@google.com> #15Jul 10, 2024 05:48PM

bu...@google.com <bu...@google.com> #16Jul 10, 2024 05:53PM

ap...@google.com <ap...@google.com> #17Jul 18, 2024 03:34PM

bu...@google.com <bu...@google.com> Jul 23, 2024 02:34PM

al...@google.com <al...@google.com> #18Jul 29, 2024 02:25PM

pr...@google.com <pr...@google.com> #19Aug 13, 2024 06:58PM

na...@google.com <na...@google.com> #20Aug 21, 2024 07:55PM

pr...@google.com <pr...@google.com> #21Sep 5, 2024 08:09PM

na...@google.com <na...@google.com> #22Sep 18, 2024 05:37PM

pr...@google.com <pr...@google.com> #23Oct 2, 2024 05:37PM

na...@google.com <na...@google.com> #24Oct 16, 2024 05:48PM

na...@google.com <na...@google.com> #25Nov 13, 2024 06:19PM

pr...@google.com <pr...@google.com> #26Dec 11, 2024 06:27PM

na...@google.com <na...@google.com> #27Jan 29, 2025 06:11PM

pr...@google.com <pr...@google.com> #28Feb 12, 2025 06:40PM

na...@google.com <na...@google.com> #29Mar 12, 2025 06:13PM

Add comment

Issue metadata