IssueTracker

Any updates?

Could you please confirm the library versions?

Also, could you verify if this still happens without using the androidx.tv.foundation library?

I can't seem to remove the androix.tv.foundation library since one of the composables are using:

import androidx.tv.foundation.lazy.list.TvLazyColumn
import androidx.tv.material3.Icon
import androidx.tv.material3.MaterialTheme
import androidx.tv.material3.Surface
import androidx.tv.material3.Switch
import androidx.tv.material3.SwitchDefaults
import androidx.tv.material3.Text

Below is my build.gradle.kts file

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    id("org.jetbrains.kotlin.plugin.compose")
    //Added for Hilt Dependency Injection capabilities
    id("com.google.dagger.hilt.android")
    //Added for Firebase Cloud Messaging service
    id("com.google.gms.google-services")
    id("kotlin-kapt")
}

android {
    namespace = "***.********.********"
    compileSdk = 34

    defaultConfig {
        applicationId = "***.********.********"
        minSdk = 28
        targetSdk = 34
        versionCode = 1
        versionName = "1.0"

    }

    signingConfigs {
        getByName("debug") {
            keyAlias = "****"
            keyPassword = "********"
            storeFile = file("*****")
            storePassword = "********"
        }
        create("release") {
            keyAlias = "****"
            keyPassword = "********"
            storeFile = file("*****")
            storePassword = "********"
        }
    }

    buildTypes {
        debug {
            isMinifyEnabled = false
            isShrinkResources = false
            signingConfig = signingConfigs.getByName("debug")
            isDebuggable = true
        }
        release {
            isMinifyEnabled = true
            isShrinkResources = false
            proguardFiles(
                getDefaultProguardFile("proguard-android-optimize.txt"),
                "proguard-rules.pro"
            )
            signingConfig = signingConfigs.getByName("release")
            isDebuggable = false
            ndk {
                debugSymbolLevel = "FULL"
            }
        }
    }
    compileOptions {
        sourceCompatibility = JavaVersion.VERSION_17
        targetCompatibility = JavaVersion.VERSION_17
    }
    kotlinOptions {
        jvmTarget = "17"
        freeCompilerArgs += "-opt-in=kotlin.RequiresOptIn"
        // Allow for widescale experimental APIs in Alpha libraries we build upon
        freeCompilerArgs += "-opt-in=androidx.compose.animation.ExperimentalAnimationApi"
    }
    buildFeatures {
        compose = true
        buildConfig = true
    }
    // Allow references to generated code
    kapt {
        correctErrorTypes = true
    }
}

dependencies {

    implementation("androidx.compose.foundation:foundation:1.7.0-beta03")
    implementation("androidx.tv:tv-foundation:1.0.0-alpha10")
    implementation("androidx.tv:tv-material:1.0.0-beta01")
    implementation("androidx.compose.material3:material3:1.2.1")
    implementation("androidx.compose.material:material-icons-extended:1.6.8")

    implementation("androidx.compose.ui:ui-tooling-preview:1.7.0-beta03")
    debugImplementation("androidx.compose.ui:ui-tooling:1.7.0-beta03")
    debugImplementation("androidx.compose.ui:ui-test-manifest:1.7.0-beta03")
    testImplementation("androidx.compose.ui:ui-test-junit4:1.7.0-beta03")
    androidTestImplementation("androidx.compose.ui:ui-test:1.7.0-beta03")
    androidTestImplementation("androidx.compose.ui:ui-test-junit4:1.7.0-beta03")

    implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.2")
    implementation("androidx.lifecycle:lifecycle-viewmodel-savedstate:2.8.2")
    implementation("androidx.lifecycle:lifecycle-livedata-ktx:2.8.2")
    implementation("androidx.lifecycle:lifecycle-runtime-compose:2.8.2")
    implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.8.2")

    //Splash screen library
    implementation("androidx.core:core-splashscreen:1.0.1")

    //Android JetPack DataStore
    implementation("androidx.datastore:datastore-preferences:1.1.1")

    //Retrofit and GSON
    implementation("com.squareup.retrofit2:retrofit:2.11.0")
    implementation("com.squareup.retrofit2:converter-gson:2.11.0")
    implementation("com.squareup.okhttp3:logging-interceptor:5.0.0-alpha.14")

    //Import Hilt Dependency Injection
    implementation("com.google.dagger:hilt-android:2.51.1")
    kapt("com.google.dagger:hilt-compiler:2.51.1")
    implementation("androidx.hilt:hilt-navigation-compose:1.2.0")

    // Import Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)
    implementation(platform("com.google.firebase:firebase-bom:33.1.0"))
    // Firebase Cloud Messaging
    implementation("com.google.firebase:firebase-messaging")

    // For an optimal experience using FCM, add the Firebase SDK
    // for Google Analytics. This is recommended, but not required.
    // When using the BoM, don't specify versions in Firebase dependencies
    implementation("com.google.firebase:firebase-analytics")

    //This library is used for showing and scanning QR Codes
    implementation("com.google.zxing:core:3.5.3")

    implementation(project(":shared"))
}

Ok, I've managed to exclude the androix.tv.foundation library. I can tell you more in about 3 days time from now.

I don't think androidx.tv.foundation is related here, likely it is a leak caused by vector composition.

Would you be able to provide the icon that is animating here to help reproduce it locally?

Sure, how can I share it with (only) you?

It seems like rememberAnimatedVectorPainter is active even if it is not being drawn / used.

A probable workaround is to do this:

                painter = if (!started) {
                    painterResource(
                        id = R.drawable.ic_run_matchface
                    )
                } else {
                    rememberAnimatedVectorPainter(animatedImageVector = runAnimIcon, atEnd = atEnd)
                },

Not sure I'm seeing the workaround here other than that the animation stops. Is that what you're trying to do? The icon is only 700ms or so long and the idea is that it needs to be repeated over and over again. I've noticed that getting a smooth transition from the animation reaching its end to restart is not that perfect. It would be better if compose would have a built-in option just to keep it repeating indefinitely or for x times or so. Just as there was in the Views system. Now I have to trick it like I did to get a smooth continuous animation.

And eventually with whatever workaround, there should be no memory leaks.

I can share the icon with you, but I'm not keen to share it with the whole world. Let me know how I can do that.

Sorry for the confusion, I meant moving rememberAnimatedVectorPainter inside else block rather than hoisting it outside. I think it should result in the same result as before but will only start animating after started condition has switched.

Obviously, we want the memory leak to be fixed regardless. You can upload the icon to google drive and share with ashikov@google.com if that works for you.

I've just send you two files. I forgot to mention that I have another icon with the same config. That is only shown when the systen detects that there is no network. Also, the aniomation is kicked off with a suspend function. Maybe there is a better way of doing this, but I couldn't find it.

    var atEndNoNetwork by remember { mutableStateOf(false) }
    val noNetworkAnimIcon = AnimatedImageVector.animatedVectorResource(R.drawable.ic_no_network)
    val noNetworkAnimIconPainter1 = rememberAnimatedVectorPainter(animatedImageVector = noNetworkAnimIcon, atEnd = atEndNoNetwork)
    val noNetworkAnimIconPainter2 = rememberAnimatedVectorPainter(animatedImageVector = noNetworkAnimIcon, atEnd = !atEndNoNetwork)

    val isRunning by remember { mutableStateOf(true) }
    suspend fun runAnimation() {
        while (isRunning) {
            delay(714)
            atEnd = !atEnd
        }
    }

    suspend fun noNetworkAnimation() {
        while (isRunning) {
            delay(3500)
            atEndNoNetwork = !atEndNoNetwork
        }
    }

It seems like the bug is in MutableObjectIntMap implementation. In the attached heap dump, the RecomposeScopeImpl#trackedInstances size is 1, but capacity is /very/ large.

Did you find the rootcause yet?

Yeah, I found the cause, the bugfix is pending.

Regression test:

    @Test
    fun insertManyRemoveMany() {
        val map = MutableScatterMap<Int, String>()

        for (i in 0..1000000) {
            map[i] = i.toString()
            map.remove(i)
            assertTrue(map.capacity < 16, "Map grew larger than 16 after step $i")
        }
    }

Nice! Just let me know what I need to do to repeat my test with the bugfix in place.

Hey, the issue should be fixed now and I will cherry-pick it to the next beta/rc release.

You can test it with the latest snapshot build following instructions at https://androidx.dev/. Make sure to substitute collections artifact with the snapshot version if you will do so.

Thanks! Hopefully I won't encounter any additional bugs. I'll wait for the next Beta to come out. If you can let me know in which Beta it will arrive, that would be nice. Any idea how long that will take?

Quick note, this won't be included in the next beta since we need to release a stable collection artifact first. I cherry-picked this change into collections 1.4.1 which should be released within next few weeks.

Thank you for the update. Just let me know when it's there for me to test.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.collection:collection:1.4.1
• androidx.collection:collection-iosarm64:1.4.1
• androidx.collection:collection-iossimulatorarm64:1.4.1
• androidx.collection:collection-iosx64:1.4.1
• androidx.collection:collection-jvm:1.4.1
• androidx.collection:collection-linuxx64:1.4.1
• androidx.collection:collection-macosarm64:1.4.1
• androidx.collection:collection-macosx64:1.4.1

Hi, thank you for the update. I've checked, but this is not a dependency I have in my build.gradle.kts file. Is it something I can test?

Hi, this is a transitive dependency from runtime, so you can add version 1.4.1 to your dependency list if you want to test.

Hi, thank you for your explanation. I've included the 1.4.1 release to the dependency list and I need to test it. I'm away for a few days and this takes some time (at least 82 hours of running, with me present). So I think I can come back to you within 3 weeks tops, maybe sooner.

After running my App for more than 1,5 week without any crashes, the issue seems to be fixed! Thank you for the efforts.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.collection:collection:1.5.0-alpha01
• androidx.collection:collection-iosarm64:1.5.0-alpha01
• androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01
• androidx.collection:collection-iosx64:1.5.0-alpha01
• androidx.collection:collection-jvm:1.5.0-alpha01
• androidx.collection:collection-linuxarm64:1.5.0-alpha01
• androidx.collection:collection-linuxx64:1.5.0-alpha01
• androidx.collection:collection-macosarm64:1.5.0-alpha01
• androidx.collection:collection-macosx64:1.5.0-alpha01
• androidx.collection:collection-tvosarm64:1.5.0-alpha01
• androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01
• androidx.collection:collection-tvosx64:1.5.0-alpha01
• androidx.collection:collection-watchosarm32:1.5.0-alpha01
• androidx.collection:collection-watchosarm64:1.5.0-alpha01
• androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01
• androidx.collection:collection-watchosx64:1.5.0-alpha01

Just wanted to let you know that after some long testing I come to the conclusion that if I don't include the transitive dependency mentioned below, the crash still occurs after approx. 82 hours.

implementation("androidx.collection:collection-ktx:1.4.3")

Yes, this is a known issue, the dependency was not picked up by 1.7 release branch.

Hello, when will this be released if it wasn't picked up by 1.7 branch but it is marked as fixed?

The bug was in collections, and it should be available in the latest stable release

Compose will depend on the newer version starting from 1.8.