Navigation Compose - Predictive back transition zorder inconsistency [345993681]

Fixed

Bug

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Jun 9, 2024 09:30AM

Component used: Navigation

Version used: 2.8.0-beta02

Devices/Android versions reproduced on:

Pixel 8 Pro / Android 15 Beta build AP31.240426.023.B4
Pixel 6a emulator / Android 14

Details

This issue occurs when doing simple navigation using compose navigation to build a stack and then pop items using the back gesture with predictive back.

When a back gesture is in progress, sometimes the predictive back transition animation incorrectly shows the destination that will be popped behind the next destination that will be moved to top of the stack.

This does not seem to occur when the same transitions are triggered without a back gesture, either by device back button, or by programmatically popping the stack.

I haven't narrowed down the exact scenario this does and doesn't occur in, but it has been highly reproducible. See attached recording of the below sample app.

Sample project

https://github.com/MrNope/navigation-compose-animation-zindex-bug-demo

Steps to reproduce in sample project:

Run the app on a device with predictive back animation enabled
Tap "Open B" to push a screen onto the stack
Start a back gesture

Expected result

topmost screen on the stack begins to animate out, revealing the initial screen as it re-enters

Actual result

initial (bottom) screen on the stack appears in front of top screen as it begins its pop-enter transition, for the duration of the back gesture; top screen on the stack can still be seen following its exit animation in the background behind the initial screen

navigation transition bug.webm

2.8 MB

Download

Comments

jb...@google.com <jb...@google.com> Jun 12, 2024 07:27PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jun 13, 2024 10:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jb...@google.com <jb...@google.com> #3Jun 13, 2024 10:10PM

Marked as fixed.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

pr...@google.com <pr...@google.com> #4Jun 26, 2024 05:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456