Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
il...@google.com <il...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
st...@gmail.com <st...@gmail.com> #4
deleted
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
cl...@google.com <cl...@google.com> #6
Fixed internally, available in navigation 2.8.2
.
pr...@google.com <pr...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.annotation:annotation-wasm-js:1.9.0-rc01
androidx.annotation:annotation-watchosdevicearm64:1.9.0-rc01
androidx.navigation:navigation-common:2.8.2
androidx.navigation:navigation-compose:2.8.2
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.9.0-alpha01
androidx.navigation:navigation-compose:2.9.0-alpha01
Description
Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: Any
After migrating to use the new APIs, the last step for me was to go ahead and implement all the right
typeMap: Map<KType, @JvmSuppressWildcards NavType<*>>
to pass into my destinations. The stacktrace for those looked something like this:But the problem is that until the last point where it does lead me to the right place (at
com.hedvig.android.app.navigation.HedvigNavHostKt.HedvigNavHost$lambda$56$lambda$55(HedvigNavHost.kt:99)
) from that point and up, all the references to my own code are to lines that do not match my real project. For exampleHomeGraph.kt:82
points to line "82" but the entire file is 71 lines.I am not sure where this mismatch is happening, but it's making fixing the type maps a very slow job as I need to now go and manually check every single destination and manually deduce if it needs a type-map or not.