Exception for missing NavTypes with the new type-safe APIs points to lines of code which are not matching the real source code [346264232]

Fixed

Bug

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Jun 10, 2024 03:52PM

Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: Any

After migrating to use the new APIs, the last step for me was to go ahead and implement all the right typeMap: Map<KType, @JvmSuppressWildcards NavType<*>> to pass into my destinations. The stacktrace for those looked something like this:

java.lang.IllegalArgumentException: Cannot cast sections of type kotlin.collections.ArrayList to a NavType. Make sure to provide custom NavType for this argument.
at androidx.navigation.serialization.RouteSerializerKt.computeNavType(RouteSerializer.kt:166)
at androidx.navigation.serialization.RouteSerializerKt.generateRoutePattern(RouteSerializer.kt:61)
at androidx.navigation.serialization.RouteSerializerKt.generateRoutePattern$default(RouteSerializer.kt:46)
at androidx.navigation.NavDestinationBuilder.<init>(NavDestinationBuilder.kt:102)
at androidx.navigation.compose.ComposeNavigatorDestinationBuilder.<init>(ComposeNavigatorDestinationBuilder.kt:87)
at com.hedvig.android.feature.home.home.navigation.HomeGraphKt.homeGraph$lambda$3(HomeGraph.kt:158)
at com.hedvig.android.feature.home.home.navigation.HomeGraphKt.$r8$lambda$IIglyxrCdF1JgsxPvTgg8qUr6eM(Unknown Source:0)
at com.hedvig.android.feature.home.home.navigation.HomeGraphKt$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0)
at androidx.navigation.compose.NavGraphBuilderKt.navigation(NavGraphBuilder.kt:417)
at com.hedvig.android.feature.home.home.navigation.HomeGraphKt.homeGraph(HomeGraph.kt:84)
at com.hedvig.android.app.navigation.HedvigNavHostKt.HedvigNavHost$lambda$56$lambda$55(HedvigNavHost.kt:99)
at com.hedvig.android.app.navigation.HedvigNavHostKt.$r8$lambda$4yVibVguIbCzl1wpOzQtD0x6edM(Unknown Source:0)
at com.hedvig.android.app.navigation.HedvigNavHostKt$$ExternalSyntheticLambda44.invoke(D8$$SyntheticClass:0)
at androidx.navigation.compose.NavHostKt.NavHost(NavHost.kt:706)
at com.hedvig.android.app.navigation.HedvigNavHostKt.HedvigNavHost(HedvigNavHost.kt:81)
at com.hedvig.android.app.ui.HedvigAppUiKt$HedvigAppUi$1$2.invoke(HedvigAppUi.kt:63)
at com.hedvig.android.app.ui.HedvigAppUiKt$HedvigAppUi$1$2.invoke(HedvigAppUi.kt:62)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:118)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at com.hedvig.android.app.ui.NavigationSuiteKt.NavigationSuite-W8DTaGw(NavigationSuite.kt:56)
at com.hedvig.android.app.ui.HedvigAppUiKt$HedvigAppUi$1.invoke(HedvigAppUi.kt:56)
at com.hedvig.android.app.ui.HedvigAppUiKt$HedvigAppUi$1.invoke(HedvigAppUi.kt:55)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.material3.SurfaceKt$Surface$1.invoke(Surface.kt:134)
at androidx.compose.material3.SurfaceKt$Surface$1.invoke(Surface.kt:115)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:380)
at androidx.compose.material3.SurfaceKt.Surface-T9BRK9s(Surface.kt:112)
at com.hedvig.android.app.ui.HedvigAppUiKt.HedvigAppUi(HedvigAppUi.kt:51)
at com.hedvig.android.app.ui.HedvigAppKt$HedvigApp$1$2.invoke(HedvigApp.kt:103)
at com.hedvig.android.app.ui.HedvigAppKt$HedvigApp$1$2.invoke(HedvigApp.kt:102)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:401)
at com.hedvig.android.app.ui.HedvigAppKt$HedvigApp$1.invoke(HedvigApp.kt:102)
at com.hedvig.android.app.ui.HedvigAppKt$HedvigApp$1.invoke(HedvigApp.kt:84)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:109)
at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35)
at com.hedvig.android.app.ui.HedvigAppKt$HedvigTheme$1$1.invoke(HedvigApp.kt:128)

But the problem is that until the last point where it does lead me to the right place (at com.hedvig.android.app.navigation.HedvigNavHostKt.HedvigNavHost$lambda$56$lambda$55(HedvigNavHost.kt:99)) from that point and up, all the references to my own code are to lines that do not match my real project. For example HomeGraph.kt:82 points to line "82" but the entire file is 71 lines.

I am not sure where this mismatch is happening, but it's making fixing the type maps a very slow job as I need to now go and manually check every single destination and manually deduce if it needs a type-map or not.

Comments

st...@gmail.com <st...@gmail.com> #2Jun 10, 2024 04:05PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

il...@google.com <il...@google.com> #3Jun 10, 2024 04:14PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

st...@gmail.com <st...@gmail.com> #4Jun 11, 2024 02:45PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

jb...@google.com <jb...@google.com> Sep 16, 2024 08:25PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #5Sep 19, 2024 02:30AM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

cl...@google.com <cl...@google.com> #6Sep 19, 2024 06:44AM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

pr...@google.com <pr...@google.com> #7Oct 2, 2024 05:37PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

na...@google.com <na...@google.com> #8Oct 16, 2024 05:48PM

Thank you, I'll try it and check.