IssueTracker

You should not need to include any enum type in the typeMap - if you find that necessary, it might be helpful to file a separate issue for that.

You didn't include the full stack trace of the crash - can you include that here, along with a sample project that reproduces your issue?

Stacktrace for this release mode issue (with -dontobfuscate)

                 java.lang.IllegalArgumentException: Cannot cast priority of type dev.hrach.navigation.demo.Destinations.IssueEnum.Priority to a NavType. Make sure to provide custom NavType for this argument.
                 	at androidx.navigation.serialization.RouteSerializerKt.computeNavType(Unknown Source:105)
                 	at androidx.navigation.serialization.RouteSerializerKt.generateRoutePattern(Unknown Source:51)
                 	at androidx.navigation.serialization.RouteSerializerKt.generateRoutePattern$default(Unknown Source:13)
                 	at androidx.navigation.NavDestinationBuilder.<init>(SourceFile:0)
                 	at androidx.navigation.compose.ComposeNavigatorDestinationBuilder.<init>(Unknown Source:0)
                 	at dev.hrach.navigation.demo.NavHostKt.NavHost$lambda$0(Unknown Source:524)
                 	at dev.hrach.navigation.demo.NavHostKt.$r8$lambda$FgKxCDk5rO8iiazuePYjqgmHY-Y(SourceFile:0)
                 	at dev.hrach.navigation.demo.NavHostKt$$ExternalSyntheticLambda0.invoke(SourceFile:0)
                 	at androidx.navigation.compose.NavHostKt.NavHost(SourceFile:0)
                 	at dev.hrach.navigation.demo.NavHostKt.NavHost(Unknown Source:73)

Repro: https://github.com/hrach/navigation-compose/commit/6342c95cc0c57a5e8598f92241d59a658c538071

I will create a separate issue for the enum.

Hey any update here? And can you point me to the separate issue?

Enum support is tracked here: https://issuetracker.google.com/issues/346475493

Hi Jan - can you clarify repro steps? I'm on the issues-enum-release-mode branch running the demo app as is and don't see any crashes.

I do see this error when I remove typeMap input

Cannot cast priority of type dev.hrach.navigation.demo.Destinations.IssueEnum.Priority to a NavType. Make sure to provide custom NavType for this argument.

but that is fixed separately in https://issuetracker.google.com/issues/346475493

What was the other crash you're seeing and whats the steps to repro it?

I`m sorry, my report here is terrible. So let me try again:

This is an issue about ENUM in Release - minified/R8 mode.
I am creating a custom typemap and defining its navtype, though, it doesn`t work in one specific case - when the enum does not have the @Serializable annotation.

To reproduce:

1. checkout the code
2. switch to release build type
3. remove the Serializable annotation from Destinations.IssueEnum type. Adding it back will make it work.

Thanks! I can reproduce it now.

The issue stems from how we match custom NavTypes by calling serializerOrNull(kType):

1. with @Serializable on enum class Priority, calling serializerOrNull returns the built-in EnumSerializer. This is perhaps expected - the built in serializer is prioritized.
2. without @Serializable, calling serializerOrNull returns a newly generated serializer instead of the built-in EnumSerializer, which is unexpected.

I'll have to reach out to JB for more info on case 2. Although, the future solution to https://issuetracker.google.com/issues/348468840 should allow us to circumvent this issue altogether.

In the meantime, safe args built-in support for EnumType has been added in https://issuetracker.google.com/issues/346475493 and will be released on Aug 7th, which will temporarily alleviate the problem of enum arguments. Nevertheless, custom Enum NavType should still be supported.