Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
pr...@google.com <pr...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
eb...@gmail.com <eb...@gmail.com> #6
Maybe something similar exists also on shared content transition? I've just opened a file
(just the note the fix here is indifferent about my issue as could see it both in beta03 and beta04)
(and I'll understand if you see that issue as invalid as it's my duty to replicate that locally first even though it's GitHub Actions and don't have access to the machine, still)
Description
Component used: Navigation
Version used: 2.8.0-beta02
Devices/Android versions reproduced on: VanillaIceCream(AP31.240426.023.B4) with Predictive back in developer options turned on
With a new project generated from Android Studio, I added
android:enableOnBackInvokedCallback="true"
and I bumped all dependencies to the latest available, where the relevant ones are:Then MainActivity looks like this:
And doing this interaction:
Noticed this bug as I could not longer navigate in my codebase since I got my nav events wrapped in
dropUnlessResumed {}
which at that point means you're dropping all of those those.