Paging 3 crash if PagingSource is invalidated while RecycleView is scrolling [347649763]

Duplicate

of 343124454

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Jun 17, 2024 12:49PM

Hi, I have been struggling with this for some time and finally decided to post there to make sure it is not me doing something wrong.

Please see attached POC, screen recording and sample crash log in the attached file. Project is created with Android Studio Koala Feature Drop | 2024.1.2 Canary 5

Issue:

Attached project demonstrates crash with a Room database but I use custom PagingSource because I also use Paging 3 with content providers such as call log and contacts.

Due to my my project's needs, I need to invalidate PagingSource from outside every now and then. One of the reasons for that is inserting adverts to certain locations.

I created Invalidator interface which InvalidatingPagingSource that extends PagingSource uses. InvalidatingPagingSource in return extended by my custom paging source and ViewModel is provided with an instance of Invalidator so it can call Invalidator.invalidateNow() when it needs to invalidate the paging source.

This setup works fine when data is on screen and no scrolling is being done. However, if invalidation happens while user is scrolling app crashes with

java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 115(offset:115).state:207 androidx.recyclerview.widget.RecyclerView{fdd315c VFED.V... ......ID 48,48-1296,2800 #7f080143 app:id/notesRecycler}, adapter:com.example.paging3.NotesAdapterPaging@52fd8c2, layout:androidx.recyclerview.widget.LinearLayoutManager@17696d3, context:com.example.paging3.MainActivity@1d73791
at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6364)
at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6300)
at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6296)
at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2330)
at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1631)
at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1591)
at androidx.recyclerview.widget.LinearLayoutManager.scrollBy(LinearLayoutManager.java:1395)
at androidx.recyclerview.widget.LinearLayoutManager.scrollVerticallyBy(LinearLayoutManager.java:1136)
at androidx.recyclerview.widget.RecyclerView.scrollStep(RecyclerView.java:1972)
at androidx.recyclerview.widget.RecyclerView$ViewFlinger.run(RecyclerView.java:5476)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1339)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1348)
at android.view.Choreographer.doCallbacks(Choreographer.java:952)
at android.view.Choreographer.doFrame(Choreographer.java:878)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1322)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:205)
at android.os.Looper.loop(Looper.java:294)
at android.app.ActivityThread.main(ActivityThread.java:8177)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

I am not sure if I am being thick but, when I check the source of tryGetViewHolderForPositionByDeadline I see that it does these checks:

if (position < 0 || position >= mState.getItemCount()) {    
throw new IndexOutOfBoundsException("Invalid item position " + position    
+ "(" + position + "). Item count:" + mState.getItemCount()
+ exceptionLabel()); 
}

According to log however, position 115(offset:115) falls in to state:207 so crash should not happen. What am I missing?

Notes:

Please be patient after first lunch as app creates 5K sample notes.
You may need to scroll fast a couple of times to create the crash.

poc.zip

1.4 MB

Download

Comments

ba...@gmail.com <ba...@gmail.com> #2Jun 18, 2024 05:42AM

In SystemJobService, it can expect null, and able to tolerance null from WorkManagerImpl.getInstance, due to auto-backup reason.

@Override
public void onCreate() {
super.onCreate();
mWorkManagerImpl = WorkManagerImpl.getInstance(getApplicationContext());
if (mWorkManagerImpl == null) {
// This can occur if...
// 1. The app is performing an auto-backup. Prior to O, JobScheduler could erroneously
// try to send commands to JobService in this state (

b/32180780

). Since neither
// Application#onCreate nor ContentProviders have run, WorkManager won't be
// initialized. In this case, we should ignore all JobScheduler commands and tell it
// to retry.
But, current WorkManagerImpl.getInstance(Context context) implementation is that, it will never return null but throw IllegalStateException.

Isn't there's conflict among these 2 SystemJobService.onCreate logic, and WorkManagerImpl.getInstance logic?

ni...@gmail.com <ni...@gmail.com> #3Jun 18, 2024 07:34AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e14104eb7008f82edd50b37e16bd119b307e0554
Author: Sumir Kataria <sumir@google.com>
Date: Mon Jun 24 10:50:57 2019

Fix for JobScheduler calls when backup is in progress.

The original fix (ag/Ia1604b7c4b98f6b31869e1161a0c1efce7fe46f2) relied
on a null-check, but the new version of WorkManager.getInstance(Context)
with the Context param doesn't return null; it throws an Exception. This
CL updates the three places where we explicitly check for the return value
internally:

1. SystemJobService (the main place where this would manifest)
2. RescheduleReceiver
3. WorkManagerTestInitHelper (for consistency)

Fixes: 135858602
Test: Ran existing tests
Change-Id: Ia232869712d0c78fd80e91d0a863b8c50a080400

M work/workmanager-testing/src/main/java/androidx/work/testing/WorkManagerTestInitHelper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/RescheduleReceiver.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java

https://android-review.googlesource.com/988026

https://goto.google.com/android-sha1/e14104eb7008f82edd50b37e16bd119b307e0554

ba...@gmail.com <ba...@gmail.com> #4Jun 19, 2024 02:03PM

Thanks you so much for the speedy fixed!

May I know when will it be ready for production? As, currently, this IllegalStateException is impacting our users.

ni...@gmail.com <ni...@gmail.com> #5Jun 19, 2024 02:36PM

Hello, please look for this later in the week. If you want to work around this bug specifically and don't need on-demand initialization, you can use the old (deprecated) WorkManager.getInstance() method for now.

lo...@gmail.com <lo...@gmail.com> #6Jun 23, 2024 11:53AM

Hello. Thanks for respond. I surely will keep a pair of eye on the next release :)

Yes. We don't need on-demand initialization. May I know how does using old (deprecated) WorkManager.getInstance() in our app code, able to bypass this problem? Isn't the crash is origin from library internal SystemJobService?

We once thinking to bypass this problem, by switching back to Version 2.0.1 (The version just before WorkManager.getInstance(Context) is introduced). However, we notice Room version is being changed in between. Downgrading WorkManager version, might cause additional SQLite problem.

lo...@gmail.com <lo...@gmail.com> #7Jun 23, 2024 11:55AM

Sorry, you are correct that moving to the deprecated method will not help you here. I would advise waiting for the release later this week. And thank you very much for finding this bug and doing the research to find the underlying issue.

I am curious: do you actually have reports of this bug on Android 9? It should've been fixed in the platform layer at that point. If possible, can you share any Android 9 specific logs/bugreports/stacktraces with device models?

cl...@google.com <cl...@google.com> Jun 26, 2024 10:56PM

Status: Duplicate of

343124454