Fixed
Status Update
Comments
gr...@google.com <gr...@google.com>
gr...@google.com <gr...@google.com>
st...@google.com <st...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
to...@gmail.com <to...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
st...@google.com <st...@google.com> #4
deleted
to...@gmail.com <to...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 7f4323b11a070222301ce583411897cffb877848
Author: stevebower <stevebower@google.com>
Date: Tue Sep 17 15:14:21 2024
Added Shape and Height to CardDefaults
Also added a demo of a base Card with vertically centered content.
Bug: 347649765
Test: Manual testing
Relnote: "We have added CardDefaults.Shape and CardDefaults.Height, which (being tokens) were otherwise private to developers using the library."
Change-Id: I1594a5907bee183eb2183dec2e85e791c6dda3be
M wear/compose/compose-material3/api/current.txt
M wear/compose/compose-material3/api/restricted_current.txt
M wear/compose/compose-material3/integration-tests/src/main/java/androidx/wear/compose/material3/demos/CardDemo.kt
M wear/compose/compose-material3/src/main/java/androidx/wear/compose/material3/Card.kt
https://android-review.googlesource.com/3269992
Branch: androidx-main
commit 7f4323b11a070222301ce583411897cffb877848
Author: stevebower <stevebower@google.com>
Date: Tue Sep 17 15:14:21 2024
Added Shape and Height to CardDefaults
Also added a demo of a base Card with vertically centered content.
Bug: 347649765
Test: Manual testing
Relnote: "We have added CardDefaults.Shape and CardDefaults.Height, which (being tokens) were otherwise private to developers using the library."
Change-Id: I1594a5907bee183eb2183dec2e85e791c6dda3be
M wear/compose/compose-material3/api/current.txt
M wear/compose/compose-material3/api/restricted_current.txt
M wear/compose/compose-material3/integration-tests/src/main/java/androidx/wear/compose/material3/demos/CardDemo.kt
M wear/compose/compose-material3/src/main/java/androidx/wear/compose/material3/Card.kt
st...@google.com <st...@google.com>
pr...@google.com <pr...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-material3:1.0.0-alpha26
Description
Component used: Wear M3 Card Version used: latest master snapshot.
Due tohttps://android-review.googlesource.com/c/platform/frameworks/support/+/3103263 that introduce a minheight but also force an intrinsic min we now have no way to center small text inside the Card.
The normal hack would have been to wrap the internal card content with a box and height Intrinsic.Max but this does not work (Probably due to the forced
.height(IntrinsicSize.Min)
)So we need to wrap in a box with a minheight of the proper height but the token is private so we need to hardcode the 64.dp and if there's some new changes to the design it won't be applied properly on the clients.
The need is simple inside the card show a small text that should be centered and not forced at the top with tons of empty space below.