Crash when using AndroidFragment Compose API [347706985]

Fixed

Bug

Status Update

No update yet.

Description

ck...@linkedin.com

created issue #1

Jun 17, 2024 09:13PM

Component used: Fragment Version used: 1.8.0

Devices/Android versions reproduced on: all

When using AndroidFragment() inside a Fragment, FragmentManager will throw an exception when re-creating the parent Fragment's View hierarchy (it cannot find the Child Fragment's View in the ComposeView).

This is reproduced in this project: https://github.com/cckroets/AndroidFragmentBug with the following setup:

MainActivity (FragmentContainerView)
- FirstTopLevelFragment (ComposeView)
-- NestedInComposeFragment (AndroidFragment)
- SecondTopLevelFragment (ViewBinding)

Navigating to First -> Second is fine. But pressing back, and recreating FirstTopLevelFragment will crash the app, due to no View found for NestedInComposeFragment.

Process: com.example.myapplication, PID: 3643
java.lang.IllegalArgumentException: No view found for id 0x708875b7 (unknown) for fragment NestedInComposeFragment{9df0b2b} (ae4356e1-9543-4636-8326-0c425188d5bd id=0x708875b7 tag=1887991223)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:559)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:278)
at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1663)
at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3247)
at androidx.fragment.app.FragmentManager.dispatchViewCreated(FragmentManager.java:3158)
at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3149)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:600)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:278)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2143)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2047)
at androidx.fragment.app.FragmentManager.popBackStackImmediate(FragmentManager.java:1095)
at androidx.fragment.app.FragmentManager.popBackStackImmediate(FragmentManager.java:984)
at androidx.fragment.app.FragmentManager.handleOnBackPressed(FragmentManager.java:900)
at androidx.fragment.app.FragmentManager$1.handleOnBackPressed(FragmentManager.java:570)
at androidx.activity.OnBackPressedDispatcher.onBackPressed(OnBackPressedDispatcher.kt:276)
at com.example.myapplication.SecondFragment.onViewCreated$lambda$0(SecondFragment.kt:36)
at com.example.myapplication.SecondFragment.$r8$lambda$D56Ez4I3ChfufRinJh-Sz7jy9iI(Unknown Source:0)
at com.example.myapplication.SecondFragment$$ExternalSyntheticLambda0.onClick(D8$$SyntheticClass:0)
at android.view.View.performClick(View.java:7448)

Comments

ag...@wayfair.com <ag...@wayfair.com> #2Jun 19, 2024 02:34PM

Thanks for the report. I was puzzled.

Message last modified on Jun 19, 2024 02:35PM

[Deleted User] <[Deleted User]> #3Jun 22, 2024 02:03AM

The same for me. Android 4.0.4.

TestComposableFragment.zip

977 KB

Download

jb...@google.com <jb...@google.com> #4Jun 24, 2024 04:30PM

This is intentional to reduce complexity of Spinner's API and implementation. Consider using a full-blown ListView in a dialog instead.

ck...@linkedin.com <ck...@linkedin.com> #5Jun 24, 2024 05:06PM

Here is a proposed workaround:

http://stackoverflow.com/questions/16398468/why-is-android-recycling-the-wrong-view-type-in-my-spinneradapter

il...@google.com <il...@google.com> Jul 8, 2024 11:39PM

Assigned to il...@google.com.

ap...@google.com <ap...@google.com> #6Jul 9, 2024 08:43PM

I just spent 3 hours on this issue and I disagree that it is "working as intended". If you want to make developers happy, fail fast.

Spinner$DropDownAdapter wraps the client's adapter and shadows getItemViewType() and getViewTypeCount() and simply returns constants. This will never work as intended if the inner adapter has more view types.

I suggest the DropDownAdapter constructor asserts if adapter.getViewTypeCount() != 1.

il...@google.com <il...@google.com> #7Jul 9, 2024 08:48PM

Marked as fixed.

THIS NEEDS TO BE FIXED.

ap...@google.com <ap...@google.com> #8Jul 9, 2024 09:49PM

What's going on with this issue?