CriticalPathAnalyzerTest.testCriticalPathAnalyzerOnNoOpBuild() has invalid assertThat usage [347769330]

Assigned

Bug

No update yet.

sp...@google.com

created issue #1

Jun 17, 2024 10:05PM

In CriticalPathAnalyzerTest.testCriticalPathAnalyzerOnNoOpBuild(), the following lines aren't testing anything:

assertThat(results.getTasksDeterminingBuildDuration().isEmpty())
assertThat(results.getPluginsDeterminingBuildDuration().isEmpty())

The test fails (maybe flaky?) if I change those lines to the following:

assertThat(results.getTasksDeterminingBuildDuration().isEmpty()).isTrue()
assertThat(results.getPluginsDeterminingBuildDuration().isEmpty()).isTrue()

Reassigned to an...@google.com.

Reassigned to ml...@google.com.

Issue 347769330