[r8 8.5] vertical class merger causing runtime NPE [348202700]

Verified

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Jun 20, 2024 09:28AM

After upgrading to r8 8.5, our app crashed at runtime. Through binary search, I can confirm that this problem is caused by this.

com.android.tools:r8:b4a9c8e75bc6bb86efef1f3a606f6e8ecd341136 // ×
com.android.tools:r8:9112b49cfb831c541d0d0603a458e143bb9ab6d0 // √
com.android.tools:r8:8.5.24 // ×
com.android.tools:r8:8.4.41 // √

demo step:

unzip
gradle :app:assembleRelease
adb install app/build/outputs/apk/release/app-release.apk

android-demo-r8-glide.zip

Comments

ch...@google.com <ch...@google.com> Jun 20, 2024 09:30AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Jun 21, 2024 12:01PM

deleted

Message last modified on Jun 21, 2024 12:03PM

ch...@google.com <ch...@google.com> #3Jun 21, 2024 12:13PM

We have fixed this issue in AGP 8.5.0-beta01: https://android.googlesource.com/platform/tools/base/+/880dbb64c2f0cfd7de9452feed920bb8fc08ff7a

ap...@google.com <ap...@google.com> #4Jun 25, 2024 11:53AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala | 2024.1.1 Canary 8
Android Gradle Plugin 8.5.0-alpha08

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #5Jun 25, 2024 04:38PM

https://android.googlesource.com/platform/tools/base/+/880dbb64c2f0cfd7de9452feed920bb8fc08ff7a

ap...@google.com <ap...@google.com> #6Jun 26, 2024 07:43AM

Project: r8
Branch: main

commit 179a24a166585e68bf22c1b95480f6d7b41879bd
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Wed Jun 26 08:49:25 2024

Update vertical class merger test expectations

Bug:

b/348202700

Change-Id: I401aa09c7db76d95ab1c2650b63608e062824a91

M src/test/java/com/android/tools/r8/classmerging/vertical/ClassesHaveBeenMergedTest.java
M src/test/java/com/android/tools/r8/classmerging/vertical/VerticalClassMergerTest.java

https://r8-review.googlesource.com/94000

ap...@google.com <ap...@google.com> #7Jun 26, 2024 08:49AM

Marked as fixed.

Project: r8
Branch: main

commit adcef8fbc38b7a8854bec2a56d8dae960ddb3b2c
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Wed Jun 26 08:51:54 2024

Account for collisions in presence of field shadowing in lens rewriting

Fixes:

b/348202700

Change-Id: I0a861eb50819b17d902abe4bf450590e9eedc7c3

M src/main/java/com/android/tools/r8/graph/lens/NestedGraphLens.java
M src/main/java/com/android/tools/r8/verticalclassmerging/VerticalClassMergerGraphLens.java
M src/main/java/com/android/tools/r8/verticalclassmerging/VerticalClassMergerPolicyScheduler.java
D src/main/java/com/android/tools/r8/verticalclassmerging/policies/NoShadowedFieldsPolicy.java
M src/test/java/com/android/tools/r8/classmerging/vertical/ClassesHaveBeenMergedTest.java
M src/test/java/com/android/tools/r8/classmerging/vertical/VerticalClassMergerTest.java

https://r8-review.googlesource.com/93891

do...@gmail.com <do...@gmail.com> #8Jun 27, 2024 03:39AM

Verified. Looking forward to seeing this backported to 8.5

ap...@google.com <ap...@google.com> #9Jun 27, 2024 07:50AM

Project: r8
Branch: 8.5

commit f130b5c07bc36acb9a22bbd9158c88dc835711eb
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Wed Jun 26 20:39:53 2024

Disable merging in presence of shadowed fields

Bug:

b/348202700

Change-Id: Ib36655cb4c590fb75afa4f3aa54ff98f75632ef4

M src/main/java/com/android/tools/r8/verticalclassmerging/VerticalClassMergerPolicyScheduler.java
A src/main/java/com/android/tools/r8/verticalclassmerging/policies/NoShadowedFieldsPolicy.java
M src/test/java/com/android/tools/r8/classmerging/vertical/ShadowedNonReboundFieldVerticalClassMergingTest.java

https://r8-review.googlesource.com/94062

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:50AM

Project: r8
Branch: 8.5

commit af33bd12e519b38cfecdbe9141e2fc51b18e3925
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Wed Jun 26 20:39:45 2024

Reproduce incorrect rewrite with non-rebound access to shadowed field

Bug:

b/348202700

Change-Id: Ib8196e439981375d4d26e750415a358e59e9a7e6

A src/test/java/com/android/tools/r8/classmerging/vertical/ShadowedNonReboundFieldVerticalClassMergingTest.java

https://r8-review.googlesource.com/94080

ap...@google.com <ap...@google.com> #11Jun 27, 2024 07:50AM

Project: r8
Branch: 8.5

commit 090d36dc568ced236c0df2449259b9d9f0ac8231
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Thu Jun 27 06:01:19 2024

Update vertical class merger test expectations

Bug:

b/348202700

https://r8-review.googlesource.com/94063

ap...@google.com <ap...@google.com> #12Jun 27, 2024 07:50AM

Project: r8
Branch: 8.5

commit 855f13b0c7c1029a9ffb62defb84220bf27f199c
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Thu Jun 27 06:01:54 2024

Version 8.5.29

Bug:

b/348202700

Change-Id: Ia0074ae04716775e254d03d56fd46c656cecdc6a

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/94064

do...@gmail.com <do...@gmail.com> #13Jul 5, 2024 03:36AM

thx, the issue has been fixed after the upgrade.

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #14Jul 24, 2024 08:39PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 Beta 2
Android Gradle Plugin 8.6.0-beta02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #15Aug 9, 2024 12:55AM

The fixes for this issue are now also available in:

Android Studio Koala | 2024.1.1 Patch 2
Android Gradle Plugin 8.5.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 348202700

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> Jun 20, 2024 09:30AM

ch...@google.com <ch...@google.com> #2Jun 21, 2024 12:01PM

ch...@google.com <ch...@google.com> #3Jun 21, 2024 12:13PM

ap...@google.com <ap...@google.com> #4Jun 25, 2024 11:53AM

ap...@google.com <ap...@google.com> #5Jun 25, 2024 04:38PM

ap...@google.com <ap...@google.com> #6Jun 26, 2024 07:43AM

ap...@google.com <ap...@google.com> #7Jun 26, 2024 08:49AM

do...@gmail.com <do...@gmail.com> #8Jun 27, 2024 03:39AM

ap...@google.com <ap...@google.com> #9Jun 27, 2024 07:50AM

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:50AM

ap...@google.com <ap...@google.com> #11Jun 27, 2024 07:50AM

ap...@google.com <ap...@google.com> #12Jun 27, 2024 07:50AM

do...@gmail.com <do...@gmail.com> #13Jul 5, 2024 03:36AM

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

an...@google.com <an...@google.com> #14Jul 24, 2024 08:39PM

an...@google.com <an...@google.com> #15Aug 9, 2024 12:55AM

Add comment

Issue metadata