[r8 8.5] vertical class merger causing runtime NPE [348202700]

Verified

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Jun 20, 2024 09:28AM

After upgrading to r8 8.5, our app crashed at runtime. Through binary search, I can confirm that this problem is caused by this.

com.android.tools:r8:b4a9c8e75bc6bb86efef1f3a606f6e8ecd341136 // ×
com.android.tools:r8:9112b49cfb831c541d0d0603a458e143bb9ab6d0 // √
com.android.tools:r8:8.5.24 // ×
com.android.tools:r8:8.4.41 // √

demo step:

unzip
gradle :app:assembleRelease
adb install app/build/outputs/apk/release/app-release.apk

android-demo-r8-glide.zip

Comments

ch...@google.com <ch...@google.com> Jun 20, 2024 09:30AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Jun 21, 2024 12:01PM

I'm observing the same thing on the Nexus 10.

Message last modified on Jun 21, 2024 12:03PM

ch...@google.com <ch...@google.com> #3Jun 21, 2024 12:13PM

Sleep as Android users who upgraded to 4.3 recently report the same issue. It seems SoundPool looping is broken in 4.3...

ap...@google.com <ap...@google.com> #4Jun 25, 2024 11:53AM

I can approve the issue is reproducible on the 4.3 emulator. Unfortunately no hint in in the logcat related to audio or sound pool which would give further insight. The only think I'm getting releted to SoundPool every time I try using it is:

07-29 12:19:43.844: ERROR/SoundPool(296): error loading /system/media/audio/ui/KeypressReturn.ogg
07-29 12:19:43.864: WARN/AudioService(296): Soundpool could not load file: /system/media/audio/ui/KeypressReturn.ogg
07-29 12:19:43.814: WARN/AudioService(296): Soundpool could not load file: /system/media/audio/ui/Effect_Tick.ogg
07-29 12:19:43.814: ERROR/SoundPool(296): error loading /system/media/audio/ui/Effect_Tick.ogg
...
07-29 12:19:43.864: WARN/AudioService(296): onLoadSoundEffects(), Error -1 while loading samples

ap...@google.com <ap...@google.com> #5Jun 25, 2024 04:38PM

I did try a non -1 looping parameter and it seems even finite looping is broken. Did someone had a chance to look at the 4.3 sources for SoundPool? Thanks.

ap...@google.com <ap...@google.com> #6Jun 26, 2024 07:43AM

Incorrect behaviour also on Nexus 7 since 4.3.

Easy to reproduce, Code nearly as above:

https://play.google.com/store/apps/details?id=nax.naxan.virtualfan
(in Mode Soundpool on 4.3 only one loop is played, on 4.2 it's looping)

Addition:
The code in 4.2.2 looks like looping is done in the native part:

http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/4.2.2_r1/android/media/SoundPool.java/

ap...@google.com <ap...@google.com> #7Jun 26, 2024 08:49AM

Marked as fixed.

I'm having the same problem, loop will only play once :\

do...@gmail.com <do...@gmail.com> #8Jun 27, 2024 03:39AM

[Comment deleted]

ap...@google.com <ap...@google.com> #9Jun 27, 2024 07:50AM

Same here, I've only managed to solve it by using MediaPlayer instead, although I think the looping sounds clunkier.

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:50AM

Got the same problem on Gnex 4.3, can't use the MediaPlayer since I need the setRate Method for car engine pitch modification.
90% of car/bike games on the play store have their engine sound effect broken on 4.3 due to this.

ap...@google.com <ap...@google.com> #11Jun 27, 2024 07:50AM

The same for nexus 7.

ap...@google.com <ap...@google.com> #12Jun 27, 2024 07:50AM

Same for Nexus 4 and Nexus 7 with Android 4.3. Audio in Android is a big mess..... ;/

do...@gmail.com <do...@gmail.com> #13Jul 5, 2024 03:36AM

Same problem on a Nexus 7, both infinite and finite looping are not working. The same code works on a phone running 4.2.2.

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #14Jul 24, 2024 08:39PM