Fixed
Status Update
No update yet.
Comments
da...@well.co
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@well.co
da...@well.co
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d2e708a4b92dd375abb47fead572b4308e72dd1e
Author: Melba Nuzen <mnuzen@google.com>
Date: Fri Jun 28 16:59:28 2024
Send ancestor events for LiveRegion announcements
Prior to this CL, if an ancestor and its descendant both had layout changes, only the descendant would send accessibility events (this was done in aosp/2729277 to minimize number of events sent by Compose).
In the case of a liveRegion activated by a button, if the ancestor value change was triggered by a descendant button being clicked, only the `TYPE_VIEW_CLICKED` event from the descendant was being clicked, even though the ancestor value was also being changed. Without alerting TalkBack that the ancestor value was being changed, LiveRegions were not working properly.
With this fix, `CONTENT_CHANGE_TYPE_SUBTREE` is now sent in addition to `TYPE_VIEW_CLICKED`, fixing the scenario where liveRegion announcements were not being recognized by TalkBack if the change and its trigger were on ancestor/descendant components.
Fixes: 348590026
Test: sendClickedAndChangeSubtree_whenDescendantClicked() and verified with local repro provided in bug
Change-Id: I308d5122947ecc3afbf0dbeb0d96f977d655be8a
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/SemanticsUtils.android.kt
https://android-review.googlesource.com/3151310
Branch: androidx-main
commit d2e708a4b92dd375abb47fead572b4308e72dd1e
Author: Melba Nuzen <mnuzen@google.com>
Date: Fri Jun 28 16:59:28 2024
Send ancestor events for LiveRegion announcements
Prior to this CL, if an ancestor and its descendant both had layout changes, only the descendant would send accessibility events (this was done in aosp/2729277 to minimize number of events sent by Compose).
In the case of a liveRegion activated by a button, if the ancestor value change was triggered by a descendant button being clicked, only the `TYPE_VIEW_CLICKED` event from the descendant was being clicked, even though the ancestor value was also being changed. Without alerting TalkBack that the ancestor value was being changed, LiveRegions were not working properly.
With this fix, `CONTENT_CHANGE_TYPE_SUBTREE` is now sent in addition to `TYPE_VIEW_CLICKED`, fixing the scenario where liveRegion announcements were not being recognized by TalkBack if the change and its trigger were on ancestor/descendant components.
Fixes: 348590026
Test: sendClickedAndChangeSubtree_whenDescendantClicked() and verified with local repro provided in bug
Change-Id: I308d5122947ecc3afbf0dbeb0d96f977d655be8a
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/SemanticsUtils.android.kt
mn...@google.com
Thanks for filing this bug! The patch below should address this issue.
da...@well.co
Thanks for the quick fix!
da...@well.co
Is this going to be in compose 1.8 alpha? Seems like maybe it did not make cutoff to 1.7rc? Is there some way for people outside of google to see what version its going to be in?
se...@google.com
We're past 1.7, evaluating if it makes sense as a cherry-pick to 1.7
se...@google.com
As for how to track something like this - the best bet is the release notes which contains a link to all CLs. That's the final authoritative answer to "what's in a release" (sometimes a few last second cherry-picks or fixes are needed, so hard to predict until the day of the cut)
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui:1.7.2androidx.compose.ui:ui-android:1.7.2androidx.compose.ui:ui-jvmstubs:1.7.2androidx.compose.ui:ui-linuxx64stubs:1.7.2
Description
2023.10.00-alpha01 // broken
2023.09.00-alpha03 // working
Jetpack Compose component(s) used:
LiveRegion
Android Studio Build:
Android Studio Koala | 2024.1.1 Canary 8
Kotlin version:
1.9.0
Steps to Reproduce or Code Sample to Reproduce:
1. Run this project
2. Click on Button
Expected: I would expect it to announce "David" when pressing the button which is a LiveRegion that becomes visible.
Actual: It does not announce the live region.
If you run the exact code but then change the toml file to the
"2023.09.00-alpha03" as mentioned here
It works
Summary:
So either compose changed something and I need to change my live region or its just broke.
I am going to keep digging into this and see if I can give more detail but it appears these dependencies have updated
So compose 1.6.0-alpha04 vs 1.6.0-alpha05 there is the change.
This is a pretty bad bug as any errors are not announced in most apps as they happen or whatever else use case a person has for live region