LiveRegion in compose is broke when updating compose version [348590026]

Fixed

Bug

Status Update

No update yet.

Description

da...@well.co

created issue #1

Jun 21, 2024 06:02PM

Jetpack Compose version:
2023.10.00-alpha01 // broken
2023.09.00-alpha03 // working

Jetpack Compose component(s) used:
LiveRegion
Android Studio Build:
Android Studio Koala | 2024.1.1 Canary 8

Kotlin version:
1.9.0

Steps to Reproduce or Code Sample to Reproduce:

1. Run this project

https://github.com/DavidCorrado/ComposeLiveRegionBug/tree/main
2. Click on Button

Expected: I would expect it to announce "David" when pressing the button which is a LiveRegion that becomes visible.

https://github.com/DavidCorrado/ComposeLiveRegionBug/blob/main/app/src/main/java/com/example/myapplication/MainActivity.kt#L41

Actual: It does not announce the live region.

If you run the exact code but then change the toml file to the
"2023.09.00-alpha03" as mentioned here

https://github.com/DavidCorrado/ComposeLiveRegionBug/blob/main/gradle/libs.versions.toml#L12
It works

Summary:
So either compose changed something and I need to change my live region or its just broke.

I am going to keep digging into this and see if I can give more detail but it appears these dependencies have updated

https://github.com/chrisbanes/compose-bom/compare/v2023.09.00-alpha03...v2023.10.00-alpha01

So compose 1.6.0-alpha04 vs 1.6.0-alpha05 there is the change.

This is a pretty bad bug as any errors are not announced in most apps as they happen or whatever else use case a person has for live region

Comments

da...@well.co <da...@well.co> #2Jun 21, 2024 08:11PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

da...@well.co <da...@well.co> #3Jun 21, 2024 08:26PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

da...@well.co <da...@well.co> #4Jun 21, 2024 08:50PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

je...@google.com <je...@google.com> Jun 24, 2024 11:13PM

Assigned to mn...@google.com.

ap...@google.com <ap...@google.com> #5Jul 8, 2024 06:59PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

mn...@google.com <mn...@google.com> #6Jul 8, 2024 07:00PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

da...@well.co <da...@well.co> #7Jul 8, 2024 07:02PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

da...@well.co <da...@well.co> #8Aug 27, 2024 09:19PM

Yes, this fix is planned to be included in a future 1.7.x release.

se...@google.com <se...@google.com> #9Aug 27, 2024 10:15PM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

se...@google.com <se...@google.com> #10Aug 27, 2024 10:16PM

As for how to track something like this - the best bet is the release notes which contains a link to all CLs. That's the final authoritative answer to "what's in a release" (sometimes a few last second cherry-picks or fixes are needed, so hard to predict until the day of the cut)

na...@google.com <na...@google.com> #11Sep 18, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.7.2
androidx.compose.ui:ui-android:1.7.2
androidx.compose.ui:ui-jvmstubs:1.7.2
androidx.compose.ui:ui-linuxx64stubs:1.7.2