[r8 8.5]r8 horizontal class merge causes verify error on Android5 when disable api modeling [348785664]

Verified

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Jun 23, 2024 07:03AM

void S.a.run(): [0x31] couldn't find method android.view.WindowManager.getCurrentWindowMetrics ()Landroid/view/WindowMetrics;
void S.a.run() failed to verify: void S.a.run(): [0x16] expected to be within a catch-all for an instruction where a monitor is held
java.lang.VerifyError: Verifier rejected class S.a due to bad method void S.a.run()

env: Nexus5 with Android5.1.1

demo step:

unzip
gradle :app:assembleRelease
adb install app/build/outputs/apk/release/app-release.apk

android-demo-verify.zip

Comments

ch...@google.com <ch...@google.com> Jun 24, 2024 06:29AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Jun 24, 2024 07:50PM

deleted

ap...@google.com <ap...@google.com> #3Jun 25, 2024 11:55AM

(reposting under work account)

We have been hitting this issue constantly. Is it possible to configure those tasks to be non cacheable as a workaround or is that only possible inside of AGP?

ap...@google.com <ap...@google.com> #4Jun 26, 2024 09:36AM

Marked as fixed.

Currently the only way to disable caching for dexing transforms is to patch AGP manually by providing a patched DexTransform.kt file in buildSrc. Please see https://issuetracker.google.com/169266011#comment27, section on "Workarounds" for an example.

do...@gmail.com <do...@gmail.com> #5Jun 26, 2024 02:15PM

Thanks. Ignoring potential build perf impacts, if we essentially commented out the processIncrementally block in DexingTransform.kt and always ran non-incrementally, would that workaround this issue?

ap...@google.com <ap...@google.com> #6Jun 27, 2024 07:59AM

Yes, always run the dex transform non-incrementally is another workaround.

ap...@google.com <ap...@google.com> #7Jun 27, 2024 07:59AM

Is it possible to do same patch with included build?

do...@gmail.com <do...@gmail.com> #8Jul 5, 2024 03:36AM

I guess so, could you give it a try?

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #9Jul 24, 2024 08:39PM

I've tried(not very neat) but it only work with buildSrc

Anyway, what about issue, I've tried a lot of attempts to fix and helped only turn off jacoco transformation `useJacocoTransformInstrumentation = false`.

What was changed in agp 7.4.x from 7.3.1 that break this?

an...@google.com <an...@google.com> #10Aug 9, 2024 12:55AM

Are you referring to https://issuetracker.google.com/266109833#comment2? That issue is different from this issue.

(Regarding What was changed in agp 7.4.x from 7.3.1 that break this?: I don't know, my theory is that some of your code has changed too when updating AGP, which exposed the Jacoco bug. Please post your comments in that issue if you'd like to continue discussing this.)