[r8 8.5]r8 horizontal class merge causes verify error on Android5 when disable api modeling [348785664]

Verified

Bug

Status Update

No update yet.

Description

do...@gmail.com

created issue #1

Jun 23, 2024 07:03AM

void S.a.run(): [0x31] couldn't find method android.view.WindowManager.getCurrentWindowMetrics ()Landroid/view/WindowMetrics;
void S.a.run() failed to verify: void S.a.run(): [0x16] expected to be within a catch-all for an instruction where a monitor is held
java.lang.VerifyError: Verifier rejected class S.a due to bad method void S.a.run()

env: Nexus5 with Android5.1.1

demo step:

unzip
gradle :app:assembleRelease
adb install app/build/outputs/apk/release/app-release.apk

android-demo-verify.zip

Comments

ch...@google.com <ch...@google.com> Jun 24, 2024 06:29AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Jun 24, 2024 07:50PM

deleted

ap...@google.com <ap...@google.com> #3Jun 25, 2024 11:55AM

We have fixed this issue in AGP 8.5.0-beta01: https://android.googlesource.com/platform/tools/base/+/880dbb64c2f0cfd7de9452feed920bb8fc08ff7a

ap...@google.com <ap...@google.com> #4Jun 26, 2024 09:36AM

Marked as fixed.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala | 2024.1.1 Canary 8
Android Gradle Plugin 8.5.0-alpha08

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

do...@gmail.com <do...@gmail.com> #5Jun 26, 2024 02:15PM

https://android.googlesource.com/platform/tools/base/+/880dbb64c2f0cfd7de9452feed920bb8fc08ff7a

ap...@google.com <ap...@google.com> #6Jun 27, 2024 07:59AM

Project: r8
Branch: 8.5

commit 49f98ba47347685027ff91e167e6796d0ed2aa9b
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Thu Jun 27 07:24:51 2024

Version 8.5.30

Bug:

b/348785664

Change-Id: If45597b25e0a840061572fd5065d907f45d6e6a2

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/94100

ap...@google.com <ap...@google.com> #7Jun 27, 2024 07:59AM

Project: r8
Branch: 8.5

commit fd22f3aa0e8071547d6b61852e4e066ae5b2af1a
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Thu Jun 27 07:23:27 2024

Reproduce L verification error due to instruction not within catch-all

Bug:

b/348785664

Change-Id: Ie46a006862b0069da9aba3482a3964787b3eff27

A src/test/java/com/android/tools/r8/workaround/ExpectedToBeWithinCatchAllAfterInliningWithSoftVerificationErrorTest.java

https://r8-review.googlesource.com/94081

do...@gmail.com <do...@gmail.com> #8Jul 5, 2024 03:36AM

thx, the issue has been fixed after the upgrade.

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #9Jul 24, 2024 08:39PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 Beta 2
Android Gradle Plugin 8.6.0-beta02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #10Aug 9, 2024 12:55AM

The fixes for this issue are now also available in:

Android Studio Koala | 2024.1.1 Patch 2
Android Gradle Plugin 8.5.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 348785664

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> Jun 24, 2024 06:29AM

ch...@google.com <ch...@google.com> #2Jun 24, 2024 07:50PM

ap...@google.com <ap...@google.com> #3Jun 25, 2024 11:55AM

ap...@google.com <ap...@google.com> #4Jun 26, 2024 09:36AM

do...@gmail.com <do...@gmail.com> #5Jun 26, 2024 02:15PM

ap...@google.com <ap...@google.com> #6Jun 27, 2024 07:59AM

ap...@google.com <ap...@google.com> #7Jun 27, 2024 07:59AM

do...@gmail.com <do...@gmail.com> #8Jul 5, 2024 03:36AM

ch...@google.com <ch...@google.com> Jul 5, 2024 06:14AM

an...@google.com <an...@google.com> #9Jul 24, 2024 08:39PM

an...@google.com <an...@google.com> #10Aug 9, 2024 12:55AM

Add comment

Issue metadata