Type-safe navigation with Compose: "null" (string) query string is treated as null [348936238]

Fixed

Feature Request

Status Update

No update yet.

Description

fi...@gmail.com

created issue #1

Jun 24, 2024 04:49AM

Component used: Navigation
Version used: 2.8.0-beta03
Devices/Android versions reproduced on: emulator

Suppose the class for the route is NotHome.

@Serializable data class NotHome(
    val param: String? = null
)

Suppose the destination is set up like this.

composable<NotHome>(
    deepLinks = listOf(navDeepLink<NotHome>("example.com")),
) { bse -> 
    val notHome: NotHome = bse.toRoute()
    Text("param=" + notHome.param?.let { "'$it'" })
}

When the link is https://example.com?param=NULL, param is string 'NULL' as expected. But if the link is https://example.com?param=null, param is really null instead of string 'null'.

Comments

fi...@gmail.com <fi...@gmail.com> #2Jun 24, 2024 08:51AM

Dany, I believe this is fixed in a new release of safeargs ?

Message last modified on Jun 24, 2024 08:54AM

jb...@google.com <jb...@google.com> Jun 24, 2024 03:23PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #3Jun 24, 2024 07:37PM

Status: Won't Fix (Intended Behavior)

Safeargs still needs AndroidComponentsExtension to get the applicationID from the variants (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt;l=73). Did AGP 7.2.0-alpha05 remove the extension?

fi...@gmail.com <fi...@gmail.com> #4Jun 25, 2024 02:48AM

it moved to a different package : com.android.build.api.variant

Message last modified on Jun 25, 2024 09:15AM

cl...@google.com <cl...@google.com> #5Jun 25, 2024 04:13PM

Safeargs still relies on AGP 4.2. We need some of the BaseVariant APIs to have replacements before we can upgrade to 7.0+ (https://issuetracker.google.com/203557189).

Message last modified on Jun 25, 2024 04:14PM

fi...@gmail.com <fi...@gmail.com> #6Jun 26, 2024 04:28AM

The BaseVariant API are deprecated but still available in 7.x, so you should be able to release a newer version that uses the new package and still relies on the old API you require. Or am I missing something ?

fi...@gmail.com <fi...@gmail.com> #7Jun 26, 2024 09:58AM

I'll try updating to the latest stable to see if we run into any issues. I can check to make sure changing the package name in 7.2.0-alpha05 works, but we would need it to be stable before we could do a release with this change.

cl...@google.com <cl...@google.com> #8Jun 26, 2024 11:20PM

FYI this also breaks the latest Studio (2021.1.1 Beta 5)/AGP (7.1.0-beta05) beta where com.android.build.api.extension.AndroidComponentsExtension has been removed.

Is there a particular reason why https://issuetracker.google.com/203557189 and this issues don't have a higher priority?

As it stands, no one can upgrade either AGP/Studio Beta or Canary and take advantage of fixes in the latest versions because Navigation still uses the old AGP APIs.

fi...@gmail.com <fi...@gmail.com> #9Jun 27, 2024 03:26AM

Was this fixed in Studio 2021.1.1 RC 1?

Message last modified on Jun 28, 2024 09:48AM

cl...@google.com <cl...@google.com> #10Jul 12, 2024 06:10PM

I do not think so https://developer.android.com/studio/releases/fixed-bugs/studio/2021.1.1#android-studio-bumblebee-rc-01-2021.1.1.19.

Pretty disappointing though.

Message last modified on Jul 12, 2024 06:11PM

fi...@gmail.com <fi...@gmail.com> #11Jul 14, 2024 08:30AM

This will be fixed in the Navigation Safe Args 2.5.0-alpha01 and 2.4.1 versions. You can follow the snapshot instructions and try this out with build id #8054565.

il...@google.com <il...@google.com> #12Aug 20, 2024 08:01PM

Status: Assigned (reopened)

Thank you! 2.4.1 is at least two weeks out (possibly 4, if I'm not mistaken).

I applaud the AGPs team decision to stick to the new APIs though. Hopefully its not too long before Navigation fixes this.

cl...@google.com <cl...@google.com> Sep 3, 2024 06:23PM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #13Sep 5, 2024 05:59PM

So we are talking mid february ?

ap...@google.com <ap...@google.com> #14Sep 5, 2024 05:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #15Sep 5, 2024 05:59PM

Is this included in the Dolphin Beta 1 build? 7.3.0-beta01?

I'm able to consistent reproduce this when having the namespace field setup in my gradle file. Removing it (and adding the value back to the Manifest files) does not cause the issue. Not sure if the same case here, or a new one.

cl...@google.com <cl...@google.com> #16Sep 5, 2024 06:02PM

Marked as fixed.

May be related to this one ? https://issuetracker.google.com/231704909

na...@google.com <na...@google.com> #17Sep 18, 2024 05:37PM

Right, the direct incompatibility between AGP and Safe Args is fixed, I believe, but there's another issue related to the use of applicationId vs namespace, tracking at http://issuetracker.google.com/232107688. Thanks!

na...@google.com <na...@google.com> #18Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.9.0-alpha01