Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jun 24, 2024 06:49PM

Solution

Remove Compose desktop sources and replace them with stubs of a linux x86 native platform.

Reasoning

Google has Compose desktop sourcesets that we build and ship artifacts to Google maven for validation that Compose is not adding assumptions that only work on Android. Jetbrains has continued work on their fork of compose and Desktop sources are very out of date in AOSP.

This is problematic in two ways:

Someone might try using -desktop from Google instead of Jetbrain's -desktop artifacts and these artifacts are very stale
It is difficult for Jetbrains to upstream common changes as they have to backport desktop implementations to an old fork
AOSP has no coverage of native platforms, so JVM assumptions can slip into common code.

Comments

au...@google.com <au...@google.com> #2Jun 24, 2024 08:21PM

Note, this also means removing jvmMain in addition todesktopMain

au...@google.com <au...@google.com> #3Jun 24, 2024 09:21PM

It also includes removing skikoMain

ap...@google.com <ap...@google.com> #4Jun 25, 2024 12:57AM

Project: platform/frameworks/support
Branch: androidx-main

commit abbf42e66d7651ac7a2cbedf7244c5a879308132
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Jun 24 14:38:38 2024

Remove Compose jvmTest and desktopTest

In preparation to remove desktop sources, remove the tests for this
platform except in compose:runtime:runtime project

Test: ./gradlew allHostTests
Bug: 349141613
Change-Id: I76299500c94622861e9c6925641d7e1dfa25980e

M compose/animation/animation-core/build.gradle
M compose/animation/animation-graphics/build.gradle
M compose/animation/animation/build.gradle
M compose/foundation/foundation-layout/build.gradle
M compose/foundation/foundation/build.gradle
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/ScrollbarTest.kt
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/OWNERS
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapterTest.kt
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/selection/DesktopTextFieldSelectionManagerTest.kt
D compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/selection/StringHelpersTest.kt
D compose/foundation/foundation/src/desktopTest/resources/mockito-extensions/org.mockito.plugins.MockMaker
M compose/material/material-ripple/build.gradle
M compose/material/material/build.gradle
D compose/material/material/src/desktopTest/kotlin/androidx/compose/material/DesktopAlertDialogTest.kt
D compose/material/material/src/desktopTest/kotlin/androidx/compose/material/DesktopMenuTest.kt
M compose/material3/adaptive/adaptive-layout/build.gradle
M compose/material3/adaptive/adaptive-navigation/build.gradle
M compose/material3/adaptive/adaptive/build.gradle
M compose/material3/material3-adaptive-navigation-suite/build.gradle
M compose/material3/material3-common/build.gradle
M compose/material3/material3-window-size-class/build.gradle
M compose/material3/material3/build.gradle
M compose/runtime/runtime-saveable/build.gradle
M compose/test-utils/build.gradle
M compose/ui/ui-geometry/build.gradle
M compose/ui/ui-graphics/build.gradle
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/DesktopGraphicsTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/DesktopImageBitmapTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/DesktopPaintTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/DesktopPathTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/TestUtils.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/canvas/DesktopCanvasPointsTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/canvas/DesktopCanvasTest.kt
D compose/ui/ui-graphics/src/desktopTest/kotlin/androidx/compose/ui/graphics/layer/DesktopGraphicsLayerTest.kt
D compose/ui/ui-graphics/src/desktopTest/res/androidx/compose/desktop/test.png
M compose/ui/ui-test-junit4/build.gradle
D compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/junit4/CustomEffectContextRuleTest.kt
M compose/ui/ui-test/build.gradle
D compose/ui/ui-test/src/desktopTest/kotlin/androidx/compose/ui/test/CustomEffectContextTest.kt
M compose/ui/ui-text/build.gradle
D compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/CacheTest.kt
D compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/DesktopFontTest.kt
D compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/DesktopParagraphTest.kt
D compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/TestUtils.kt
M compose/ui/ui-tooling-data/build.gradle
M compose/ui/ui-tooling-preview/build.gradle
M compose/ui/ui-tooling/build.gradle
M compose/ui/ui-unit/build.gradle
M compose/ui/ui-util/build.gradle
M compose/ui/ui/build.gradle
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/desktop/TestThread.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ComposeSceneTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/LeakDetector.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/TestUtils.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposePanelTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/draw/DesktopDrawingPrebuiltGraphicsLayerTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/graphics/DesktopGraphicsLayerScopeTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/key/KeyInputUtil.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/key/KeyTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/mouse/MouseHoverFilterTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/mouse/MouseScrollFilterTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/input/pointer/PointerIconTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/AccessibilityTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/DesktopInputComponentTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/DesktopTextInputSessionTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/FlushCoroutineDispatcherTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/GraphicsLayerTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/RenderingTestScope.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/SkiaLayerTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/res/DesktopSvgResourcesTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/util/AddRemoveMutableListTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/util/UpdateEffectTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/ApplicationTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/DesktopPopupTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/MenuBarTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/dialog/DialogTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowInputEventTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowParameterTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowStateTest.kt
D compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
D compose/ui/ui/src/desktopTest/resources/androidx/compose/ui/res/star-size-100.svg
D compose/ui/ui/src/desktopTest/resources/androidx/compose/ui/res/star-size-unspecified.svg
D compose/ui/ui/src/desktopTest/resources/androidx/compose/ui/res/star-viewbox-unspecified.svg
D compose/ui/ui/src/desktopTest/resources/mockito-extensions/org.mockito.plugins.MockMaker

https://android-review.googlesource.com/3142040

iv...@jetbrains.com <iv...@jetbrains.com> #5Jun 25, 2024 07:07AM

Note, this also means removing jvmMain in addition to desktopMain

It should not - jvmMain is used to share JVM code between Desktop and Android, we should keep separation between JVM and Android specifics.

au...@google.com <au...@google.com> #6Jun 25, 2024 03:34PM

Good point, we'll keep one jvm stub target.

au...@google.com <au...@google.com> #7Jun 25, 2024 08:20PM

Unintended consequences

We'll have to unpin all of the compose dependencies to support building the new stubs. This is needed to add -nativeStubs target as to compile it, all the dependencies will need a published version of the stubs.

Additional tasks

We'll need to make sure that dackka filters out jdkStubs and nativeStubs so they don't show up in documentation.

ap...@google.com <ap...@google.com> #8Jun 27, 2024 12:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit d0fcd1ef43305313703086ed531bb86de7f8264a
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jun 26 09:48:52 2024

Convert compose runtime desktop target to jvmStubs target

- Replace all actuals in jvmStubs

Test: ./gradlew -p compose/runtime build
Bug: 349141613
Change-Id: Ia38163d791457c81eacc484202aea449fdd9c5c8

M compose/runtime/runtime-saveable/build.gradle
M compose/runtime/runtime-test-utils/build.gradle
M compose/runtime/runtime/build.gradle
M compose/runtime/runtime/integration-tests/build.gradle
D compose/runtime/runtime/src/desktopMain/kotlin/androidx/compose/runtime/MonotonicFrameClock.desktop.kt
M compose/runtime/runtime/src/jvmStubsMain/kotlin/androidx/compose/runtime/MonotonicFrameClock.jvmStubs.kt
M compose/runtime/runtime/src/jvmStubsMain/kotlin/androidx/compose/runtime/NotImplemented.jvmStubs.kt
M compose/runtime/runtime/src/jvmStubsMain/kotlin/androidx/compose/runtime/internal/Utils.jvmStubs.kt
M compose/runtime/runtime/src/jvmStubsTest/kotlin/kotlinx/test/IgnoreAndroidUnitTestTarget.kt

https://android-review.googlesource.com/3148400

ap...@google.com <ap...@google.com> #9Jun 27, 2024 12:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 72302f99e5165f94b4b97a06367683476fef90cd
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jun 25 15:42:22 2024

Convert compose material desktop target to jvmStubs target

- Update ValidateMultiplatformSourceSetNaming to allow jvmStubs suffix
- Update SourceJarTaskHelper to filter out stubs sources
- Update getDefaultTargetJavaVersion to make jvmStubs target Java 11
matching compose -desktop
- Replace all actuals in jvmStubs with NotImplementedError except for
typealias in material-ripple that was kept as-is

Test: ./gradlew compose:material:material:publish
Bug: 349141613
Change-Id: Ic5d1adb89059a386f8d498a705a26ec3dac2266d

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/private/src/main/kotlin/androidx/build/SourceJarTaskHelper.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M compose/material/material-ripple/build.gradle
A compose/material/material-ripple/src/jvmStubsMain/kotlin/androidx/compose/material/ripple/NotImplemented.jvmStubs.kt
M compose/material/material-ripple/src/jvmStubsMain/kotlin/androidx/compose/material/ripple/Ripple.jvmStubs.kt
M compose/material/material/build.gradle
D compose/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
D compose/material/material/src/desktopMain/kotlin/androidx/compose/material/MaterialTheme.desktop.kt
D compose/material/material/src/desktopMain/kotlin/androidx/compose/material/Strings.desktop.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/AlertDialog.jvmStubs.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/DefaultPlatformTextStyle.jvmStubs.kt
A compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/DesktopMenu.jvmStubs.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/MaterialTheme.jvmStubs.kt
A compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/Menu.jvmStubs.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/NotImplemented.jvmStubs.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/Strings.jvmStubs.kt
M compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/SystemBarsDefaultInsets.jvmStubs.kt
D compose/material/material/src/skikoMain/kotlin/androidx/compose/material/Menu.skiko.kt

https://android-review.googlesource.com/3147199

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit af0b7a239bb6b0645a08f4b98216005dd2834863
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jun 26 17:49:26 2024

Convert compose foundation desktop targets to jvmStubs targets

- Replace all actuals in jvmStubs

Test: ./gradlew -p compose/foundation build
Bug: 349141613
Change-Id: I12b8a9c4d216fc9c9e90614e1a076203c0d10f71

M compose/foundation/foundation-layout/build.gradle
D compose/foundation/foundation-layout/src/desktopMain/kotlin/androidx/compose/foundation/layout/WindowInsetsPadding.desktop.kt
M compose/foundation/foundation-layout/src/jvmStubsMain/kotlin/androidx/compose/foundation/layout/NotImplemented.jvmStubs.kt
M compose/foundation/foundation-layout/src/jvmStubsMain/kotlin/androidx/compose/foundation/layout/WindowInsets.jvmStubs.kt
A compose/foundation/foundation-layout/src/jvmStubsMain/kotlin/androidx/compose/foundation/layout/WindowInsetsPadding.jvmStubs.kt
M compose/foundation/foundation/build.gradle
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/BasicContextMenuRepresentation.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/BasicTooltip.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Clickable.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/ContextMenuProvider.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/DarkTheme.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/DesktopPlatform.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Scrollbar.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/TooltipArea.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/gestures/DesktopScrollable.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/ContextMenu.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/KeyMapping.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/StringHelpers.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldFocusModifier.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldKeyInput.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldLayoutStateCache.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/input/internal/ToCharArray.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.desktop.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/window/WindowDraggableArea.desktop.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/BasicTooltip.jvmStubs.kt
A compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/Clickable.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/DarkTheme.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/DesktopOverscroll.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/NotImplemented.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/content/MediaType.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/content/TransferableContent.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/content/internal/DragAndDropRequestPermission.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/content/internal/ReceiveContentDragAndDropNode.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/gestures/BringIntoViewSpec.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/gestures/DesktopScrollable.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/lazy/layout/Lazy.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/lazy/layout/PrefetchScheduler.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.jvmStubs.kt
A compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/ContextMenu.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/DeadKeyCombiner.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/DesktopCursorHandle.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.jvmStubs.kt
A compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/KeyMapping.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/StringHelpers.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/TextFieldFocusModifier.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/TextFieldKeyInput.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/TextPointerIcon.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/TouchMode.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/DesktopTextInputSession.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDragAndDropNode.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldKeyEventHandler.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldLayoutStateCache.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/ToCharArray.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/input/internal/selection/DesktopTextFieldMagnifier.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/selection/DesktopSelectionHandles.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.jvmStubs.kt
M compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.jvmStubs.kt

https://android-review.googlesource.com/3148750

au...@google.com <au...@google.com> #11Jun 27, 2024 10:26PM

Splitting out adding of native stubs into b/349894318

ap...@google.com <ap...@google.com> #12Jun 28, 2024 03:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit ad77691b64c9f3bba798a03eeadc9c8b0266bf55
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 14:38:33 2024

Convert compose animation and material3 desktop targets to jvmStubs targets

- Replace all actuals in jvmStubs

Test: ./gradlew -p compose build
Bug: 349141613
Change-Id: Ibb31e9fd6a09adad443baa861ece1cff6cf411fc

M compose/animation/animation-core/build.gradle
M compose/animation/animation-graphics/build.gradle
M compose/animation/animation/build.gradle
D compose/animation/animation/src/desktopMain/kotlin/androidx/compose/animation/SplineBasedDecayAnimationSpec.desktop.kt
M compose/animation/animation/src/jvmStubsMain/kotlin/androidx/compose/animation/DesktopActualDefaultDecayAnimationSpec.jvmStubs.kt
M compose/animation/animation/src/jvmStubsMain/kotlin/androidx/compose/animation/NotImplemented.jvmStubs.kt
M compose/animation/animation/src/jvmStubsMain/kotlin/androidx/compose/animation/SplineBasedDecayAnimationSpec.jvmStubs.kt
M compose/material3/adaptive/adaptive-layout/build.gradle
M compose/material3/adaptive/adaptive-layout/src/jvmStubsMain/kotlin/androidx/compose/material3/adaptive/layout/NotImplemented.jvmStubs.kt
M compose/material3/adaptive/adaptive-layout/src/jvmStubsMain/kotlin/androidx/compose/material3/adaptive/layout/PaneExpansionDragHandle.jvmStubs.kt
M compose/material3/adaptive/adaptive-navigation/build.gradle
M compose/material3/adaptive/adaptive/build.gradle
M compose/material3/adaptive/adaptive/src/jvmStubsMain/kotlin/androidx/compose/material3/adaptive/DesktopWindowInfo.jvmStubs.kt
M compose/material3/adaptive/adaptive/src/jvmStubsMain/kotlin/androidx/compose/material3/adaptive/NotImplemented.jvmStubs.kt
M compose/material3/material3-adaptive-navigation-suite/build.gradle
M compose/material3/material3-common/build.gradle
M compose/material3/material3-window-size-class/build.gradle
M compose/material3/material3/build.gradle
D compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/NavigationDrawer.desktop.kt
D compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Tooltip.desktop.kt
D compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/internal/BasicTooltip.desktop.kt
D compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/internal/CalendarModel.desktop.kt
D compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/internal/Strings.desktop.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/AlertDialog.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/CalendarLocale.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/ModalBottomSheet.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/NavigationDrawer.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/NotImplemented.jvmStubs.kt
A compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/SkikoMenu.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/TimeFormat.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/TimePicker.jvmStubs.kt
A compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/Tooltip.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/AccessibilityServiceStateProvider.jvmStubs.kt
A compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/BasicTooltip.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/CalendarModel.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/DefaultPlatformTextStyle.jvmStubs.kt
A compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/Strings.jvmStubs.kt
M compose/material3/material3/src/jvmStubsMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.jvmStubs.kt
D compose/material3/material3/src/skikoMain/kotlin/androidx/compose/material3/SkikoMenu.skiko.kt

https://android-review.googlesource.com/3151099

ap...@google.com <ap...@google.com> #13Jul 4, 2024 12:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit e08511b28618f602870cd921ffa88b5ad1e31940
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 03 14:13:55 2024

Convert compose ui desktop targets to jvmStubs targets

- Disable running jvmStubsTest, as they are not representative
of a real environment
- Replace all actuals in jvmStubs

Bug: 349141613
Bug: 349879364
Test: ./gradlew -p compose/ui build
Change-Id: If913cd0140daf0df20f8e47b6406e7b9aa3d65e9

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M compose/ui/ui-geometry/build.gradle
M compose/ui/ui-graphics/build.gradle
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopColorFilter.desktop.kt
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopImageAsset.desktop.kt
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopImageConverters.desktop.kt
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/DesktopPathEffect.desktop.kt
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/RenderEffect.desktop.kt
D compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.desktop.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/Canvas.jvmStubs.kt
A compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/ColorFilter.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/ImageBitmap.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/NotImplemented.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/Paint.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/Path.jvmStubs.kt
A compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/PathEffect.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/PathIterator.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/PathMeasure.jvmStubs.kt
A compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/RenderEffect.jvmStubs.kt
A compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/Shader.jvmStubs.kt
M compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/TileMode.jvmStubs.kt
A compose/ui/ui-graphics/src/jvmStubsMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.jvmStubs.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/BlendMode.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/Rects.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedCanvas.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedPaint.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedPath.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedPathEffect.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedPathMeasure.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaBackedRenderEffect.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaColorFilter.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaImageAsset.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaPathIterator.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaShader.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaTileMode.skiko.kt
D compose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaVertexMode.skiko.kt
M compose/ui/ui-test-junit4/build.gradle
D compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.desktop.kt
D compose/ui/ui-test-junit4/src/desktopMain/kotlin/androidx/compose/ui/test/junit4/SkiaTest.desktop.kt
M compose/ui/ui-test-junit4/src/jvmStubsMain/kotlin/androidx/compose/ui/test/junit4/DesktopComposeTestRule.jvmStubs.kt
M compose/ui/ui-test-junit4/src/jvmStubsMain/kotlin/androidx/compose/ui/test/junit4/NotImplemented.jvmStubs.kt
M compose/ui/ui-test/build.gradle
D compose/ui/ui-test/src/desktopMain/kotlin/androidx/compose/ui/test/ComposeUiTest.desktop.kt
D compose/ui/ui-test/src/desktopMain/kotlin/androidx/compose/ui/test/DesktopInputDispatcher.desktop.kt
D compose/ui/ui-test/src/desktopMain/kotlin/androidx/compose/ui/test/DesktopSynchronization.desktop.kt
D compose/ui/ui-test/src/desktopMain/kotlin/androidx/compose/ui/test/DeviceConfigurationOverride.desktop.kt
D compose/ui/ui-test/src/desktopMain/kotlin/androidx/compose/ui/test/MainTestClockImpl.desktop.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/Actions.jvmStubs.kt
A compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/ComposeUiTest.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DensityForcedSize.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DesktopAssertions.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DesktopInputDispatcher.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DesktopOutput.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DesktopSynchronization.jvmStubs.kt
A compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/DeviceConfigurationOverride.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/Mouse.jvmStubs.kt
M compose/ui/ui-test/src/jvmStubsMain/kotlin/androidx/compose/ui/test/NotImplemented.jvmStubs.kt
M compose/ui/ui-text/build.gradle
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/ExpireAfterAccessCache.desktop.kt
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/JvmCharHelpers.desktop.kt
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/intl/DesktopPlatformLocale.desktop.kt
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopFont.desktop.kt
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopParagraphIntrinsics.desktop.kt
D compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopStringDelegate.desktop.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/JvmCharHelpers.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/NotImplemented.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/Paragraph.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/Savers.jvmStubs.kt
A compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/TextStyle.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/font/DelegatingFontLoaderForDeprecatedUsage.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/font/FontSynthesis.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/intl/DesktopPlatformLocale.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/platform/DesktopStringDelegate.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/platform/SkiaMultiParagraphDraw.jvmStubs.kt
A compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.jvmStubs.kt
A compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraphIntrinsics.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/style/LineBreak.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/style/TextMotion.jvmStubs.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/DesktopTextStyle.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/SkiaParagraph.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/font/DelegatingFontLoaderForDeprecatedUsage.sikio.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/font/FontFamilyResolver.sikio.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/font/SkiaFontLoader.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/ParagraphLayouter.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/PlatformFont.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
D compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraphIntrinsics.skiko.kt
M compose/ui/ui-tooling-data/build.gradle
M compose/ui/ui-tooling-preview/build.gradle
D compose/ui/ui-tooling-preview/src/desktopMain/kotlin/androidx/compose/desktop/ui/tooling/preview/Preview.desktop.kt
M compose/ui/ui-tooling/build.gradle
D compose/ui/ui-tooling/src/desktopMain/kotlin/androidx/compose/desktop/ui/tooling/preview/runtime/NonInteractivePreviewFacade.desktop.kt
D compose/ui/ui-tooling/src/desktopMain/kotlin/androidx/compose/desktop/ui/tooling/preview/runtime/PreviewRunner.desktop.kt
M compose/ui/ui-tooling/src/jvmStubsMain/kotlin/androidx/compose/ui/tooling/NotImplemented.jvmStubs.kt
M compose/ui/ui-tooling/src/jvmStubsMain/kotlin/androidx/compose/ui/tooling/PreviewLogger.jvmStubs.kt
M compose/ui/ui-unit/build.gradle
M compose/ui/ui-unit/src/jvmStubsMain/kotlin/androidx/compose/ui/unit/FontScaling.jvmStubs.kt
M compose/ui/ui-util/build.gradle
M compose/ui/ui-util/src/jvmStubsMain/kotlin/androidx/compose/ui/util/Trace.jvmStubs.kt
M compose/ui/ui/build.gradle
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/ComposeScene.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/ConfigureSwingGlobalsForCompose.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/autofill/ContentType.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeDialog.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeLayer.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindow.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindowDelegate.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/LocalLayerContainer.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/SwingPanel.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/Key.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/KeyEvent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/KeyShortcut.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/InternalPointerEvent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerIcon.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEvent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerMoveFilter.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/rotary/RotaryScrollEvent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/Accessibility.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/ComposeAccessible.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopPlatform.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopPlatformInput.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputSession.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/GlobalSnapshotManager.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformClipboardManager.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformComponent.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformLocalization.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformTextInputMethodRequest.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/TestComposeWindow.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/DesktopSvgResources.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/DesktopXmlVectorResources.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/ImageResources.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/PainterResources.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/Resources.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/vector/DesktopValueParsers.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/vector/DesktopXmlVectorParser.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/util/AddRemoveMutableList.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/util/ComponentUpdater.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/util/UpdateEffect.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/util/Windows.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Application.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/AwtWindow.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Dialog.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DialogState.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/LayoutConfiguration.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/LocalWindow.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Menu.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Notification.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Tray.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/UndecoratedWindowResizer.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Window.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowPlacement.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowPosition.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowScope.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowSize.desktop.kt
D compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/WindowState.desktop.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/NotImplemented.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/autofill/ContentDataType.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/autofill/ContentType.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/hapticfeedback/PlatformHapticFeedbackType.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/key/Key.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/key/KeyEvent.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/pointer/InternalPointerEvent.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/pointer/PointerIcon.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEvent.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/input/rotary/RotaryScrollEvent.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/platform/PlatformClipboardManager.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/platform/PlatformTextInputMethodRequest.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/platform/PlatformTextInputSession.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/platform/Wrapper.jvmStubs.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/viewinterop/InteropView.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/viewinterop/InteropViewFactoryHolder.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/window/Dialog.jvmStubs.kt
A compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/window/Popup.jvmStubs.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ComposeScene.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/input/mouse/MouseScrollFilter.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/input/pointer/TestPointerInputEventData.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/AccessibilityController.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultAccessibilityManager.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultTextToolbar.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultUiApplier.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultViewConfiguration.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/FlushCoroutineDispatcher.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/GlobalSnapshotManager.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/PlatformClipboardManager.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/PlatformComponent.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/PlatformInput.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaRootForTest.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/Wrapper.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/viewinterop/InteropView.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/viewinterop/InteropViewFactoryHolder.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
D compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Popup.skiko.kt

https://android-review.googlesource.com/3159181

au...@google.com <au...@google.com> Jul 16, 2024 04:02PM

Marked as fixed.

au...@google.com <au...@google.com> #14Sep 6, 2024 06:07PM

Status: Assigned (reopened)

Reopening this to land this in 1.7.x of compose

au...@google.com <au...@google.com> #15Sep 11, 2024 06:18PM

Marked as fixed.

We have shipped compose 1.7.1 that has the stubs

IssueTracker

Remove compose desktop sources and replace them with stubs

Status Update

Description

Solution

Reasoning

Comments

au...@google.com <au...@google.com> #2Jun 24, 2024 08:21PM

au...@google.com <au...@google.com> #3Jun 24, 2024 09:21PM

ap...@google.com <ap...@google.com> #4Jun 25, 2024 12:57AM

iv...@jetbrains.com <iv...@jetbrains.com> #5Jun 25, 2024 07:07AM

au...@google.com <au...@google.com> #6Jun 25, 2024 03:34PM

au...@google.com <au...@google.com> #7Jun 25, 2024 08:20PM

Unintended consequences

Additional tasks

ap...@google.com <ap...@google.com> #8Jun 27, 2024 12:10AM

ap...@google.com <ap...@google.com> #9Jun 27, 2024 12:10AM

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:16PM

au...@google.com <au...@google.com> #11Jun 27, 2024 10:26PM

ap...@google.com <ap...@google.com> #12Jun 28, 2024 03:35PM

ap...@google.com <ap...@google.com> #13Jul 4, 2024 12:47PM

au...@google.com <au...@google.com> Jul 16, 2024 04:02PM

au...@google.com <au...@google.com> #14Sep 6, 2024 06:07PM

au...@google.com <au...@google.com> #15Sep 11, 2024 06:18PM

Issue 349141613

Description

Solution

Reasoning

Issue summary

Comments

au...@google.com <au...@google.com> #2Jun 24, 2024 08:21PM

au...@google.com <au...@google.com> #3Jun 24, 2024 09:21PM

ap...@google.com <ap...@google.com> #4Jun 25, 2024 12:57AM

iv...@jetbrains.com <iv...@jetbrains.com> #5Jun 25, 2024 07:07AM

au...@google.com <au...@google.com> #6Jun 25, 2024 03:34PM

au...@google.com <au...@google.com> #7Jun 25, 2024 08:20PM

Unintended consequences

Additional tasks

ap...@google.com <ap...@google.com> #8Jun 27, 2024 12:10AM

ap...@google.com <ap...@google.com> #9Jun 27, 2024 12:10AM

ap...@google.com <ap...@google.com> #10Jun 27, 2024 07:16PM

au...@google.com <au...@google.com> #11Jun 27, 2024 10:26PM

ap...@google.com <ap...@google.com> #12Jun 28, 2024 03:35PM

ap...@google.com <ap...@google.com> #13Jul 4, 2024 12:47PM

au...@google.com <au...@google.com> Jul 16, 2024 04:02PM

au...@google.com <au...@google.com> #14Sep 6, 2024 06:07PM

au...@google.com <au...@google.com> #15Sep 11, 2024 06:18PM

Add comment

Issue metadata