ActivityOptionsCompat missing setPendingIntentBackgroundActivityStartMode() [349617674]

Fixed

Bug

Status Update

No update yet.

Description

he...@gmail.com

created issue #1

Jun 27, 2024 10:34AM

The ActivityOptionsCompat class is missing a backport of the setPendingIntentBackgroundActivityStartMode which is necessary when targeting Android 14.

On Android 13 it could fallback to the deprecated setPendingIntentBackgroundActivityLaunchAllowed, and on lower versions be a no-op.

See source code: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/app/ActivityOptionsCompat.java

Component used: androidx.core:core

Version used: 1.9.0

Comments

il...@google.com <il...@google.com> Jun 27, 2024 03:48PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> Jul 1, 2024 03:22PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #2Jul 8, 2024 07:42PM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

al...@google.com <al...@google.com> Jul 8, 2024 08:58PM

Marked as fixed.

na...@google.com <na...@google.com> #3Aug 21, 2024 07:55PM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

Issue 349617674