Assigned
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: chromium/src
Branch: main
commit 9a891b4e6d6d67c01171bac8223c067a238e1e2d
Author: Renuga Nanjappan <rnanjappan@google.com>
Date: Mon Jul 01 07:36:41 2024
Update chrome_public_test_apk for android 14 builder
Bug: 1036556,350391770,350393662,350394860,350395970
Change-Id: Ie1acaff02f95a1e51aecd20e0ea638d892ad501a
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5665183
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321547}
M testing/buildbot/filters/android.emulator_14.chrome_public_test_apk.filter
https://chromium-review.googlesource.com/5665183
Branch: main
commit 9a891b4e6d6d67c01171bac8223c067a238e1e2d
Author: Renuga Nanjappan <rnanjappan@google.com>
Date: Mon Jul 01 07:36:41 2024
Update chrome_public_test_apk for android 14 builder
Bug: 1036556,350391770,350393662,350394860,350395970
Change-Id: Ie1acaff02f95a1e51aecd20e0ea638d892ad501a
Reviewed-on:
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321547}
M testing/buildbot/filters/android.emulator_14.chrome_public_test_apk.filter
ap...@google.com <ap...@google.com> #3
Project: chromium/src
Branch: main
commit 6fd8c778a9db6b15ffee598c7c86ccad164db3ed
Author: Haiyang Pan <hypan@google.com>
Date: Wed Jul 24 00:35:38 2024
Disable failed tests in chrome_public_test_apk on android-14-arm64-rel
Bug: 350394860, 350395970
Bug: 355057773, 355058571, 355058925
Change-Id: I2b1c06f06a68ceafb424a43e061fa7ddebea82ec
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5734742
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332075}
M testing/buildbot/filters/android.device_14.chrome_public_test_apk.filter
https://chromium-review.googlesource.com/5734742
Branch: main
commit 6fd8c778a9db6b15ffee598c7c86ccad164db3ed
Author: Haiyang Pan <hypan@google.com>
Date: Wed Jul 24 00:35:38 2024
Disable failed tests in chrome_public_test_apk on android-14-arm64-rel
Bug: 350394860, 350395970
Bug: 355057773, 355058571, 355058925
Change-Id: I2b1c06f06a68ceafb424a43e061fa7ddebea82ec
Reviewed-on:
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Renuga Nanjappan <rnanjappan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332075}
M testing/buildbot/filters/android.device_14.chrome_public_test_apk.filter
hn...@google.com <hn...@google.com> #4
These tests are broken in Android 14+
- org.chromium.chrome.browser.TabsOpenedFromExternalAppTest.testNewTabForUnknownApp
- org.chromium.chrome.browser.TabsOpenedFromExternalAppTest.testNewTabWithNewTabExtra
- org.chromium.chrome.browser.TabsOpenedFromExternalAppTest.testNoNewTabForSameApp
- org.chromium.chrome.browser.TabsOpenedFromExternalAppTest.testNoNewTabForSameAppOnStart
Pretty likely to be an actual regression.
hn...@google.com <hn...@google.com> #5
Michael, can you take a look or reroute this?
mt...@google.com <mt...@google.com> #6
As far as I can tell, the functionality is correct and the tests pass if I remove the assert in https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/MinimizeAppAndCloseTabBackPressHandler.java;drc=5cfd92f920e60c89953ce9fe127a6948ca5bd794;l=313
I'm really not sure what this assert is checking so I have no idea whether it's correct. Over to lazzzis@ to assess.
I'm really not sure what this assert is checking so I have no idea whether it's correct. Over to lazzzis@ to assess.
Description
Sample build -