IssueTracker

Name of API affected:
Android YouTube API

Issue summary:
The YoutubePlayerSupportFragment is keeping a reference to the activity after rotating the display - rotating the display 10 times will result in 10 activities that can't be garbage collected. This is a huge memory leak which I have verified with Eclipse MAT.

Steps to reproduce issue:
1. Create a simple activity that extends FragmentActivity. I used the latest 20.0.0 support library

2. Here is the code - this is a very simple example that just creates the youtube fragment. StrictMode is enabled so that you get warnings about too many activity instances.

   @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        StrictMode.setThreadPolicy(new StrictMode.ThreadPolicy.Builder().detectAll().penaltyLog().build());
        StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder().detectAll().penaltyLog().build());

        YouTubePlayerSupportFragment youTubePlayerSupportFragment = (YouTubePlayerSupportFragment) getSupportFragmentManager().findFragmentById(R.id.viewpager);
        if (youTubePlayerSupportFragment == null) {
            youTubePlayerSupportFragment = YouTubePlayerSupportFragment.newInstance();
            getSupportFragmentManager().beginTransaction().replace(R.id.viewpager, youTubePlayerSupportFragment).commit();
        }

        youTubePlayerSupportFragment.initialize(YOUR_GOOGLE_API_KEY, new YouTubePlayer.OnInitializedListener() {
            @Override
            public void onInitializationSuccess(YouTubePlayer.Provider provider, YouTubePlayer youTubePlayer, boolean isRecovered) {
                if (!isRecovered) {
                    youTubePlayer.cueVideo("dSajQAGo6x8");
                }
            }

            @Override
            public void onInitializationFailure(YouTubePlayer.Provider provider, YouTubeInitializationResult youTubeInitializationResult) {

            }
        });
    }

4. You have to supply your own Google API key.
5. Rotate the display several times (to recreate the activity).

Expected output:
No memory leaks.

Actual results:
Reference to the old activities is kept and the memory leak is growing on every rotation.

 E/StrictMode﹕ class youtubeleak.inloop.eu.youtubeleaksample.MainActivity; instances=6; limit=1
    android.os.StrictMode$InstanceCountViolation: class youtubeleak.inloop.eu.youtubeleaksample.MainActivity; instances=12; limit=1
            at android.os.StrictMode.setClassInstanceLimit(StrictMode.java:1)

Notes:
Here is the sample code on GitHub.