Support Type Safe navigation with bottom sheet [351858980]

Assigned

Feature Request

Status Update

No update yet.

Description

ka...@gmail.com

created issue #1

Jul 9, 2024 06:19AM

Compose started to support type-safe navigation but the functionality is missing for the bottom sheet. The navigation team said that the issue should be filed with the material team. See ticket: https://issuetracker.google.com/issues/188693139

Comments

ke...@google.com <ke...@google.com> #2Jul 12, 2024 06:10PM

Reassigned to se...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

se...@google.com <se...@google.com> #3Jul 23, 2024 07:54PM

Reassigned to cl...@google.com.

Is this meant to be material or material3 bottom sheets, and for bottomsheetscaffold, modalbottomsheet, or both?

se...@google.com <se...@google.com> #4Jul 23, 2024 07:55PM

Assigning to Clara who has pending CL's open on this topic

cl...@google.com <cl...@google.com> #5Jul 23, 2024 08:01PM

This is meant for the BottomSheet that is integrated with androidx.navigation. So it is just for material for now.

pr...@simformsolutions.com <pr...@simformsolutions.com> #6Jul 30, 2024 07:36AM

Can you please share estimated timeline for this feature?

ap...@google.com <ap...@google.com> #7Aug 8, 2024 08:45PM

Project: platform/frameworks/support
Branch: androidx-main

commit 00c37d0b6949835a7e8a2f68eb037c57bfc727fe
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 18:20:05 2024

Add bottomSheet constructor with safe args

Add NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args.

Test: ./gradlew compose:material:material-navigation:cC
Bug: 351858980
Relnote: "Added new NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args"
Change-Id: I28589fd1d67de6a23167e6a7648f15d95ed4beb3

M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
M compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt

https://android-review.googlesource.com/3188302

ap...@google.com <ap...@google.com> #8Aug 8, 2024 08:45PM

Project: platform/frameworks/support
Branch: androidx-main

commit fcc5e50056fef5c3a8e6e5ca6672117d58685520
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 17:38:13 2024

Add BottomSheetNavigatorDestinationBuilder

Refactor BottomSheet to use NavDestinationBuilder so that we can leverage existing infrastrcuture to create type-safe BottomSheet in a follow-up CL.

Test: existing tests
Bug: 351858980
Relnote: "Added new BottomSheetNavigatorDestinationBuilder to create a BottomSheetNavigator.Destination with Kotlin DSL"
Change-Id: I777dbf640b83cd3428fd37c4ff5a8065f9ff856e

M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt

https://android-review.googlesource.com/3188301

cl...@google.com <cl...@google.com> #9Aug 9, 2024 12:43PM

Public release date TBD but in the meantime, this new feature can be accessed through public snapshot builds.

cl...@google.com <cl...@google.com> #10Aug 9, 2024 03:27PM

Reassigned to se...@google.com.

Passing to Jose regarding release

Message last modified on Aug 9, 2024 03:28PM

re...@gmail.com <re...@gmail.com> #11Sep 1, 2024 11:51AM

Any update on the release date please?

ka...@gmail.com <ka...@gmail.com> #12Sep 13, 2024 01:26PM

I ma still waiting for the release. I have tried the SNAPSHOT version but that also requires androidCompileSdkVersion = 35, which is inconvenient with all the edge-to-edge changes. Is it possible to have the release and not require androidCompileSdkVersion 35?

ma...@finshape.com <ma...@finshape.com> #13Oct 29, 2024 11:31AM

It was merged only to material, not material3...

https://developer.android.com/jetpack/androidx/releases/compose-material

But Material3 still missing this feature:

https://developer.android.com/jetpack/androidx/releases/compose-material3 so when you are using only material3 (as we do), we are still missing it.

Tue Oct 29 2024 12:29:02 GMT+0100 (středoevropský standardní čas).png

180 KB

View

Download

se...@google.com <se...@google.com> Nov 8, 2024 10:01PM

Assigned to se...@google.com.

m....@gmail.com <m....@gmail.com> #14Nov 17, 2024 04:32PM

When navigating to a destination created with NavGraphBuilder.bottomsheet(), backstack entry is now created BUT nothing is displayed on the screen. When navigating to the same .bottomSheet() destination again, it is just adding a new backstack entry again and again and again, but nothing is displayed on the screen.

ni...@gmail.com <ni...@gmail.com> #15Dec 18, 2024 02:00PM

Any updates? Will M3 be able to access NavGraphBuilder.bottomSheet on the next stable release? Regular material has this planned according to: https://issuetracker.google.com/issues/376169507

jo...@google.com <jo...@google.com> Jan 10, 2025 04:26PM

Reassigned to jo...@google.com.