Status Update
No update yet.
Comments
ke...@google.com
Thanks for the report! We identified the issue and are looking at possible fixes.
se...@google.com
This is still happening with the latest compose 1.4.0-alpha06. Any ETA for a proper fix?
se...@google.com
Hi, 1.4.0-alpha06 did not include a fix for this. We are working on the fix and are aiming to include it in one of the next releases.
cl...@google.com
1.4.0-beta01 and 1.4.0-beta02 are out and the crash is still there. What is delaying the fix for so long?
pr...@simformsolutions.com
ap...@google.com
ap...@google.com
Branch: androidx-main
commit 8cfec3ca487c6f0102eeceab5e57939b36162908
Author: Jossi Wolf <jossiwolf@google.com>
Date: Wed Feb 15 22:25:44 2023
Snap opportunistically in Modal Bottom Sheet
We now use the trySnapTo API to attempt to snap immediately, instead
of launching a coroutine that would most likely only run in the next
frame.
Since we rely on the anchor change handler to initialize the
Swipeable state by snapping if no anchor is found for the initial
value, we need to update the offset immediately, not only a frame
later.
Relnote: "Fixed an issue where ModalBottomSheetLayout would crash
in an edge case on orientation change. Layout animations (e.g.
`Modifier.animateContentSize`) in/on the sheet content now work
smoothly."
Test: modalBottomSheet_anchorChangeHandler_missingAnchor
_immediatelySnapsForInitialization
Bug: 266780234
Change-Id: I2f981d892f163254f0282d6874fb860aae5d0992
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
cl...@google.com
Is the fix from #8 supposed to be included in 1.4.0-rc01? Because I can still reproduce it with this version.
cl...@google.com
In androidx.compose.material3:material3:1.1.0-alpha08, switching screen orientation has been fixed. However, the same problem still occurs when switching to dark mode.
re...@gmail.com
#9, the fix will be included in the next release.
#10, this issue is about M2's ModalBottomSheetLayout. If you are encountering this issue with another component, can you file a new issue?
ka...@gmail.com
#9, the fix will be included in the next release.
Do you mean the next 1.4 release? Thanks.
ma...@finshape.com
we are using 1.4.0-alpha-05.
se...@google.com
m....@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.5.0-alpha01
ni...@gmail.com
This issue has been fixed in 1.5.0-alpha01.
jo...@google.com
jo...@google.com
mt...@gmail.com
The issue mentioned on KotlingLang was about BottomSheetScaffold and has been fixed, with the fix included in the next alpha release.
Description
Compose started to support type-safe navigation but the functionality is missing for the bottom sheet. The navigation team said that the issue should be filed with the material team. See ticket: