Status Update
Comments
ke...@google.com <ke...@google.com> #2
se...@google.com <se...@google.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
cl...@google.com <cl...@google.com> #5
pr...@simformsolutions.com <pr...@simformsolutions.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit 00c37d0b6949835a7e8a2f68eb037c57bfc727fe
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 18:20:05 2024
Add bottomSheet constructor with safe args
Add NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args.
Test: ./gradlew compose:material:material-navigation:cC
Bug: 351858980
Relnote: "Added new NavGraphBuilder.bottomSheet builder to create a bottomSheet with safe args"
Change-Id: I28589fd1d67de6a23167e6a7648f15d95ed4beb3
M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
M compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit fcc5e50056fef5c3a8e6e5ca6672117d58685520
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 22 17:38:13 2024
Add BottomSheetNavigatorDestinationBuilder
Refactor BottomSheet to use NavDestinationBuilder so that we can leverage existing infrastrcuture to create type-safe BottomSheet in a follow-up CL.
Test: existing tests
Bug: 351858980
Relnote: "Added new BottomSheetNavigatorDestinationBuilder to create a BottomSheetNavigator.Destination with Kotlin DSL"
Change-Id: I777dbf640b83cd3428fd37c4ff5a8065f9ff856e
M compose/material/material-navigation/api/current.txt
M compose/material/material-navigation/api/restricted_current.txt
M compose/material/material-navigation/build.gradle
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigatorDestinationBuilder.kt
M compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
cl...@google.com <cl...@google.com> #9
Public release date TBD but in the meantime, this new feature can be accessed through
cl...@google.com <cl...@google.com> #10
Passing to Jose regarding release
re...@gmail.com <re...@gmail.com> #11
Any update on the release date please?
ka...@gmail.com <ka...@gmail.com> #12
I ma still waiting for the release. I have tried the SNAPSHOT version but that also requires androidCompileSdkVersion = 35, which is inconvenient with all the edge-to-edge changes. Is it possible to have the release and not require androidCompileSdkVersion 35?
ma...@finshape.com <ma...@finshape.com> #13
But Material3 still missing this feature:
se...@google.com <se...@google.com>
m....@gmail.com <m....@gmail.com> #14
ni...@gmail.com <ni...@gmail.com> #15
Any updates? Will M3 be able to access NavGraphBuilder.bottomSheet on the next stable release? Regular material has this planned according to:
Description
Compose started to support type-safe navigation but the functionality is missing for the bottom sheet. The navigation team said that the issue should be filed with the material team. See ticket: https://issuetracker.google.com/issues/188693139