Support Nullable Primitives or Lint Warning in Typesafe Navigation [351994237]

Fixed

Feature Request

Status Update

No update yet.

Description

ag...@wayfair.com

created issue #1

Jul 9, 2024 01:51PM

Component used: Navigation Version used: 2.8.0-beta03 Devices/Android versions reproduced on:

Simply make a class with a nullable primitive like an Int?

@Serializable data class ExampleRoute(val accountMethod: Int?)

and runtime crash:

java.lang.IllegalArgumentException: integer does not allow nullable values
at androidx.navigation.NavArgument.<init>(NavArgument.kt:210)
at androidx.navigation.NavArgument$Builder.build(NavArgument.kt:199)
at androidx.navigation.NavArgumentBuilder.build(NavDestinationBuilder.kt:394)
at androidx.navigation.NamedNavArgumentKt.navArgument(NamedNavArgument.kt:21)
at androidx.navigation.serialization.RouteSerializerKt.generateNavArguments(RouteSerializer.kt:109)
at androidx.navigation.NavDestinationBuilder.<init>(NavDestinationBuilder.kt:94)
at androidx.navigation.compose.ComposeNavigatorDestinationBuilder.<init>(ComposeNavigatorDestinationBuilder.kt:95)

In the IDE, there is no indication this is wrong, and is perfectly valid in Kotlinx serialization. I understand complex types requiring a barrier, but a nullable primitive seems logical in kotlin. A lint warning or error would be also highly helpful to prevent this from potentially crashing at runtime.

Comments

jb...@google.com <jb...@google.com> Jul 9, 2024 01:51PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Jul 23, 2024 11:28PM

since these are in public API (:/) we need to do this in 1.2

cl...@google.com <cl...@google.com> Jul 24, 2024 01:06AM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #3Jul 24, 2024 06:47PM

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4Jul 24, 2024 06:50PM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Jul 24, 2024 06:52PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

cl...@google.com <cl...@google.com> #6Jul 24, 2024 07:06PM

Marked as fixed.

Added built-in support of the following nullable primitives

Int?, Boolean?, Float?, Long?

These primitives will no longer require custom NavTypes.

Note that this support only applies to safe args in Kotlin DSL. XML-based navigation will continue to only support non-nullable primitives.

Will be available in the navigation release on Aug 7th.

ap...@google.com <ap...@google.com> #7Jul 25, 2024 11:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3cba58164e32afa04d092ba3b4ab8dc326451290
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 24 17:10:19 2024

Add support for nullable Enums in safe args

Refactored helper function `parseSerializableOrParcelableType` to take a `clazz: Class<*>` instead of `className: String` so that it can be better reused by NavTypeConverter.

Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 351994237
Relnote: "Navigation in safe args has added built-in support for argumnets of type `Enum<*>?`."
Change-Id: Ide076fd4f77daf8373d71e093f833920aba9b911

M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavType.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3195076

pr...@google.com <pr...@google.com> #8Aug 13, 2024 06:59PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-beta07
androidx.navigation:navigation-runtime:2.8.0-beta07